Skip to content

Commit 0d9afab

Browse files
authored
[KeyVault] - Fix incorrect paths to keyvault-common (Azure#15751)
## What -Ensure all imports to keyvault-common go through the src directory ## Why We noticed that rollup failed to find imports from keyvault common when we updated our test dependencies to use the published KV Keys version. This is not an issue when we were using the version of KV Keys on master because of the way rush would use symlinks; however, this is an issue in a certain edge case and therefore should be fixed, Longer term we'd like to run at least one of our packages against the published version to find issues like this sooner.
1 parent efc3a2b commit 0d9afab

File tree

12 files changed

+26
-11
lines changed

12 files changed

+26
-11
lines changed

sdk/keyvault/keyvault-admin/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Release History
22

3+
## 4.0.1 (2021-06-15)
4+
5+
### Bug Fixes
6+
7+
- Fixed an issue where bundling could fail when importing this library due to an incorrectly set import.
8+
39
## 4.0.0 (2021-06-15)
410

511
This release marks the general availability of the `@azure/keyvault-admin` package.

sdk/keyvault/keyvault-admin/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@azure/keyvault-admin",
33
"sdk-type": "client",
44
"author": "Microsoft Corporation",
5-
"version": "4.0.0",
5+
"version": "4.0.1",
66
"license": "MIT",
77
"description": "Isomorphic client library for Azure KeyVault's administrative functions.",
88
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-admin/README.md",

sdk/keyvault/keyvault-admin/src/backupClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
} from "@azure/core-http";
1111
import { PollerLike } from "@azure/core-lro";
1212

13-
import { challengeBasedAuthenticationPolicy } from "../../keyvault-common";
13+
import { challengeBasedAuthenticationPolicy } from "../../keyvault-common/src";
1414
import { KeyVaultClient } from "./generated/keyVaultClient";
1515
import {
1616
KeyVaultBackupClientOptions,

sdk/keyvault/keyvault-admin/src/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
/**
55
* Current version of the Key Vault Admin SDK.
66
*/
7-
export const SDK_VERSION: string = "4.0.0";
7+
export const SDK_VERSION: string = "4.0.1";
88

99
/**
1010
* The latest supported Key Vault service API version.

sdk/keyvault/keyvault-admin/src/generated/keyVaultClientContext.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import * as coreHttp from "@azure/core-http";
1010
import { KeyVaultClientOptionalParams } from "./models";
1111

1212
const packageName = "@azure/keyvault-admin";
13-
export const packageVersion = "4.0.0";
13+
export const packageVersion = "4.0.1";
1414

1515
export class KeyVaultClientContext extends coreHttp.ServiceClient {
1616
apiVersion: string;

sdk/keyvault/keyvault-admin/swagger/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ input-file:
1717
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/1e2c9f3ec93078da8078389941531359e274f32a/specification/keyvault/data-plane/Microsoft.KeyVault/stable/7.2/backuprestore.json
1818
output-folder: ../
1919
source-code-folder-path: ./src/generated
20-
package-version: 4.0.0-beta.4
20+
package-version: 4.0.1
2121
```
2222
2323
### Hide LROs

sdk/keyvault/keyvault-keys/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Release History
22

3+
## 4.2.1 (2021-06-15)
4+
5+
### Bug Fixes
6+
7+
- Fixed an issue where bundling could fail when importing this library due to an incorrectly set import.
8+
39
## 4.2.0 (2021-06-15)
410

511
### New Features

sdk/keyvault/keyvault-keys/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@azure/keyvault-keys",
33
"sdk-type": "client",
44
"author": "Microsoft Corporation",
5-
"version": "4.2.0",
5+
"version": "4.2.1",
66
"license": "MIT",
77
"description": "Isomorphic client library for Azure KeyVault's keys.",
88
"homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-keys/README.md",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT license.
33

4-
export const SDK_VERSION: string = "4.2.0";
4+
export const SDK_VERSION: string = "4.2.1";

sdk/keyvault/keyvault-keys/src/cryptography/remoteCryptographyProvider.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import {
2323
SignOptions,
2424
SignResult
2525
} from "../cryptographyClientModels";
26-
import { challengeBasedAuthenticationPolicy } from "../../../keyvault-common";
2726
import { SDK_VERSION } from "../constants";
2827
import { UnwrapResult } from "../cryptographyClientModels";
2928
import { KeyVaultClient } from "../generated";
@@ -38,7 +37,11 @@ import { getKeyFromKeyBundle } from "../transformations";
3837
import { createHash } from "./crypto";
3938
import { CryptographyProvider, CryptographyProviderOperation } from "./models";
4039
import { logger } from "../log";
41-
import { createTraceFunction, TracedFunction } from "../../../keyvault-common/src";
40+
import {
41+
createTraceFunction,
42+
TracedFunction,
43+
challengeBasedAuthenticationPolicy
44+
} from "../../../keyvault-common/src";
4245

4346
const withTrace: TracedFunction = createTraceFunction(
4447
"Azure.KeyVault.Keys.RemoteCryptographyProvider"

0 commit comments

Comments
 (0)