Removing type validation for errors (Azure#19361)

* Removing type validation for errors

* dummy commit

* Revert "Removing type validation for errors"

This reverts commit 0c6d019.

* check for Error instance

In min/max testing `instanceof RestError` failed. I suspect that the RestError
type and the instance are from two different versions of core-http.

Co-authored-by: Harsha Nalluru <[email protected]>
Co-authored-by: Jeremy Meng <[email protected]>

Author: 3 people

sdk/appconfiguration/app-configuration/test/public/utils/testHelpers.ts

@@ -163,11 +163,12 @@ export async function assertThrowsRestError(
     await testFunction();
     assert.fail(`${message}: No error thrown`);
   } catch (err) {
-    if (!(err instanceof RestError)) {
+    if (!(err instanceof Error)) {
       throw new Error("Error is not recognized");
     }
     if (err.name === "RestError") {
-      assert.equal(expectedStatusCode, err.statusCode, message);
+      const restError = err as RestError;
+      assert.equal(expectedStatusCode, restError.statusCode, message);
       return err;
     }