Skip to content

Commit b92879e

Browse files
azure-sdkweshaggardczubair
authored
Sync eng/common directory with azure-sdk-tools for PR 2691 (Azure#20238)
* Update prepare-release parameter documentation * Apply suggestions from code review Co-authored-by: Cala Zubair <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Cala Zubair <[email protected]>
1 parent ed0464f commit b92879e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,13 +411,13 @@ function FindOrCreateClonePackageWorkItem($lang, $pkg, $verMajorMinor, $allowPro
411411

412412
if ($allowPrompt) {
413413
if (!$pkg.DisplayName) {
414-
Write-Host "We need a package display name to be used in various places and it should be consistent across languages for similar packages."
414+
Write-Host "Display name is used to identify this package across languages and is usually the friendly name (i.e. For 'Azure Anomaly Detector' it would be 'Anomaly Detector'. For 'Azure Cognitive Search' it would be 'Search'.). See https://aka.ms/azsdk/mark-release-status for more info."
415415
while (($readInput = Read-Host -Prompt "Input the display name") -eq "") { }
416416
$packageInfo.DisplayName = $readInput
417417
}
418418

419419
if (!$pkg.ServiceName) {
420-
Write-Host "We need a package service name to be used in various places and it should be consistent across languages for similar packages."
420+
Write-Host "This is the friendly service name for this package that is used to align it with other packages and languages (i.e., no need to include 'Azure' or 'Microsoft' in the title). The service name is sometimes the same as the `Package Display Name` if there is only one package for a service. (i.e. For 'Azure Anomaly Detector' it would be 'Anomaly Detector'). For services that ship multiple packages be sure to list the service only. (i.e. For 'Schema Registry Avro', the service name is just 'Schema Registry'; For 'Key Vault Certificates', the service name is simply Key Vault.). See https://aka.ms/azsdk/mark-release-status for more info."
421421
while (($readInput = Read-Host -Prompt "Input the service name") -eq "") { }
422422
$packageInfo.ServiceName = $readInput
423423
}

eng/common/scripts/Prepare-Release.ps1

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,18 @@ This script will do a number of things when ran:
1212
- If there is existing release work item it will update it and if not it will create one.
1313
- It will validate that the changelog has a entry for the package version that you want to release as well as a timestamp.
1414
15+
For more information see https://aka.ms/azsdk/mark-release-status.
16+
1517
.PARAMETER PackageName
1618
The full package name of the package you want to prepare for release. (i.e Azure.Core, azure-core, @azure/core-https)
1719
1820
.PARAMETER ServiceDirectory
19-
Optional: The service directory where the package lives (e.g. /sdk/<service directory>/<package>). If a service directory isn't provided the script
20-
will search for the package project by traversing all the packages under /sdk/, so the service directory is only a scoping mechanism.
21+
Optional: Provide a service directory to scope the search of the entire repo to speed-up the project search. This should be the directory
22+
name under the 'sdk' folder (i.e for the core package which lives under 'sdk\core' the value to pass would be 'core').
2123
2224
.PARAMETER ReleaseDate
23-
Optional: If not shipping on the normal first Tuesday of the month you can specify a specific release date in the form of "MM/dd/yyyy".
25+
Optional: Provide a specific date for when you plan to release the package. Should be the date (MM/dd/yyyy) that the given package is going to ship.
26+
If one isn't provided, then it will compute the next ship date or today's date if past the ship date for the month as the planned date.
2427
2528
.PARAMETER ReleaseTrackingOnly
2629
Optional: If this switch is passed then the script will only update the release work items and not update the versions in the local repo or validate the changelog.
@@ -151,7 +154,7 @@ if ($LASTEXITCODE -ne 0) {
151154

152155
# Check API status if version is GA
153156
if (!$newVersionParsed.IsPrerelease)
154-
{
157+
{
155158
try
156159
{
157160
az account show *> $null

0 commit comments

Comments
 (0)