Skip to content

Commit b933b45

Browse files
authored
feature/v4 (Azure#18158)
1 parent 98b85fd commit b933b45

15 files changed

+98
-140
lines changed

sdk/datacatalog/arm-datacatalog/LICENSE.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2018 Microsoft
3+
Copyright (c) 2021 Microsoft
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

sdk/datacatalog/arm-datacatalog/README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
## Azure DataCatalogRestClient SDK for JavaScript
22

3-
This package contains an isomorphic SDK (runs both in Node.js and in browsers) for DataCatalogRestClient.
3+
This package contains an isomorphic SDK (runs both in node.js and in browsers) for DataCatalogRestClient.
44

55
### Currently supported environments
66

77
- [LTS versions of Node.js](https://nodejs.org/about/releases/)
8-
- Latest versions of Safari, Chrome, Edge, and Firefox.
8+
- Latest versions of Safari, Chrome, Edge and Firefox.
99

1010
### Prerequisites
1111

@@ -21,7 +21,6 @@ Install both packages using the below command:
2121
```bash
2222
npm install --save @azure/arm-datacatalog @azure/identity
2323
```
24-
2524
> **Note**: You may have used either `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` in the past. These packages are in maintenance mode receiving critical bug fixes, but no new features.
2625
If you are on a [Node.js that has LTS status](https://nodejs.org/about/releases/), or are writing a client side browser application, we strongly encourage you to upgrade to `@azure/identity` which uses the latest versions of Azure Active Directory and MSAL APIs and provides more authentication options.
2726

@@ -37,7 +36,6 @@ If you are on a [Node.js that has LTS status](https://nodejs.org/about/releases/
3736

3837
In the below samples, we pass the credential and the Azure subscription id to instantiate the client.
3938
Once the client is created, explore the operations on it either in your favorite editor or in our [API reference documentation](https://docs.microsoft.com/javascript/api) to get started.
40-
4139
#### nodejs - Authentication, client creation, and list aDCOperations as an example written in JavaScript.
4240

4341
##### Sample code
@@ -51,7 +49,6 @@ const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
5149
// Please note that you can also use credentials from the `@azure/ms-rest-nodeauth` package instead.
5250
const creds = new DefaultAzureCredential();
5351
const client = new DataCatalogRestClient(creds, subscriptionId);
54-
5552
client.aDCOperations.list().then((result) => {
5653
console.log("The result is:");
5754
console.log(result);
@@ -86,7 +83,7 @@ In browser applications, we recommend using the `InteractiveBrowserCredential` t
8683
const credential = new InteractiveBrowserCredential(
8784
{
8885
clientId: "<client id for your Azure AD app>",
89-
tenantId: "<optional tenant for your organization>"
86+
tenant: "<optional tenant for your organization>"
9087
});
9188
const client = new Azure.ArmDatacatalog.DataCatalogRestClient(creds, subscriptionId);
9289
client.aDCOperations.list().then((result) => {

sdk/datacatalog/arm-datacatalog/package.json

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
"name": "@azure/arm-datacatalog",
33
"author": "Microsoft Corporation",
44
"description": "DataCatalogRestClient Library with typescript type definitions for node.js and browser.",
5-
"version": "1.2.1",
5+
"version": "2.0.0",
66
"dependencies": {
7-
"@azure/ms-rest-azure-js": "^1.4.0",
8-
"@azure/ms-rest-js": "^1.11.0",
7+
"@azure/ms-rest-azure-js": "^2.1.0",
8+
"@azure/ms-rest-js": "^2.2.0",
99
"@azure/core-auth": "^1.1.4",
10-
"tslib": "^1.9.3"
10+
"tslib": "^1.10.0"
1111
},
1212
"keywords": [
1313
"node",
@@ -22,17 +22,18 @@
2222
"types": "./esm/dataCatalogRestClient.d.ts",
2323
"devDependencies": {
2424
"typescript": "^3.6.0",
25-
"rollup": "^0.66.2",
26-
"rollup-plugin-node-resolve": "^3.4.0",
27-
"uglify-js": "^3.4.9"
25+
"rollup": "^1.18.0",
26+
"rollup-plugin-node-resolve": "^5.2.0",
27+
"rollup-plugin-sourcemaps": "^0.4.2",
28+
"uglify-js": "^3.6.0"
2829
},
29-
"homepage": "https://github.com/azure/azure-sdk-for-js/tree/feature/v4/sdk/datacatalog/arm-datacatalog",
30+
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/feature/v4/sdk/datacatalog/arm-datacatalog",
3031
"repository": {
3132
"type": "git",
32-
"url": "https://github.com/azure/azure-sdk-for-js.git"
33+
"url": "https://github.com/Azure/azure-sdk-for-js.git"
3334
},
3435
"bugs": {
35-
"url": "https://github.com/azure/azure-sdk-for-js/issues"
36+
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
3637
},
3738
"files": [
3839
"dist/**/*.js",
@@ -44,6 +45,7 @@
4445
"esm/**/*.d.ts",
4546
"esm/**/*.d.ts.map",
4647
"src/**/*.ts",
48+
"README.md",
4749
"rollup.config.js",
4850
"tsconfig.json"
4951
],
Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
1+
import rollup from "rollup";
12
import nodeResolve from "rollup-plugin-node-resolve";
3+
import sourcemaps from "rollup-plugin-sourcemaps";
4+
25
/**
3-
* @type {import('rollup').RollupFileOptions}
6+
* @type {rollup.RollupFileOptions}
47
*/
58
const config = {
6-
input: './esm/dataCatalogRestClient.js',
7-
external: ["@azure/ms-rest-js", "@azure/ms-rest-azure-js"],
9+
input: "./esm/dataCatalogRestClient.js",
10+
external: [
11+
"@azure/ms-rest-js",
12+
"@azure/ms-rest-azure-js"
13+
],
814
output: {
915
file: "./dist/arm-datacatalog.js",
1016
format: "umd",
@@ -15,17 +21,17 @@ const config = {
1521
"@azure/ms-rest-azure-js": "msRestAzure"
1622
},
1723
banner: `/*
18-
* Copyright (c) Microsoft Corporation. All rights reserved.
19-
* Licensed under the MIT License. See License.txt in the project root for
20-
* license information.
24+
* Copyright (c) Microsoft Corporation.
25+
* Licensed under the MIT License.
2126
*
2227
* Code generated by Microsoft (R) AutoRest Code Generator.
23-
* Changes may cause incorrect behavior and will be lost if the code is
24-
* regenerated.
28+
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
2529
*/`
2630
},
2731
plugins: [
28-
nodeResolve({ module: true })
32+
nodeResolve({ mainFields: ['module', 'main'] }),
33+
sourcemaps()
2934
]
3035
};
36+
3137
export default config;

sdk/datacatalog/arm-datacatalog/src/dataCatalogRestClient.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/*
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for
4-
* license information.
2+
* Copyright (c) Microsoft Corporation.
3+
* Licensed under the MIT License.
54
*
65
* Code generated by Microsoft (R) AutoRest Code Generator.
76
* Changes may cause incorrect behavior and will be lost if the code is
@@ -31,7 +30,8 @@ class DataCatalogRestClient extends DataCatalogRestClientContext {
3130
* @azure/ms-rest-browserauth are also supported.
3231
* @param subscriptionId Gets subscription credentials which uniquely identify the Microsoft Azure
3332
* subscription. The subscription ID forms part of the URI for every service call.
34-
* @param catalogName The name of the data catlog in the specified subscription and resource group.
33+
* @param catalogName The name of the data catalog in the specified subscription and resource
34+
* group.
3535
* @param [options] The parameter options
3636
*/
3737
constructor(credentials: msRest.ServiceClientCredentials | TokenCredential, subscriptionId: string, catalogName: string, options?: Models.DataCatalogRestClientOptions) {

sdk/datacatalog/arm-datacatalog/src/dataCatalogRestClientContext.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/*
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for
4-
* license information.
2+
* Copyright (c) Microsoft Corporation.
3+
* Licensed under the MIT License.
54
*
65
* Code generated by Microsoft (R) AutoRest Code Generator.
76
* Changes may cause incorrect behavior and will be lost if the code is
@@ -10,11 +9,11 @@
109

1110
import * as Models from "./models";
1211
import * as msRest from "@azure/ms-rest-js";
13-
import { TokenCredential } from "@azure/core-auth";
1412
import * as msRestAzure from "@azure/ms-rest-azure-js";
13+
import { TokenCredential } from "@azure/core-auth";
1514

1615
const packageName = "@azure/arm-datacatalog";
17-
const packageVersion = "1.2.1";
16+
const packageVersion = "2.0.0";
1817

1918
export class DataCatalogRestClientContext extends msRestAzure.AzureServiceClient {
2019
credentials: msRest.ServiceClientCredentials | TokenCredential;
@@ -32,7 +31,8 @@ export class DataCatalogRestClientContext extends msRestAzure.AzureServiceClient
3231
* @azure/ms-rest-browserauth are also supported.
3332
* @param subscriptionId Gets subscription credentials which uniquely identify the Microsoft Azure
3433
* subscription. The subscription ID forms part of the URI for every service call.
35-
* @param catalogName The name of the data catlog in the specified subscription and resource group.
34+
* @param catalogName The name of the data catalog in the specified subscription and resource
35+
* group.
3636
* @param [options] The parameter options
3737
*/
3838
constructor(credentials: msRest.ServiceClientCredentials | TokenCredential, subscriptionId: string, catalogName: string, options?: Models.DataCatalogRestClientOptions) {
Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
/*
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for
4-
* license information.
2+
* Copyright (c) Microsoft Corporation.
3+
* Licensed under the MIT License.
54
*
65
* Code generated by Microsoft (R) AutoRest Code Generator.
7-
* Changes may cause incorrect behavior and will be lost if the code is
8-
* regenerated.
6+
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
97
*/
108

119
export {
12-
ADCCatalogsListResult,
1310
ADCCatalog,
14-
Resource,
11+
ADCCatalogsListResult,
1512
BaseResource,
13+
CloudError,
1614
Principals,
17-
CloudError
15+
Resource
1816
} from "../models/mappers";
19-
Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
/*
2-
* Copyright (c) Microsoft Corporation. All rights reserved.
3-
* Licensed under the MIT License. See License.txt in the project root for
4-
* license information.
2+
* Copyright (c) Microsoft Corporation.
3+
* Licensed under the MIT License.
54
*
65
* Code generated by Microsoft (R) AutoRest Code Generator.
7-
* Changes may cause incorrect behavior and will be lost if the code is
8-
* regenerated.
6+
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
97
*/
108

119
export {
12-
OperationEntityListResult,
13-
OperationEntity,
10+
CloudError,
1411
OperationDisplayInfo,
15-
CloudError
12+
OperationEntity,
13+
OperationEntityListResult
1614
} from "../models/mappers";
17-

0 commit comments

Comments
 (0)