fix error when parsing id with subscriptions of other resource types (Azure#25078)

* fix error when parsing subscriptions of other resource types; add a test case using id from ApiManagement and ServiceBus

* use switch rather than if

* using subscription's parent resource type to judge

* correct typo

Azure#24861

Author: yukun-dong

sdk/resourcemanager/Azure.ResourceManager/src/ResourceIdentifier.cs

@@ -105,7 +105,8 @@ private void Init(ResourceIdentifier parent, ResourceType resourceType, string n
         private static ResourceType ChooseResourceType(string resourceTypeName, ResourceIdentifier parent) => resourceTypeName.ToLowerInvariant() switch
         {
             ResourceGroupsLowerKey => ResourceGroup.ResourceType,
-            SubscriptionsKey => Subscription.ResourceType,
+            //subscriptions' type is Microsoft.Resources/subscriptions only when its parent is Tenant
+            SubscriptionsKey when parent.ResourceType==Tenant.ResourceType => Subscription.ResourceType,
             _ => new ResourceType(parent.ResourceType, resourceTypeName)
         };
 
@@ -127,7 +128,7 @@ public static ResourceIdentifier Create(string resourceId)
                 throw new ArgumentOutOfRangeException(nameof(resourceId), "Invalid resource id.");
 
             var firstToLower = parts[0].ToLowerInvariant();
-            if (firstToLower != SubscriptionsKey  && firstToLower != ProvidersKey)
+            if (firstToLower != SubscriptionsKey && firstToLower != ProvidersKey)
                 throw new ArgumentOutOfRangeException(nameof(resourceId), "Invalid resource id.");
 
             return AppendNext(RootResourceIdentifier, parts);
@@ -384,7 +385,7 @@ public override int GetHashCode()
         /// <returns></returns>
         public static bool operator ==(ResourceIdentifier id1, ResourceIdentifier id2)
         {
-            return ResourceIdentifier.Equals(id1,id2);
+            return ResourceIdentifier.Equals(id1, id2);
         }
 
         /// <summary>
@@ -395,7 +396,7 @@ public override int GetHashCode()
         /// <returns></returns>
         public static bool operator !=(ResourceIdentifier id1, ResourceIdentifier id2)
         {
-            return !ResourceIdentifier.Equals(id1,id2);
+            return !ResourceIdentifier.Equals(id1, id2);
         }
 
         /// <summary>

sdk/resourcemanager/Azure.ResourceManager/tests/Unit/ResourceIdentifierTests.cs

@@ -111,6 +111,16 @@ public void CanParseExtensionResourceIds(string baseId, string extensionNamespac
             Assert.AreEqual(targetResourceId, subject.Parent);
         }
 
+        [TestCase("/subscriptions/17fecd63-33d8-4e43-ac6f-0aafa111b38d/resourceGroups/myRg/providers/Microsoft.ApiManagement/service/myservicename/subscriptions/mysubscription", "Microsoft.ApiManagement/service/subscriptions",
+            Description = "From ApiManagement")]
+        [TestCase("/subscriptions/17fecd63-33d8-4e43-ac6f-0aafa111b38d/resourceGroups/myRg/providers/Microsoft.ServiceBus/namespaces/mynamespace/topics/mytopic/subscriptions/mysubscription", "Microsoft.ServiceBus/namespaces/topics/subscriptions",
+            Description = "From ServiceBus")]
+        public void CanParseResourceIdsWithSubscriptionsOfOtherResourceTypes(string resourceId, string expectedResourcetype)
+        {
+            ResourceIdentifier subject = resourceId;
+            Assert.AreEqual(expectedResourcetype, subject.ResourceType.ToString());
+        }
+
         [TestCase("UnformattedString", Description = "Too Few Elements")]
         [TestCase("/subs/sub1/rgs/rg1/", Description = "No known parts")]
         [TestCase("/subscriptions/sub1/rgs/rg1/", Description = "Subscription not a Guid")]