Enable API review approval check for Java spring packages (Azure#23362)

azure-sdk · praveenkuttappan · web-flow · commit bfd20d2de00c · 2021-08-17T09:50:53.000-07:00
Co-authored-by: praveenkuttappan &lt;prmarott@microsoft.com&gt;
diff --git a/eng/common/scripts/Create-APIReview.ps1 b/eng/common/scripts/Create-APIReview.ps1
@@ -140,7 +140,9 @@ if ($packages)
             else
             {
                 # Return error code if status code is 201 for new data plane package
-                if ($pkgInfo.SdkType -eq "client" -and $pkgInfo.IsNewSdk)
+                # Temporarily enable API review for spring SDK types. Ideally this should be done be using 'IsReviewRequired' method in language side
+                # to override default check of SDK type client 
+                if (($pkgInfo.SdkType -eq "client" -or $pkgInfo.SdkType -eq "spring") -and $pkgInfo.IsNewSdk)
                 {
                     if ($respCode -eq '201')
                     {

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,9 @@ if ($packages)`
`140`	`140`	`else`
`141`	`141`	`{`
`142`	`142`	`# Return error code if status code is 201 for new data plane package`
`143`		`- if ($pkgInfo.SdkType -eq "client" -and $pkgInfo.IsNewSdk)`
	`143`	`+ # Temporarily enable API review for spring SDK types. Ideally this should be done be using 'IsReviewRequired' method in language side`
	`144`	`+ # to override default check of SDK type client`
	`145`	`+ if (($pkgInfo.SdkType -eq "client" -or $pkgInfo.SdkType -eq "spring") -and $pkgInfo.IsNewSdk)`
`144`	`146`	`{`
`145`	`147`	`if ($respCode -eq '201')`
`146`	`148`	`{`