Don't allocate extra array and a ResponseClassifier during pipeline building (Azure#25441)

pakrym · web-flow · commit c654069e3d92 · 2021-11-22T18:43:43.000Z
diff --git a/sdk/core/Azure.Core.Experimental/tests/LowLevelClient/PetStoreClient.cs b/sdk/core/Azure.Core.Experimental/tests/LowLevelClient/PetStoreClient.cs
@@ -59,7 +59,7 @@ public PetStoreClient(Uri endpoint, TokenCredential credential, PetStoreClientOp
             var authPolicy = new BearerTokenAuthenticationPolicy(_tokenCredential, AuthorizationScopes);
 
             // TODO: When we move the IsError functionality into Core, we'll move the addition of ResponsePropertiesPolicy to the pipeline into HttpPipelineBuilder.
-            Pipeline = HttpPipelineBuilder.Build(options, new HttpPipelinePolicy[] { new LowLevelCallbackPolicy() }, new HttpPipelinePolicy[] { authPolicy, new ResponsePropertiesPolicy(options) }, new ResponseClassifier());
+            Pipeline = HttpPipelineBuilder.Build(options, new HttpPipelinePolicy[] { new LowLevelCallbackPolicy() }, new HttpPipelinePolicy[] { authPolicy, new ResponsePropertiesPolicy(options) }, null);
             this.endpoint = endpoint;
             apiVersion = options.Version;
         }
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net461.cs b/sdk/core/Azure.Core/api/Azure.Core.net461.cs
@@ -775,8 +775,8 @@ public void Send(Azure.Core.HttpMessage message, System.Threading.CancellationTo
     public static partial class HttpPipelineBuilder
     {
         public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, params Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
     }
     public abstract partial class HttpPipelinePolicy
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net5.0.cs b/sdk/core/Azure.Core/api/Azure.Core.net5.0.cs
@@ -775,8 +775,8 @@ public void Send(Azure.Core.HttpMessage message, System.Threading.CancellationTo
     public static partial class HttpPipelineBuilder
     {
         public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, params Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
     }
     public abstract partial class HttpPipelinePolicy
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs b/sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs
@@ -775,8 +775,8 @@ public void Send(Azure.Core.HttpMessage message, System.Threading.CancellationTo
     public static partial class HttpPipelineBuilder
     {
         public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, params Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
     }
     public abstract partial class HttpPipelinePolicy
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs b/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
@@ -775,8 +775,8 @@ public void Send(Azure.Core.HttpMessage message, System.Threading.CancellationTo
     public static partial class HttpPipelineBuilder
     {
         public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, params Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier) { throw null; }
-        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier) { throw null; }
+        public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }
     }
     public abstract partial class HttpPipelinePolicy
     {
diff --git a/sdk/core/Azure.Core/src/Pipeline/DisposableHttpPipeline.cs b/sdk/core/Azure.Core/src/Pipeline/DisposableHttpPipeline.cs
@@ -18,7 +18,7 @@ public sealed class DisposableHttpPipeline : HttpPipeline, IDisposable
         /// <param name="perRetryIndex"></param>
         /// <param name="policies">Policies to be invoked as part of the pipeline in order.</param>
         /// <param name="responseClassifier">The response classifier to be used in invocations.</param>
-        internal DisposableHttpPipeline(HttpPipelineTransport transport, int perCallIndex, int perRetryIndex, HttpPipelinePolicy[]? policies = null, ResponseClassifier? responseClassifier = null)
+        internal DisposableHttpPipeline(HttpPipelineTransport transport, int perCallIndex, int perRetryIndex, HttpPipelinePolicy[] policies, ResponseClassifier responseClassifier)
             : base(transport, perCallIndex, perRetryIndex, policies, responseClassifier)
         {
         }
diff --git a/sdk/core/Azure.Core/src/Pipeline/HttpPipeline.cs b/sdk/core/Azure.Core/src/Pipeline/HttpPipeline.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Buffers;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
 
@@ -48,9 +49,9 @@ public class HttpPipeline
         public HttpPipeline(HttpPipelineTransport transport, HttpPipelinePolicy[]? policies = null, ResponseClassifier? responseClassifier = null)
         {
             _transport = transport ?? throw new ArgumentNullException(nameof(transport));
-            ResponseClassifier = responseClassifier ?? new ResponseClassifier();
+            ResponseClassifier = responseClassifier ?? ResponseClassifier.Shared;
 
-            policies = policies ?? Array.Empty<HttpPipelinePolicy>();
+            policies ??= Array.Empty<HttpPipelinePolicy>();
 
             var all = new HttpPipelinePolicy[policies.Length + 1];
             all[policies.Length] = new HttpPipelineTransportPolicy(_transport);
@@ -59,8 +60,20 @@ public HttpPipeline(HttpPipelineTransport transport, HttpPipelinePolicy[]? polic
             _pipeline = all;
         }
 
-        internal HttpPipeline(HttpPipelineTransport transport, int perCallIndex, int perRetryIndex, HttpPipelinePolicy[]? policies = null, ResponseClassifier? responseClassifier = null) : this(transport, policies, responseClassifier)
+        internal HttpPipeline(
+            HttpPipelineTransport transport,
+            int perCallIndex,
+            int perRetryIndex,
+            HttpPipelinePolicy[] pipeline,
+            ResponseClassifier responseClassifier)
         {
+            ResponseClassifier = responseClassifier ?? throw new ArgumentNullException(nameof(responseClassifier));
+
+            _transport = transport ?? throw new ArgumentNullException(nameof(transport));
+            _pipeline = pipeline ?? throw new ArgumentNullException(nameof(pipeline));
+
+            Debug.Assert(pipeline[pipeline.Length - 1] is HttpPipelineTransportPolicy);
+
             _perCallIndex = perCallIndex;
             _perRetryIndex = perRetryIndex;
             _internallyConstructed = true;
diff --git a/sdk/core/Azure.Core/src/Pipeline/HttpPipelineBuilder.cs b/sdk/core/Azure.Core/src/Pipeline/HttpPipelineBuilder.cs
@@ -22,7 +22,7 @@ public static class HttpPipelineBuilder
         /// <returns>A new instance of <see cref="HttpPipeline"/></returns>
         public static HttpPipeline Build(ClientOptions options, params HttpPipelinePolicy[] perRetryPolicies)
         {
-            return Build(options, Array.Empty<HttpPipelinePolicy>(), perRetryPolicies, new ResponseClassifier());
+            return Build(options, Array.Empty<HttpPipelinePolicy>(), perRetryPolicies, ResponseClassifier.Shared);
         }
 
         /// <summary>
@@ -37,7 +37,7 @@ public static HttpPipeline Build(
             ClientOptions options,
             HttpPipelinePolicy[] perCallPolicies,
             HttpPipelinePolicy[] perRetryPolicies,
-            ResponseClassifier responseClassifier)
+            ResponseClassifier? responseClassifier)
         {
             return Build(options, perCallPolicies, perRetryPolicies, responseClassifier, null);
         }
@@ -51,10 +51,8 @@ public static HttpPipeline Build(
         /// <param name="responseClassifier">The client provided response classifier.</param>
         /// <param name="defaultTransportOptions">The customer provided transport options which will be applied to the default transport.</param>
         /// <returns>A new instance of <see cref="HttpPipeline"/></returns>
-        public static HttpPipeline Build(ClientOptions options, HttpPipelinePolicy[] perCallPolicies, HttpPipelinePolicy[] perRetryPolicies, ResponseClassifier responseClassifier, HttpPipelineTransportOptions? defaultTransportOptions)
+        public static HttpPipeline Build(ClientOptions options, HttpPipelinePolicy[] perCallPolicies, HttpPipelinePolicy[] perRetryPolicies, ResponseClassifier? responseClassifier, HttpPipelineTransportOptions? defaultTransportOptions)
         {
-            int perCallIndex;
-            int perRetryIndex;
             if (perCallPolicies == null)
             {
                 throw new ArgumentNullException(nameof(perCallPolicies));
@@ -97,7 +95,7 @@ void AddCustomerPolicies(HttpPipelinePosition position)
             AddCustomerPolicies(HttpPipelinePosition.PerCall);
 
             policies.RemoveAll(static policy => policy == null);
-            perCallIndex = policies.Count;
+            var perCallIndex = policies.Count;
 
             policies.Add(ClientRequestIdPolicy.Shared);
 
@@ -116,7 +114,8 @@ void AddCustomerPolicies(HttpPipelinePosition position)
             AddCustomerPolicies(HttpPipelinePosition.PerRetry);
 
             policies.RemoveAll(static policy => policy == null);
-            perRetryIndex = policies.Count;
+
+            var perRetryIndex = policies.Count;
 
             if (diagnostics.IsLoggingEnabled)
             {
@@ -134,6 +133,7 @@ void AddCustomerPolicies(HttpPipelinePosition position)
 
             // Override the provided Transport with the provided transport options if the transport has not been set after default construction and options are not null.
             HttpPipelineTransport transport = options.Transport;
+            bool disposablePipeline = false;
             if (defaultTransportOptions != null)
             {
                 if (options.IsCustomTransportSet)
@@ -147,14 +147,22 @@ void AddCustomerPolicies(HttpPipelinePosition position)
                 else
                 {
                     transport = HttpPipelineTransport.Create(defaultTransportOptions);
-                    return new DisposableHttpPipeline(transport,
-                        perCallIndex,
-                        perRetryIndex,
-                        policies.ToArray(),
-                        responseClassifier);
                 }
             }
 
+            policies.Add(new HttpPipelineTransportPolicy(transport));
+
+            responseClassifier ??= ResponseClassifier.Shared;
+
+            if (disposablePipeline)
+            {
+                return new DisposableHttpPipeline(transport,
+                    perCallIndex,
+                    perRetryIndex,
+                    policies.ToArray(),
+                    responseClassifier);
+            }
+
             return new HttpPipeline(transport,
                 perCallIndex,
                 perRetryIndex,
diff --git a/sdk/core/Azure.Core/src/ResponseClassifier.cs b/sdk/core/Azure.Core/src/ResponseClassifier.cs
@@ -11,6 +11,8 @@ namespace Azure.Core
     /// </summary>
     public class ResponseClassifier
     {
+        internal static ResponseClassifier Shared { get; } = new();
+
         /// <summary>
         /// Specifies if the request contained in the <paramref name="message"/> should be retried.
         /// </summary>
diff --git a/sdk/core/Azure.Core/tests/HttpPipelineBuilderTest.cs b/sdk/core/Azure.Core/tests/HttpPipelineBuilderTest.cs
@@ -216,7 +216,7 @@ public void SetTransportOptions([Values(true, false)] bool isCustomTransportSet)
                 options,
                 Array.Empty<HttpPipelinePolicy>(),
                 Array.Empty<HttpPipelinePolicy>(),
-                new ResponseClassifier(),
+                ResponseClassifier.Shared,
                 new HttpPipelineTransportOptions());
 
             HttpPipelineTransport transportField = pipeline.GetType().GetField("_transport", BindingFlags.Instance | BindingFlags.NonPublic | BindingFlags.GetField).GetValue(pipeline) as HttpPipelineTransport;
diff --git a/sdk/core/Azure.Core/tests/HttpPipelineMessageTest.cs b/sdk/core/Azure.Core/tests/HttpPipelineMessageTest.cs
@@ -16,7 +16,7 @@ public class HttpPipelineMessageTest
         public void DisposeNoopsForNullResponse()
         {
             var requestMock = new Mock<Request>();
-            HttpMessage message = new HttpMessage(requestMock.Object, new ResponseClassifier());
+            HttpMessage message = new HttpMessage(requestMock.Object, ResponseClassifier.Shared);
             message.Dispose();
             requestMock.Verify(r => r.Dispose(), Times.Once);
         }
@@ -26,7 +26,7 @@ public void DisposingMessageDisposesTheRequestAndResponse()
         {
             var requestMock = new Mock<Request>();
             var responseMock = new Mock<Response>();
-            HttpMessage message = new HttpMessage(requestMock.Object, new ResponseClassifier());
+            HttpMessage message = new HttpMessage(requestMock.Object, ResponseClassifier.Shared);
             message.Response = responseMock.Object;
             message.Dispose();
             requestMock.Verify(r => r.Dispose(), Times.Once);
@@ -40,7 +40,7 @@ public void PreserveReturnsResponseStream()
             var response = new MockResponse(200);
             response.ContentStream = mockStream.Object;
 
-            HttpMessage message = new HttpMessage(new MockRequest(), new ResponseClassifier());
+            HttpMessage message = new HttpMessage(new MockRequest(), ResponseClassifier.Shared);
             message.Response = response;
 
             Stream stream = message.ExtractResponseContent();
@@ -56,7 +56,7 @@ public void PreserveReturnsNullWhenContentIsNull()
             var response = new MockResponse(200);
             response.ContentStream = null;
 
-            HttpMessage message = new HttpMessage(new MockRequest(), new ResponseClassifier());
+            HttpMessage message = new HttpMessage(new MockRequest(), ResponseClassifier.Shared);
             message.Response = response;
 
             Stream stream = message.ExtractResponseContent();
@@ -71,7 +71,7 @@ public void PreserveSetsResponseContentToThrowingStream()
             var response = new MockResponse(200);
             response.ContentStream = mockStream.Object;
 
-            HttpMessage message = new HttpMessage(new MockRequest(), new ResponseClassifier());
+            HttpMessage message = new HttpMessage(new MockRequest(), ResponseClassifier.Shared);
             message.Response = response;
 
             Stream stream = message.ExtractResponseContent();
@@ -88,7 +88,7 @@ public void ContentPropertyThrowsResponseIsExtracted()
             var response = new MockResponse(200);
             response.ContentStream = memoryStream;
 
-            HttpMessage message = new HttpMessage(new MockRequest(), new ResponseClassifier());
+            HttpMessage message = new HttpMessage(new MockRequest(), ResponseClassifier.Shared);
             message.Response = response;
 
             Assert.AreEqual(memoryStream.ToArray(), message.Response.Content.ToArray());
diff --git a/sdk/core/Azure.Core/tests/PipelineTestBase.cs b/sdk/core/Azure.Core/tests/PipelineTestBase.cs
@@ -18,7 +18,7 @@ public PipelineTestBase(bool isAsync)
 
         protected async Task<Response> ExecuteRequest(Request request, HttpPipelineTransport transport, CancellationToken cancellationToken = default)
         {
-            var message = new HttpMessage(request, new ResponseClassifier());
+            var message = new HttpMessage(request, ResponseClassifier.Shared);
             message.CancellationToken = cancellationToken;
             if (_isAsync)
             {
@@ -33,7 +33,7 @@ protected async Task<Response> ExecuteRequest(Request request, HttpPipelineTrans
 
         protected async Task<Response> ExecuteRequest(Request request, HttpPipeline pipeline, CancellationToken cancellationToken = default)
         {
-            var message = new HttpMessage(request, new ResponseClassifier());
+            var message = new HttpMessage(request, ResponseClassifier.Shared);
             return await ExecuteRequest(message, pipeline, cancellationToken);
         }
 
diff --git a/sdk/core/Azure.Core/tests/PipelineTests.cs b/sdk/core/Azure.Core/tests/PipelineTests.cs
diff --git a/sdk/core/Azure.Core/tests/ResponseClassifierTests.cs b/sdk/core/Azure.Core/tests/ResponseClassifierTests.cs
diff --git a/sdk/core/Azure.Core/tests/RetriableStreamTests.cs b/sdk/core/Azure.Core/tests/RetriableStreamTests.cs

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public PetStoreClient(Uri endpoint, TokenCredential credential, PetStoreClientOp`
`59`	`59`	`var authPolicy = new BearerTokenAuthenticationPolicy(_tokenCredential, AuthorizationScopes);`
`60`	`60`
`61`	`61`	`// TODO: When we move the IsError functionality into Core, we'll move the addition of ResponsePropertiesPolicy to the pipeline into HttpPipelineBuilder.`
`62`		`- Pipeline = HttpPipelineBuilder.Build(options, new HttpPipelinePolicy[] { new LowLevelCallbackPolicy() }, new HttpPipelinePolicy[] { authPolicy, new ResponsePropertiesPolicy(options) }, new ResponseClassifier());`
	`62`	`+ Pipeline = HttpPipelineBuilder.Build(options, new HttpPipelinePolicy[] { new LowLevelCallbackPolicy() }, new HttpPipelinePolicy[] { authPolicy, new ResponsePropertiesPolicy(options) }, null);`
`63`	`63`	`this.endpoint = endpoint;`
`64`	`64`	`apiVersion = options.Version;`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -775,8 +775,8 @@ public void Send(Azure.Core.HttpMessage message, System.Threading.CancellationTo`
`775`	`775`	`public static partial class HttpPipelineBuilder`
`776`	`776`	`{`
`777`	`777`	`public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, params Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies) { throw null; }`
`778`		`- public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier) { throw null; }`
`779`		`- public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }`
	`778`	`+ public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier) { throw null; }`
	`779`	`+ public static Azure.Core.Pipeline.HttpPipeline Build(Azure.Core.ClientOptions options, Azure.Core.Pipeline.HttpPipelinePolicy[] perCallPolicies, Azure.Core.Pipeline.HttpPipelinePolicy[] perRetryPolicies, Azure.Core.ResponseClassifier? responseClassifier, Azure.Core.Pipeline.HttpPipelineTransportOptions? defaultTransportOptions) { throw null; }`
`780`	`780`	`}`
`781`	`781`	`public abstract partial class HttpPipelinePolicy`
`782`	`782`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public sealed class DisposableHttpPipeline : HttpPipeline, IDisposable`
`18`	`18`	`/// <param name="perRetryIndex"></param>`
`19`	`19`	`/// <param name="policies">Policies to be invoked as part of the pipeline in order.</param>`
`20`	`20`	`/// <param name="responseClassifier">The response classifier to be used in invocations.</param>`
`21`		`- internal DisposableHttpPipeline(HttpPipelineTransport transport, int perCallIndex, int perRetryIndex, HttpPipelinePolicy[]? policies = null, ResponseClassifier? responseClassifier = null)`
	`21`	`+ internal DisposableHttpPipeline(HttpPipelineTransport transport, int perCallIndex, int perRetryIndex, HttpPipelinePolicy[] policies, ResponseClassifier responseClassifier)`
`22`	`22`	`: base(transport, perCallIndex, perRetryIndex, policies, responseClassifier)`
`23`	`23`	`{`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ namespace Azure.Core`
`11`	`11`	`/// </summary>`
`12`	`12`	`public class ResponseClassifier`
`13`	`13`	`{`
	`14`	`+ internal static ResponseClassifier Shared { get; } = new();`
	`15`	`+`
`14`	`16`	`/// <summary>`
`15`	`17`	`/// Specifies if the request contained in the <paramref name="message"/> should be retried.`
`16`	`18`	`/// </summary>`