[Storage] Fix bug with ignore_read_only in start_copy_from_url() (Azure#23141)

Author: jalauzon-msft

sdk/storage/azure-storage-file-share/CHANGELOG.md

@@ -11,6 +11,9 @@ This version and all future versions will require Python 3.6+. Python 2.7 is no
 - Added support for `rename_directory()` and `rename_file()`.
 - Added support for `Create (c)` SAS permission for Share SAS.
 
+### Bugs Fixed
+- Fixed a bug where `start_copy_from_url()` was not sending the `ignore_read_only` parameter correctly.
+
 ## 12.7.0b2 (2022-02-08)
 
 This version and all future versions will require Python 3.6+. Python 2.7 is no longer supported.

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_generated/_patch.py

@@ -0,0 +1,31 @@
+# coding=utf-8
+# --------------------------------------------------------------------------
+#
+# Copyright (c) Microsoft Corporation. All rights reserved.
+#
+# The MIT License (MIT)
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the ""Software""), to
+# deal in the Software without restriction, including without limitation the
+# rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+# sell copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+# FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+# IN THE SOFTWARE.
+#
+# --------------------------------------------------------------------------
+
+# This file is used for handwritten extensions to the generated code. Example:
+# https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/customize_code/how-to-patch-sdk-code.md
+def patch_sdk():
+    pass

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_generated/aio/operations/_file_operations.py

@@ -1490,7 +1490,7 @@ async def start_copy(
         if _file_permission_copy_mode is not None:
             header_parameters['x-ms-file-permission-copy-mode'] = self._serialize.header("file_permission_copy_mode", _file_permission_copy_mode, 'str')
         if _ignore_read_only is not None:
-            header_parameters['x-ms-file-copy-ignore-read-only'] = self._serialize.header("ignore_read_only", _ignore_read_only, 'bool')
+            header_parameters['x-ms-file-copy-ignore-readonly'] = self._serialize.header("ignore_read_only", _ignore_read_only, 'bool')
         if _file_attributes is not None:
             header_parameters['x-ms-file-attributes'] = self._serialize.header("file_attributes", _file_attributes, 'str')
         if _file_creation_time is not None:

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_generated/operations/_file_operations.py

@@ -1508,7 +1508,7 @@ def start_copy(
         if _file_permission_copy_mode is not None:
             header_parameters['x-ms-file-permission-copy-mode'] = self._serialize.header("file_permission_copy_mode", _file_permission_copy_mode, 'str')
         if _ignore_read_only is not None:
-            header_parameters['x-ms-file-copy-ignore-read-only'] = self._serialize.header("ignore_read_only", _ignore_read_only, 'bool')
+            header_parameters['x-ms-file-copy-ignore-readonly'] = self._serialize.header("ignore_read_only", _ignore_read_only, 'bool')
         if _file_attributes is not None:
             header_parameters['x-ms-file-attributes'] = self._serialize.header("file_attributes", _file_attributes, 'str')
         if _file_creation_time is not None: