[Cosmos] Raise exception if invalid retry configuration specified for connection (Azure#23180)

* Raise exception if invalid retry configuration specified for connection

* changelog and async client connection

* Update CHANGELOG.md

* added basic test case

* Update CHANGELOG.md

Co-authored-by: simorenoh <[email protected]>
Co-authored-by: Simon Moreno <[email protected]>

Author: adamckay

sdk/cosmos/azure-cosmos/CHANGELOG.md

@@ -11,6 +11,7 @@
   This change will impact client application in terms of RUs and latency. Users relying on default `Session` consistency will need to pass it explicitly if their account consistency is different than `Session`.
   Please see [Consistency Levels in Azure Cosmos DB](https://docs.microsoft.com/azure/cosmos-db/consistency-levels) for more details.
 - Fixed invalid request body being sent when passing in `serverScript` body parameter to replace operations for trigger, sproc and udf resources.
+- Fixed TypeErrors not being thrown when passing in invalid connection retry policies to the client.
 
 ### 4.3.0b2 (2022-01-25)
 

sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py

@@ -164,7 +164,8 @@ def __init__(
                 retry_backoff_factor=self.connection_policy.ConnectionRetryConfiguration.backoff_factor
             )
         else:
-            TypeError("Unsupported retry policy. Must be an azure.cosmos.ConnectionRetryPolicy, int, or urllib3.Retry")
+            raise TypeError(
+                "Unsupported retry policy. Must be an azure.cosmos.ConnectionRetryPolicy, int, or urllib3.Retry")
 
         proxies = kwargs.pop('proxies', {})
         if self.connection_policy.ProxyConfiguration and self.connection_policy.ProxyConfiguration.Host:

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client_connection_async.py

@@ -164,7 +164,8 @@ def __init__(
                 retry_backoff_factor=self.connection_policy.ConnectionRetryConfiguration.backoff_factor
             )
         else:
-            TypeError("Unsupported retry policy. Must be an azure.cosmos.ConnectionRetryPolicy, int, or urllib3.Retry")
+            raise TypeError(
+                "Unsupported retry policy. Must be an azure.cosmos.ConnectionRetryPolicy, int, or urllib3.Retry")
 
         proxies = kwargs.pop('proxies', {})
         if self.connection_policy.ProxyConfiguration and self.connection_policy.ProxyConfiguration.Host:

sdk/cosmos/azure-cosmos/test/test_user_configs.py

@@ -36,6 +36,7 @@
 DATABASE_ID = "PythonSDKUserConfigTesters"
 CONTAINER_ID = "PythonSDKTestContainer"
 
+
 def get_test_item():
     item = {
         'id': 'Async_' + str(uuid.uuid4()),
@@ -44,9 +45,17 @@ def get_test_item():
     }
     return item
 
+
 @pytest.mark.usefixtures("teardown")
 class TestUserConfigs(unittest.TestCase):
 
+    def test_invalid_connection_retry_configuration(self):
+        try:
+            cosmos_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey,
+                                       connection_retry_policy="Invalid Policy")
+        except TypeError as e:
+            self.assertTrue(str(e).startswith('Unsupported retry policy'))
+
     def test_enable_endpoint_discovery(self):
         client_false = cosmos_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey,
                                                   enable_endpoint_discovery=False)