Skip to content

Commit 7a46185

Browse files
authored
update to enable test cases (Azure#23750)
1 parent 3159c60 commit 7a46185

4 files changed

+5227
-738
lines changed

sdk/search/azure-search-documents/tests/async_tests/test_search_index_client_skillset_live_async.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,10 @@ async def test_skillset_crud(self, api_key, endpoint):
3434
await self._test_create_skillset(client)
3535
await self._test_get_skillset(client)
3636
await self._test_get_skillsets(client)
37-
# TODO: Disabled due to service regression. See #22769
38-
#await self._test_create_or_update_skillset(client)
37+
await self._test_create_or_update_skillset(client)
3938
await self._test_create_or_update_skillset_if_unchanged(client)
40-
# TODO: Disabled due to service regression. See #22769
41-
#await self._test_create_or_update_skillset_inplace(client)
42-
# TODO: Disabled due to service regression. See #22769
43-
#await self._test_delete_skillset_if_unchanged(client)
39+
await self._test_create_or_update_skillset_inplace(client)
40+
await self._test_delete_skillset_if_unchanged(client)
4441
await self._test_delete_skillset(client)
4542

4643
async def _test_create_skillset(self, client):
@@ -170,12 +167,11 @@ async def _test_create_or_update_skillset_if_unchanged(self, client):
170167

171168
skillset1 = SearchIndexerSkillset(name=name, skills=list([s]), description="desc1")
172169
ss = await client.create_or_update_skillset(skillset1)
173-
etag = ss.e_tag
174-
175-
updated = SearchIndexerSkillset(name=name, skills=[s], description="desc2", skillset=ss)
176-
updated.e_tag = etag
170+
171+
ss.e_tag = 'changed_etag'
172+
177173
with pytest.raises(HttpResponseError):
178-
await client.create_or_update_skillset(updated, match_condition=MatchConditions.IfNotModified)
174+
await client.create_or_update_skillset(ss, match_condition=MatchConditions.IfNotModified)
179175

180176
async def _test_delete_skillset_if_unchanged(self, client):
181177
name = "test-ss-deleted-unchanged"

0 commit comments

Comments
 (0)