Resolve Search Pylint Alias Rule Errors (Azure#23772)

* fix pylint issues

* fix for Enum pylint error

* aliasing fix

* enum fixes

* skip these file for pylint due to issue

* enum changes in py3

* remove pylint skip

* pylint fixes

* remove whitespace

Author: kashifkhan

sdk/search/azure-search-documents/azure/search/documents/_api_versions.py

@@ -4,12 +4,12 @@
 # ------------------------------------
 
 from enum import Enum
+from azure.core import CaseInsensitiveEnumMeta
 
-
-class ApiVersion(str, Enum):
+class ApiVersion(str, Enum, metaclass=CaseInsensitiveEnumMeta):
     #: this is the default version
     V2020_06_30 = "2020-06-30"
-    V2021_04_30_preview = "2021-04-30-Preview"
+    V2021_04_30_PREVIEW = "2021-04-30-Preview"
 
 
-DEFAULT_VERSION = ApiVersion.V2021_04_30_preview
+DEFAULT_VERSION = ApiVersion.V2021_04_30_PREVIEW

sdk/search/azure-search-documents/azure/search/documents/indexes/models/__init__.py

@@ -31,18 +31,18 @@
     SimpleField,
     SearchIndex,
 )
-from . import _edm as SearchFieldDataType
+from . import _edm
 from ..._generated.models import SuggestOptions
 from .._generated.models import (
     SearchAlias,
     AzureMachineLearningSkill,
     AnalyzeResult,
     AnalyzedTokenInfo,
     AsciiFoldingTokenFilter,
-    BM25Similarity as BM25SimilarityAlgorithm,
+    BM25Similarity,
     CharFilter,
     CjkBigramTokenFilter,
-    ClassicSimilarity as ClassicSimilarityAlgorithm,
+    ClassicSimilarity,
     ClassicTokenizer,
     CommonGramTokenFilter,
     ConditionalSkill,
@@ -79,7 +79,7 @@
     KeyPhraseExtractionSkill,
     KeyPhraseExtractionSkillLanguage,
     KeywordMarkerTokenFilter,
-    KeywordTokenizerV2 as KeywordTokenizer,
+    KeywordTokenizerV2,
     LanguageDetectionSkill,
     LengthTokenFilter,
     LexicalAnalyzer,
@@ -102,7 +102,7 @@
     OcrSkill,
     OcrSkillLanguage,
     OutputFieldMappingEntry,
-    PathHierarchyTokenizerV2 as PathHierarchyTokenizer,
+    PathHierarchyTokenizerV2,
     PatternCaptureTokenFilter,
     PatternReplaceCharFilter,
     PatternReplaceTokenFilter,
@@ -137,7 +137,7 @@
     SentimentSkillLanguage,
     ShaperSkill,
     ShingleTokenFilter,
-    Similarity as SimilarityAlgorithm,
+    Similarity,
     SnowballTokenFilter,
     SnowballTokenFilterLanguage,
     SoftDeleteColumnDeletionDetectionPolicy,
@@ -150,7 +150,7 @@
     StopAnalyzer,
     StopwordsList,
     StopwordsTokenFilter,
-    Suggester as SearchSuggester,
+    Suggester,
     SynonymTokenFilter,
     TagScoringFunction,
     TagScoringParameters,
@@ -183,6 +183,28 @@
     SynonymMap,
 )
 
+SearchFieldDataType = _edm
+
+class BM25SimilarityAlgorithm(BM25Similarity):
+    pass
+
+class ClassicSimilarityAlgorithm(ClassicSimilarity):
+    pass
+
+class KeywordTokenizer(KeywordTokenizerV2):
+    pass
+
+class PathHierarchyTokenizer(PathHierarchyTokenizerV2):
+    pass
+
+class SimilarityAlgorithm(Similarity):
+    pass
+
+class SearchSuggester(Suggester):
+    pass
+
+
+
 
 __all__ = (
     "SearchAlias",

sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py

@@ -3,8 +3,10 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+
 from enum import Enum
 import msrest.serialization
+from azure.core import CaseInsensitiveEnumMeta
 from .._generated.models import (
     LexicalAnalyzer,
     LexicalTokenizer,
@@ -102,7 +104,7 @@ def _from_generated(cls, skillset):
         return cls(**kwargs)
 
 
-class EntityRecognitionSkillVersion(str, Enum):
+class EntityRecognitionSkillVersion(str, Enum, metaclass=CaseInsensitiveEnumMeta):
     """Specifies the Entity Recognition skill version to use."""
 
     #: Use Entity Recognition skill V1.
@@ -244,7 +246,7 @@ def _from_generated(cls, skill):
         return None
 
 
-class SentimentSkillVersion(str, Enum):
+class SentimentSkillVersion(str, Enum, metaclass=CaseInsensitiveEnumMeta):
     """ Specifies the Sentiment Skill version to use."""
 
     #: Use Sentiment skill V1.