[Storage] Revert addition of 'create_if_not_exists()' for all Python clients (Azure#23857)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/CHANGELOG.md

@@ -3,7 +3,6 @@
 ## 12.12.0b1 (Unreleased)
 
 ### Features Added
-- Added support for `create_container_if_not_exists()` for `BlobContainerClient`
 
 ## 12.11.0 (2022-03-29)
 

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py

@@ -21,7 +21,7 @@
 import six
 
 from azure.core import MatchConditions
-from azure.core.exceptions import HttpResponseError, ResourceNotFoundError, ResourceExistsError
+from azure.core.exceptions import HttpResponseError, ResourceNotFoundError
 from azure.core.paging import ItemPaged
 from azure.core.tracing.decorator import distributed_trace
 from azure.core.pipeline import Pipeline
@@ -303,34 +303,6 @@ def create_container(self, metadata=None, public_access=None, **kwargs):
         except HttpResponseError as error:
             process_storage_error(error)
 
-    @distributed_trace
-    def create_container_if_not_exists(self, **kwargs):
-        # type: (**Any) -> None
-        """
-        Creates a new container under the specified account. If the container
-        with the same name already exists, it is not changed.
-
-        :keyword Dict[str, str] metadata:
-            A dict with name_value pairs to associate with the
-            container as metadata. Example:{'Category':'test'}
-        :keyword ~azure.storage.blob.PublicAccess public_access:
-            Possible values include: 'container', 'blob'.
-        :keyword container_encryption_scope:
-            Specifies the default encryption scope to set on the container and use for
-            all future writes.
-
-            .. versionadded:: 12.2.0
-
-        :paramtype container_encryption_scope: dict or ~azure.storage.blob.ContainerEncryptionScope
-        :keyword int timeout:
-            The timeout parameter is expressed in seconds.
-        :rtype: None
-        """
-        try:
-            return self.create_container(**kwargs)
-        except ResourceExistsError:
-            return None
-
     @distributed_trace
     def _rename_container(self, new_name, **kwargs):
         # type: (str, **Any) -> ContainerClient

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py

@@ -11,7 +11,7 @@
     TYPE_CHECKING
 )
 
-from azure.core.exceptions import HttpResponseError, ResourceNotFoundError, ResourceExistsError
+from azure.core.exceptions import HttpResponseError, ResourceNotFoundError
 from azure.core.tracing.decorator import distributed_trace
 from azure.core.tracing.decorator_async import distributed_trace_async
 from azure.core.async_paging import AsyncItemPaged
@@ -168,34 +168,6 @@ async def create_container(self, metadata=None, public_access=None, **kwargs):
         except HttpResponseError as error:
             process_storage_error(error)
 
-    @distributed_trace_async
-    async def create_container_if_not_exists(self, **kwargs):
-        # type: (**Any) -> None
-        """
-        Creates a new container under the specified account. If the container
-        with the same name already exists, it is not changed.
-
-        :keyword Dict[str, str] metadata:
-            A dict with name_value pairs to associate with the
-            container as metadata. Example:{'Category':'test'}
-        :keyword ~azure.storage.blob.PublicAccess public_access:
-            Possible values include: 'container', 'blob'.
-        :keyword container_encryption_scope:
-            Specifies the default encryption scope to set on the container and use for
-            all future writes.
-
-            .. versionadded:: 12.2.0
-
-        :paramtype container_encryption_scope: dict or ~azure.storage.blob.ContainerEncryptionScope
-        :keyword int timeout:
-            The timeout parameter is expressed in seconds.
-        :rtype: None
-        """
-        try:
-            return await self.create_container(**kwargs)
-        except ResourceExistsError:
-            return None
-
     @distributed_trace_async
     async def _rename_container(self, new_name, **kwargs):
         # type: (str, **Any) -> ContainerClient

sdk/storage/azure-storage-blob/tests/recordings/test_container.test_create_container_if_not_exists_with_existing_container.yaml

@@ -80,31 +80,6 @@ def test_create_container_with_already_existing_container_fail_on_exist(self, st
         # Assert
         self.assertTrue(created)
 
-    @BlobPreparer()
-    def test_create_container_if_not_exists_without_existing_container(self, storage_account_name, storage_account_key):
-        bsc = BlobServiceClient(self.account_url(storage_account_name, "blob"), storage_account_key)
-        container_name = self._get_container_reference()
-
-        # Act
-        container = bsc.get_container_client(container_name)
-        created = container.create_container_if_not_exists()
-
-        # Assert
-        self.assertTrue(created)
-
-    @BlobPreparer()
-    def test_create_container_if_not_exists_with_existing_container(self, storage_account_name, storage_account_key):
-        bsc = BlobServiceClient(self.account_url(storage_account_name, "blob"), storage_account_key)
-        container_name = self._get_container_reference()
-
-        # Act
-        container = bsc.get_container_client(container_name)
-        container.create_container()
-        created = container.create_container_if_not_exists()
-
-        # Assert
-        self.assertIsNone(created)
-
     @BlobPreparer()
     def test_create_container_with_public_access_container(self, storage_account_name, storage_account_key):
         bsc = BlobServiceClient(self.account_url(storage_account_name, "blob"), storage_account_key)

sdk/storage/azure-storage-blob/tests/recordings/test_container.test_create_container_if_not_exists_without_existing_container.yaml

@@ -98,33 +98,6 @@ async def test_create_container(self, storage_account_name, storage_account_key)
         # Assert
         self.assertTrue(created)
 
-    @BlobPreparer()
-    @AsyncStorageTestCase.await_prepared_test
-    async def test_create_container_if_not_exists_without_existing_container(self, storage_account_name, storage_account_key):
-        bsc = BlobServiceClient(self.account_url(storage_account_name, "blob"), storage_account_key)
-        container_name = self._get_container_reference()
-
-        # Act
-        container = bsc.get_container_client(container_name)
-        created = await container.create_container_if_not_exists()
-
-        # Assert
-        self.assertTrue(created)
-
-    @BlobPreparer()
-    @AsyncStorageTestCase.await_prepared_test
-    async def test_create_container_if_not_exists_with_existing_container(self, storage_account_name, storage_account_key):
-        bsc = BlobServiceClient(self.account_url(storage_account_name, "blob"), storage_account_key)
-        container_name = self._get_container_reference()
-
-        # Act
-        container = bsc.get_container_client(container_name)
-        await container.create_container()
-        created = await container.create_container_if_not_exists()
-
-        # Assert
-        self.assertIsNone(created)
-
     @BlobPreparer()
     @AsyncStorageTestCase.await_prepared_test
     async def test_create_cntnr_w_existing_cntnr_fail_on_exist(self, storage_account_name, storage_account_key):

sdk/storage/azure-storage-blob/tests/recordings/test_container_async.test_create_container_if_not_exists_with_existing_container.yaml

@@ -3,7 +3,6 @@
 ## 12.7.0b1 (Unreleased)
 
 ### Features Added
-- Added support for `create_file_system_if_not_exists()` for `FileSystemClient`
 
 ### Bugs Fixed
 - Updated `create_file_system()` docstring to have the correct return-type of `None`