[Storage] Fix create_if_not_exists() docstrings and tests (Azure#23751)

Author: vincenttran-msft

sdk/storage/azure-storage-blob/CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ### Features Added
 - Added support for service version 2021-06-08.
-- Added support for `create_if_not_exists()` for `BlobContainerClient`
+- Added support for `create_container_if_not_exists()` for `BlobContainerClient`
 
 ## 12.11.0 (2022-03-29)
 

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py

@@ -304,7 +304,7 @@ def create_container(self, metadata=None, public_access=None, **kwargs):
             process_storage_error(error)
 
     @distributed_trace
-    def create_if_not_exists(self, **kwargs):
+    def create_container_if_not_exists(self, **kwargs):
         # type: (**Any) -> None
         """
         Creates a new container under the specified account. If the container

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py

@@ -169,7 +169,7 @@ async def create_container(self, metadata=None, public_access=None, **kwargs):
             process_storage_error(error)
 
     @distributed_trace_async
-    async def create_if_not_exists(self, **kwargs):
+    async def create_container_if_not_exists(self, **kwargs):
         # type: (**Any) -> None
         """
         Creates a new container under the specified account. If the container

sdk/storage/azure-storage-blob/tests/recordings/test_container.test_create_container_if_not_exists_with_existing_container.yaml

@@ -11,11 +11,11 @@ interactions:
       Content-Length:
       - '0'
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 18:56:41 GMT
+      - Wed, 30 Mar 2022 21:22:44 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/container785a1eaa?restype=container
   response:
@@ -25,15 +25,15 @@ interactions:
       content-length:
       - '0'
       date:
-      - Fri, 18 Mar 2022 18:56:40 GMT
+      - Wed, 30 Mar 2022 21:22:44 GMT
       etag:
-      - '"0x8DA0911096F64AA"'
+      - '"0x8DA12936E6CC3E6"'
       last-modified:
-      - Fri, 18 Mar 2022 18:56:40 GMT
+      - Wed, 30 Mar 2022 21:22:44 GMT
       server:
       - Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     status:
       code: 201
       message: Created
@@ -49,30 +49,30 @@ interactions:
       Content-Length:
       - '0'
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 18:56:42 GMT
+      - Wed, 30 Mar 2022 21:22:45 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/container785a1eaa?restype=container
   response:
     body:
       string: "\uFEFF<?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>ContainerAlreadyExists</Code><Message>The
-        specified container already exists.\nRequestId:6c8fa979-201e-008a-05f9-3a8173000000\nTime:2022-03-18T18:56:40.4555247Z</Message></Error>"
+        specified container already exists.\nRequestId:be779b14-901e-006b-497c-445d36000000\nTime:2022-03-30T21:22:44.9260314Z</Message></Error>"
     headers:
       content-length:
       - '230'
       content-type:
       - application/xml
       date:
-      - Fri, 18 Mar 2022 18:56:40 GMT
+      - Wed, 30 Mar 2022 21:22:44 GMT
       server:
       - Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
       x-ms-error-code:
       - ContainerAlreadyExists
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     status:
       code: 409
       message: The specified container already exists.

sdk/storage/azure-storage-blob/tests/recordings/test_container.test_create_container_if_not_exists_without_existing_container.yaml

@@ -11,11 +11,11 @@ interactions:
       Content-Length:
       - '0'
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 18:56:48 GMT
+      - Wed, 30 Mar 2022 21:22:36 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/containerd8c72002?restype=container
   response:
@@ -25,15 +25,15 @@ interactions:
       content-length:
       - '0'
       date:
-      - Fri, 18 Mar 2022 18:56:46 GMT
+      - Wed, 30 Mar 2022 21:22:36 GMT
       etag:
-      - '"0x8DA09110D2893BD"'
+      - '"0x8DA129369B4AC8A"'
       last-modified:
-      - Fri, 18 Mar 2022 18:56:46 GMT
+      - Wed, 30 Mar 2022 21:22:36 GMT
       server:
       - Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     status:
       code: 201
       message: Created

sdk/storage/azure-storage-blob/tests/recordings/test_container_async.test_create_container_if_not_exists_with_existing_container.yaml

@@ -5,23 +5,23 @@ interactions:
       Accept:
       - application/xml
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 19:01:59 GMT
+      - Wed, 30 Mar 2022 21:23:02 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/acontainer399c2127?restype=container
   response:
     body:
       string: ''
     headers:
       content-length: '0'
-      date: Fri, 18 Mar 2022 19:01:56 GMT
-      etag: '"0x8DA0911C6843F7F"'
-      last-modified: Fri, 18 Mar 2022 19:01:57 GMT
+      date: Wed, 30 Mar 2022 21:23:01 GMT
+      etag: '"0x8DA129378BE5DFF"'
+      last-modified: Wed, 30 Mar 2022 21:23:02 GMT
       server: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
-      x-ms-version: '2021-04-10'
+      x-ms-version: '2021-06-08'
     status:
       code: 201
       message: Created
@@ -32,24 +32,24 @@ interactions:
       Accept:
       - application/xml
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 19:01:59 GMT
+      - Wed, 30 Mar 2022 21:23:02 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/acontainer399c2127?restype=container
   response:
     body:
       string: "\uFEFF<?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>ContainerAlreadyExists</Code><Message>The
-        specified container already exists.\nRequestId:6b597129-701e-0001-51fa-3a851e000000\nTime:2022-03-18T19:01:57.6645912Z</Message></Error>"
+        specified container already exists.\nRequestId:397f4f94-a01e-003d-297c-44acd9000000\nTime:2022-03-30T21:23:02.2260400Z</Message></Error>"
     headers:
       content-length: '230'
       content-type: application/xml
-      date: Fri, 18 Mar 2022 19:01:56 GMT
+      date: Wed, 30 Mar 2022 21:23:01 GMT
       server: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
       x-ms-error-code: ContainerAlreadyExists
-      x-ms-version: '2021-04-10'
+      x-ms-version: '2021-06-08'
     status:
       code: 409
       message: The specified container already exists.

sdk/storage/azure-storage-blob/tests/recordings/test_container_async.test_create_container_if_not_exists_without_existing_container.yaml

@@ -5,23 +5,23 @@ interactions:
       Accept:
       - application/xml
       User-Agent:
-      - azsdk-python-storage-blob/12.10.1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
+      - azsdk-python-storage-blob/12.12.0b1 Python/3.10.2 (Windows-10-10.0.19044-SP0)
       x-ms-date:
-      - Fri, 18 Mar 2022 19:01:52 GMT
+      - Wed, 30 Mar 2022 21:22:56 GMT
       x-ms-version:
-      - '2021-04-10'
+      - '2021-06-08'
     method: PUT
     uri: https://storagename.blob.core.windows.net/acontainera180227f?restype=container
   response:
     body:
       string: ''
     headers:
       content-length: '0'
-      date: Fri, 18 Mar 2022 19:01:50 GMT
-      etag: '"0x8DA0911C28A275B"'
-      last-modified: Fri, 18 Mar 2022 19:01:50 GMT
+      date: Wed, 30 Mar 2022 21:22:56 GMT
+      etag: '"0x8DA1293756D6BAD"'
+      last-modified: Wed, 30 Mar 2022 21:22:56 GMT
       server: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
-      x-ms-version: '2021-04-10'
+      x-ms-version: '2021-06-08'
     status:
       code: 201
       message: Created

sdk/storage/azure-storage-blob/tests/test_container.py

@@ -87,7 +87,7 @@ def test_create_container_if_not_exists_without_existing_container(self, storage
 
         # Act
         container = bsc.get_container_client(container_name)
-        created = container.create_if_not_exists()
+        created = container.create_container_if_not_exists()
 
         # Assert
         self.assertTrue(created)
@@ -100,7 +100,7 @@ def test_create_container_if_not_exists_with_existing_container(self, storage_ac
         # Act
         container = bsc.get_container_client(container_name)
         container.create_container()
-        created = container.create_if_not_exists()
+        created = container.create_container_if_not_exists()
 
         # Assert
         self.assertIsNone(created)

sdk/storage/azure-storage-blob/tests/test_container_async.py

@@ -106,7 +106,7 @@ async def test_create_container_if_not_exists_without_existing_container(self, s
 
         # Act
         container = bsc.get_container_client(container_name)
-        created = await container.create_if_not_exists()
+        created = await container.create_container_if_not_exists()
 
         # Assert
         self.assertTrue(created)
@@ -120,7 +120,7 @@ async def test_create_container_if_not_exists_with_existing_container(self, stor
         # Act
         container = bsc.get_container_client(container_name)
         await container.create_container()
-        created = await container.create_if_not_exists()
+        created = await container.create_container_if_not_exists()
 
         # Assert
         self.assertIsNone(created)

sdk/storage/azure-storage-file-datalake/CHANGELOG.md

@@ -3,7 +3,7 @@
 ## 12.7.0b1 (Unreleased)
 
 ### Features Added
-- Added support for `create_if_not_exists()` for `FileSystemClient`
+- Added support for `create_file_system_if_not_exists()` for `FileSystemClient`
 
 ### Bugs Fixed
 - Updated `create_file_system()` docstring to have the correct return-type of `None`