Skip to content
This repository was archived by the owner on Mar 4, 2019. It is now read-only.

Commit 8118a2c

Browse files
unknownunknown
authored andcommitted
Changes suggested by auto-code review
1 parent 1bc2430 commit 8118a2c

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

README.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,10 @@ the select field name and the value array represent its configuration as
6262
follows:
6363

6464
* #title:: (String) The title of the select field. Default is empty string.
65-
* #title_display: (String) The tile display of select field. Default is 'before'.
66-
* #empty_option: (String) The empty option to be shown when no value is selected. Default is '- Select -'.
65+
* #title_display: (String) The tile display of select field.
66+
Default is 'before'.
67+
* #empty_option: (String) The empty option to be shown when no value is
68+
selected. Default is '- Select -'.
6769
* #default_value: (Integer) The value for pre-selection. Default is NULL.
6870

6971
E.g:
@@ -78,4 +80,4 @@ $config = array(
7880
'state' => array(
7981
'#title' => t("State"),
8082
),
81-
);
83+
);

ajax_chain_select.module

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ function ajax_chain_select_element_process($element, &$form_state, $form) {
7979
'data' => array('ajax_chain_select' => array($region_element[$element_name]['#id'] => $settings)),
8080
);
8181

82-
8382
$index = 0;
8483
$levels_count = count($config);
8584
$levels = array_keys($config);
@@ -116,15 +115,15 @@ function ajax_chain_select_element_process($element, &$form_state, $form) {
116115
$region_element[$element_name][$level] = array(
117116
'#type' => 'select',
118117
'#options' => $data,
119-
'#title' => !empty($level_config['#title']) ? t($level_config['#title']) : '',
118+
'#title' => !empty($level_config['#title']) ? $level_config['#title'] : '',
120119
'#empty_option' => !empty($level_config['#empty_option']) ? $level_config['#empty_option'] : t('- Select -'),
121120
'#required' => ($index < $required_levels) ? TRUE : FALSE,
122121
'#validated' => TRUE,
123122
'#default_value' => !empty($level_config['#default_value']) ? $level_config['#default_value'] : NULL,
124123
'#title_display' => !empty($level_config['#title_display']) ? $level_config['#title_display'] : 'before',
125124
'#disabled' => (empty($data)) ? TRUE : FALSE,
126-
'#attributes' => array('level' => $level)
127-
);
125+
'#attributes' => array('level' => $level),
126+
);
128127

129128
if ($index != $levels_count - 1) {
130129
$region_element[$element_name][$level]['#attributes']['class'] = array('ajax-chain-select-select');
@@ -134,7 +133,7 @@ function ajax_chain_select_element_process($element, &$form_state, $form) {
134133
$previous_level = $level;
135134
$previous_level_config = $level_config;
136135
}
137-
136+
138137
$region_element[$element_name]['dc'] = array(
139138
'#type' => 'textfield',
140139
'#value' => base64_encode($element['#data_callback']),

ajax_chain_select_example/ajax_chain_select_example.info

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ name = Ajax Chain Select Example
22
description = "Example module for showing the use of Ajax Chain Select"
33
package = Form Elements
44
core = 7.x
5-
dependencies[] = ajax_chain_select
5+
dependencies[] = ajax_chain_select

0 commit comments

Comments
 (0)