feat: google_datastream_private_connection resource network_attachement support via psc_interface_config (GoogleCloudPlatform#13947)

Author: ramonvermeulen

mmv1/products/datastream/PrivateConnection.yaml

@@ -28,9 +28,9 @@ immutable: true
 import_format:
   - 'projects/{{project}}/locations/{{location}}/privateConnections/{{private_connection_id}}'
 timeouts:
-  insert_minutes: 20
-  update_minutes: 20
-  delete_minutes: 20
+  insert_minutes: 30
+  update_minutes: 30
+  delete_minutes: 30
 async:
   actions: ['create', 'delete', 'update']
   type: 'OpAsync'
@@ -51,6 +51,18 @@ examples:
     vars:
       private_connection_id: 'my-connection'
       network_name: 'my-network'
+  - name: 'datastream_private_connection_psc_interface'
+    primary_resource_id: 'default'
+    test_env_vars:
+      project: 'PROJECT_NAME'
+      project_number: 'PROJECT_NUMBER'
+      org_id: 'ORG_ID'
+      billing_account: 'BILLING_ACCT'
+    vars:
+      private_connection_id: 'my-connection'
+      network_attachment_name: 'my-network-attachment'
+      network_name: 'my-network'
+      subnetwork_name: 'my-subnetwork'
 parameters:
   - name: 'privateConnectionId'
     type: String
@@ -116,7 +128,9 @@ properties:
     description: |
       The VPC Peering configuration is used to create VPC peering
       between Datastream and the consumer's VPC.
-    required: true
+    exactly_one_of:
+      - 'vpc_peering_config'
+      - 'psc_interface_config'
     properties:
       - name: 'vpc'
         type: String
@@ -129,3 +143,23 @@ properties:
         description: |
           A free subnet for peering. (CIDR of /29)
         required: true
+  - name: 'pscInterfaceConfig'
+    type: NestedObject
+    description: |
+      The PSC Interface configuration is used to create PSC Interface
+      between Datastream and the consumer's PSC.
+    exactly_one_of:
+      - 'vpc_peering_config'
+      - 'psc_interface_config'
+    properties:
+      - name: 'networkAttachment'
+        type: String
+        description: |
+          Fully qualified name of the network attachment that Datastream will connect to.
+          Format: projects/{project}/regions/{region}/networkAttachments/{name}
+
+          To get Datastream project for the accepted list:
+          `gcloud datastream private-connections create [PC ID] --location=[LOCATION] --network-attachment=[NA URI] --validate-only --display-name=[ANY STRING]`
+          Add Datastream project to the attachment accepted list:
+          `gcloud compute network-attachments update [NA URI] --region=[NA region] --producer-accept-list=[TP from prev command]`
+        required: true

mmv1/templates/terraform/examples/datastream_private_connection_psc_interface.tf.tmpl

@@ -0,0 +1,37 @@
+resource "google_datastream_private_connection" "{{$.PrimaryResourceId}}" {
+    display_name          = "Connection profile"
+    location              = "us-central1"
+    private_connection_id = "{{index $.Vars "private_connection_id"}}"
+
+    labels = {
+        key = "value"
+    }
+
+    psc_interface_config {
+        network_attachment = google_compute_network_attachment.default.id
+    }
+}
+
+resource "google_compute_network_attachment" "default" {
+    name                  = "{{index $.Vars "network_attachment_name"}}"
+    region                = "us-central1"
+    description           = "basic network attachment description"
+    connection_preference = "ACCEPT_AUTOMATIC"
+
+    subnetworks = [
+        google_compute_subnetwork.default.self_link
+    ]
+}
+
+resource "google_compute_network" "default" {
+    name                    = "{{index $.Vars "network_name"}}"
+    auto_create_subnetworks = false
+}
+
+resource "google_compute_subnetwork" "default" {
+    name   = "{{index $.Vars "subnetwork_name"}}"
+    region = "us-central1"
+
+    network       = google_compute_network.default.id
+    ip_cidr_range = "10.0.0.0/16"
+}