Removed colab schedule post_create logic related to setting name (GoogleCloudPlatform#13965)

Author: melinath

mmv1/templates/terraform/constants/router_nat.go.tmpl

@@ -84,7 +84,7 @@ func computeRouterNatSubnetworkHash(v interface{}) int {
 		}
 	}
 
-	return schema.HashString(tpgresource.NameFromSelfLinkStateFunc(name)) + sourceIpRangesHash + secondaryIpRangeHash
+	return schema.HashString(tpgresource.GetResourceNameFromSelfLink(name.(string))) + sourceIpRangesHash + secondaryIpRangeHash
 }
 
 func computeRouterNatIPsHash(v interface{}) int {

mmv1/templates/terraform/custom_flatten/name_from_self_link.tmpl

@@ -14,5 +14,5 @@ func flatten{{$.GetPrefix}}{{$.TitlelizeProperty}}(v interface{}, d *schema.Reso
     if v == nil {
         return v
     }
-	return tpgresource.NameFromSelfLinkStateFunc(v)
+	return tpgresource.GetResourceNameFromSelfLink(v.(string))
 }

mmv1/templates/terraform/post_create/colab_schedule.go.tmpl

@@ -1,19 +1,3 @@
-// The response for create request contains the generated name generated name that we need
-// in order to perform a READ. We need to access the object inside of it as
-// a map[string]interface, so let's do that.
-
-longName := res["name"].(string)
-name := tpgresource.GetResourceNameFromSelfLink(longName)
-log.Printf("[DEBUG] Setting resource name to %s", name)
-if err := d.Set("name", name); err != nil {
-	return fmt.Errorf("Error setting name: %s", err)
-}
-
-parts := strings.Split(longName, "/")
-parts[1] = project
-updatedLongName := strings.Join(parts, "/")
-d.SetId(updatedLongName)
-
 if p, ok := d.GetOk("desired_state"); ok && p.(string) == "PAUSED" {
   _, err := modifyScheduleState(config, d, project, billingProject, userAgent, "pause")
   if err != nil {

mmv1/third_party/cai2hcl/services/compute/compute_forwarding_rule.go

@@ -307,5 +307,5 @@ func flattenComputeForwardingRuleRegion(v interface{}, d *schema.ResourceData, c
 	if v == nil {
 		return v
 	}
-	return tpgresource.NameFromSelfLinkStateFunc(v)
+	return tpgresource.GetResourceNameFromSelfLink(v.(string))
 }

mmv1/third_party/cai2hcl/services/compute/compute_region_backend_service.go

@@ -1394,5 +1394,5 @@ func flattenComputeRegionBackendServiceRegion(v interface{}, d *schema.ResourceD
 	if v == nil {
 		return v
 	}
-	return tpgresource.NameFromSelfLinkStateFunc(v)
+	return tpgresource.GetResourceNameFromSelfLink(v.(string))
 }

mmv1/third_party/cai2hcl/services/compute/compute_region_health_check.go

@@ -564,5 +564,5 @@ func flattenComputeRegionHealthCheckRegion(v interface{}, d *schema.ResourceData
 	if v == nil {
 		return v
 	}
-	return tpgresource.NameFromSelfLinkStateFunc(v)
+	return tpgresource.GetResourceNameFromSelfLink(v.(string))
 }

mmv1/third_party/terraform/services/osconfig/resource_os_config_os_policy_assignment.go

@@ -1485,7 +1485,7 @@ func flattenOSConfigOSPolicyAssignmentName(v interface{}, d *schema.ResourceData
 	if v == nil {
 		return v
 	}
-	return tpgresource.NameFromSelfLinkStateFunc(v)
+	return tpgresource.GetResourceNameFromSelfLink(v.(string))
 }
 
 func flattenOSConfigOSPolicyAssignmentDescription(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {

mmv1/third_party/terraform/tpgresource/self_link_helpers.go

@@ -102,14 +102,6 @@ func GetResourceNameFromSelfLink(link string) string {
 	return parts[len(parts)-1]
 }
 
-func NameFromSelfLinkStateFunc(v interface{}) string {
-	return GetResourceNameFromSelfLink(v.(string))
-}
-
-func StoreResourceName(resourceLink interface{}) string {
-	return GetResourceNameFromSelfLink(resourceLink.(string))
-}
-
 type LocationType int
 
 const (