mcp/server: advertise completions only if installed (modelcontextprotocol#213)

Previously, completions would always be advertised as a capability even
if the CompletionHandler was not installed by the server. This CL fixes
that.

Author: samthanawalla

mcp/server.go

@@ -239,9 +239,7 @@ func (s *Server) capabilities() *serverCapabilities {
 	defer s.mu.Unlock()
 
 	caps := &serverCapabilities{
-		// TODO(samthanawalla): check for completionHandler before advertising capability.
-		Completions: &completionCapabilities{},
-		Logging:     &loggingCapabilities{},
+		Logging: &loggingCapabilities{},
 	}
 	if s.opts.HasTools || s.tools.len() > 0 {
 		caps.Tools = &toolCapabilities{ListChanged: true}
@@ -255,6 +253,9 @@ func (s *Server) capabilities() *serverCapabilities {
 			caps.Resources.Subscribe = true
 		}
 	}
+	if s.opts.CompletionHandler != nil {
+		caps.Completions = &completionCapabilities{}
+	}
 	return caps
 }
 

mcp/server_test.go

@@ -242,8 +242,7 @@ func TestServerCapabilities(t *testing.T) {
 			name:            "No capabilities",
 			configureServer: func(s *Server) {},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
+				Logging: &loggingCapabilities{},
 			},
 		},
 		{
@@ -252,9 +251,8 @@ func TestServerCapabilities(t *testing.T) {
 				s.AddPrompt(&Prompt{Name: "p"}, nil)
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
-				Prompts:     &promptCapabilities{ListChanged: true},
+				Logging: &loggingCapabilities{},
+				Prompts: &promptCapabilities{ListChanged: true},
 			},
 		},
 		{
@@ -263,9 +261,8 @@ func TestServerCapabilities(t *testing.T) {
 				s.AddResource(&Resource{URI: "file:///r"}, nil)
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
-				Resources:   &resourceCapabilities{ListChanged: true},
+				Logging:   &loggingCapabilities{},
+				Resources: &resourceCapabilities{ListChanged: true},
 			},
 		},
 		{
@@ -274,9 +271,8 @@ func TestServerCapabilities(t *testing.T) {
 				s.AddResourceTemplate(&ResourceTemplate{URITemplate: "file:///rt"}, nil)
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
-				Resources:   &resourceCapabilities{ListChanged: true},
+				Logging:   &loggingCapabilities{},
+				Resources: &resourceCapabilities{ListChanged: true},
 			},
 		},
 		{
@@ -293,9 +289,8 @@ func TestServerCapabilities(t *testing.T) {
 				},
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
-				Resources:   &resourceCapabilities{ListChanged: true, Subscribe: true},
+				Logging:   &loggingCapabilities{},
+				Resources: &resourceCapabilities{ListChanged: true, Subscribe: true},
 			},
 		},
 		{
@@ -304,9 +299,21 @@ func TestServerCapabilities(t *testing.T) {
 				s.AddTool(tool, nil)
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
+				Logging: &loggingCapabilities{},
+				Tools:   &toolCapabilities{ListChanged: true},
+			},
+		},
+		{
+			name:            "With completions",
+			configureServer: func(s *Server) {},
+			serverOpts: ServerOptions{
+				CompletionHandler: func(ctx context.Context, ss *ServerSession, params *CompleteParams) (*CompleteResult, error) {
+					return nil, nil
+				},
+			},
+			wantCapabilities: &serverCapabilities{
 				Logging:     &loggingCapabilities{},
-				Tools:       &toolCapabilities{ListChanged: true},
+				Completions: &completionCapabilities{},
 			},
 		},
 		{
@@ -324,6 +331,9 @@ func TestServerCapabilities(t *testing.T) {
 				UnsubscribeHandler: func(ctx context.Context, up *UnsubscribeParams) error {
 					return nil
 				},
+				CompletionHandler: func(ctx context.Context, ss *ServerSession, params *CompleteParams) (*CompleteResult, error) {
+					return nil, nil
+				},
 			},
 			wantCapabilities: &serverCapabilities{
 				Completions: &completionCapabilities{},
@@ -342,11 +352,10 @@ func TestServerCapabilities(t *testing.T) {
 				HasTools:     true,
 			},
 			wantCapabilities: &serverCapabilities{
-				Completions: &completionCapabilities{},
-				Logging:     &loggingCapabilities{},
-				Prompts:     &promptCapabilities{ListChanged: true},
-				Resources:   &resourceCapabilities{ListChanged: true},
-				Tools:       &toolCapabilities{ListChanged: true},
+				Logging:   &loggingCapabilities{},
+				Prompts:   &promptCapabilities{ListChanged: true},
+				Resources: &resourceCapabilities{ListChanged: true},
+				Tools:     &toolCapabilities{ListChanged: true},
 			},
 		},
 	}

mcp/streamable_test.go

@@ -314,9 +314,8 @@ func TestStreamableServerTransport(t *testing.T) {
 	initReq := req(1, methodInitialize, &InitializeParams{})
 	initResp := resp(1, &InitializeResult{
 		Capabilities: &serverCapabilities{
-			Completions: &completionCapabilities{},
-			Logging:     &loggingCapabilities{},
-			Tools:       &toolCapabilities{ListChanged: true},
+			Logging: &loggingCapabilities{},
+			Tools:   &toolCapabilities{ListChanged: true},
 		},
 		ProtocolVersion: latestProtocolVersion,
 		ServerInfo:      &Implementation{Name: "testServer", Version: "v1.0.0"},
@@ -732,9 +731,8 @@ func TestStreamableClientTransportApplicationJSON(t *testing.T) {
 	}
 	initResult := &InitializeResult{
 		Capabilities: &serverCapabilities{
-			Completions: &completionCapabilities{},
-			Logging:     &loggingCapabilities{},
-			Tools:       &toolCapabilities{ListChanged: true},
+			Logging: &loggingCapabilities{},
+			Tools:   &toolCapabilities{ListChanged: true},
 		},
 		ProtocolVersion: latestProtocolVersion,
 		ServerInfo:      &Implementation{Name: "testServer", Version: "v1.0.0"},

mcp/testdata/conformance/server/bad_requests.txtar

@@ -58,7 +58,6 @@ code_review
 	"id": 2,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {},
 			"prompts": {
 				"listChanged": true

mcp/testdata/conformance/server/prompts.txtar

@@ -27,7 +27,6 @@ code_review
 	"id": 1,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {},
 			"prompts": {
 				"listChanged": true

mcp/testdata/conformance/server/resources.txtar

@@ -50,7 +50,6 @@ info.txt
 	"id": 1,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {},
 			"resources": {
 				"listChanged": true

mcp/testdata/conformance/server/tools.txtar

@@ -30,7 +30,6 @@ greet
 	"id": 1,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {},
 			"tools": {
 				"listChanged": true

mcp/testdata/conformance/server/version-latest.txtar

@@ -18,7 +18,6 @@ response with its latest supported version.
 	"id": 1,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {}
 		},
 		"protocolVersion": "2025-06-18",

mcp/testdata/conformance/server/version-older.txtar

@@ -18,7 +18,6 @@ support.
 	"id": 1,
 	"result": {
 		"capabilities": {
-			"completions": {},
 			"logging": {}
 		},
 		"protocolVersion": "2024-11-05",