Merge pull request #1136 from BCDA-APS/UnboundLocalError--cannot-access-local-variable-'dt_cycle_ends'

MNT Only use when available

Author: prjemian

CHANGES.rst

@@ -24,7 +24,12 @@ describe future plans.
    1.7.10
    ******
 
-   Release expected by 2026-01.
+   Release expected by 2025-12-05.
+
+   Fixes
+   -------------
+
+   * BUG 'dt_cycle_ends' in apstools.devices.aps_cycle.ApsCycleDM
 
 1.7.9
 *****

apstools/devices/aps_cycle.py

@@ -161,18 +161,20 @@ def get(self):
             if now.month < 5:
                 cycle = f"{now.year}-1"
                 dt_cycle_ends = f"{now.year}-05-01 00:00:00-05:00"
-            if now.month < 9:
+            elif now.month < 9:
                 cycle = f"{now.year}-2"
                 dt_cycle_ends = f"{now.year}-10-01 00:00:00-05:00"
             else:
                 cycle = f"{now.year}-3"
                 dt_cycle_ends = f"{now.year+1}-01-01 00:00:00-06:00"
+            self._cycle_ends = dt_cycle_ends
+
         else:  # official table from APS (via DM)
             if now.isoformat(sep=" ") >= self._cycle_ends:
                 ts_cycle_end = cycle_db.db[cycle]["end"]
                 dt_cycle_ends = datetime.datetime.fromtimestamp(ts_cycle_end).isoformat(sep=" ")
+                self._cycle_ends = dt_cycle_ends
 
-        self._cycle_ends = dt_cycle_ends
         self._cycle_name = cycle
         return self._cycle_name