Skip to content

Commit 735ce2a

Browse files
committed
refactor: organize benches to be consistent
1 parent c9fa975 commit 735ce2a

File tree

17 files changed

+67
-62
lines changed

17 files changed

+67
-62
lines changed

benches/Cargo.toml

Lines changed: 13 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ edition = "2021"
44
description = "Benchmarks that test Bevy's performance"
55
publish = false
66
license = "MIT OR Apache-2.0"
7+
# Do not automatically discover benchmarks, we specify them manually instead.
8+
autobenches = false
79

810
[dev-dependencies]
911
glam = "0.29"
@@ -30,62 +32,32 @@ bevy_winit = { path = "../crates/bevy_winit", features = ["x11"] }
3032
opt-level = 3
3133
lto = true
3234

33-
[[bench]]
34-
name = "change_detection"
35-
path = "benches/bevy_ecs/change_detection.rs"
36-
harness = false
37-
3835
[[bench]]
3936
name = "ecs"
40-
path = "benches/bevy_ecs/benches.rs"
41-
harness = false
42-
43-
[[bench]]
44-
name = "ray_mesh_intersection"
45-
path = "benches/bevy_picking/ray_mesh_intersection.rs"
46-
harness = false
47-
48-
[[bench]]
49-
name = "reflect_function"
50-
path = "benches/bevy_reflect/function.rs"
51-
harness = false
52-
53-
[[bench]]
54-
name = "reflect_list"
55-
path = "benches/bevy_reflect/list.rs"
56-
harness = false
57-
58-
[[bench]]
59-
name = "reflect_map"
60-
path = "benches/bevy_reflect/map.rs"
61-
harness = false
62-
63-
[[bench]]
64-
name = "reflect_struct"
65-
path = "benches/bevy_reflect/struct.rs"
37+
path = "benches/bevy_ecs/main.rs"
6638
harness = false
6739

6840
[[bench]]
69-
name = "parse_reflect_path"
70-
path = "benches/bevy_reflect/path.rs"
41+
name = "math"
42+
path = "benches/bevy_math/main.rs"
7143
harness = false
7244

7345
[[bench]]
74-
name = "iter"
75-
path = "benches/bevy_tasks/iter.rs"
46+
name = "picking"
47+
path = "benches/bevy_picking/main.rs"
7648
harness = false
7749

7850
[[bench]]
79-
name = "bezier"
80-
path = "benches/bevy_math/bezier.rs"
51+
name = "reflect"
52+
path = "benches/bevy_reflect/main.rs"
8153
harness = false
8254

8355
[[bench]]
84-
name = "torus"
85-
path = "benches/bevy_render/torus.rs"
56+
name = "render"
57+
path = "benches/bevy_render/main.rs"
8658
harness = false
8759

8860
[[bench]]
89-
name = "entity_hash"
90-
path = "benches/bevy_ecs/world/entity_hash.rs"
61+
name = "tasks"
62+
path = "benches/bevy_tasks/main.rs"
9163
harness = false
File renamed without changes.

benches/benches/bevy_math/bezier.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use criterion::{black_box, criterion_group, criterion_main, Criterion};
1+
use criterion::{black_box, criterion_group, Criterion};
22

33
use bevy_math::prelude::*;
44

@@ -92,4 +92,3 @@ criterion_group!(
9292
build_pos_cubic,
9393
build_accel_cubic,
9494
);
95-
criterion_main!(benches);

benches/benches/bevy_math/main.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
use criterion::criterion_main;
2+
3+
mod bezier;
4+
5+
criterion_main!(
6+
bezier::benches,
7+
);
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
use criterion::criterion_main;
2+
3+
mod ray_mesh_intersection;
4+
5+
criterion_main!(
6+
ray_mesh_intersection::benches,
7+
);

benches/benches/bevy_picking/ray_mesh_intersection.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use bevy_math::{Dir3, Mat4, Ray3d, Vec3};
22
use bevy_picking::mesh_picking::ray_cast;
3-
use criterion::{black_box, criterion_group, criterion_main, Criterion};
3+
use criterion::{black_box, criterion_group, Criterion};
44

55
fn ptoxznorm(p: u32, size: u32) -> (f32, f32) {
66
let ij = (p / (size), p % (size));
@@ -117,4 +117,3 @@ criterion_group!(
117117
ray_mesh_intersection_no_cull,
118118
ray_mesh_intersection_no_intersection
119119
);
120-
criterion_main!(benches);

benches/benches/bevy_reflect/function.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
use bevy_reflect::func::{ArgList, IntoFunction, IntoFunctionMut, TypedFunction};
2-
use criterion::{criterion_group, criterion_main, BatchSize, Criterion};
2+
use criterion::{criterion_group, BatchSize, Criterion};
33

44
criterion_group!(benches, typed, into, call, clone);
5-
criterion_main!(benches);
65

76
fn add(a: i32, b: i32) -> i32 {
87
a + b

benches/benches/bevy_reflect/list.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use core::{iter, time::Duration};
22

33
use bevy_reflect::{DynamicList, List};
44
use criterion::{
5-
black_box, criterion_group, criterion_main, measurement::Measurement, BatchSize,
5+
black_box, criterion_group, measurement::Measurement, BatchSize,
66
BenchmarkGroup, BenchmarkId, Criterion, Throughput,
77
};
88

@@ -13,7 +13,6 @@ criterion_group!(
1313
dynamic_list_apply,
1414
dynamic_list_push
1515
);
16-
criterion_main!(benches);
1716

1817
const WARM_UP_TIME: Duration = Duration::from_millis(500);
1918
const MEASUREMENT_TIME: Duration = Duration::from_secs(4);
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
use criterion::criterion_main;
2+
3+
mod function;
4+
mod list;
5+
mod map;
6+
mod path;
7+
mod r#struct;
8+
9+
criterion_main!(
10+
function::benches,
11+
list::benches,
12+
map::benches,
13+
path::benches,
14+
r#struct::benches,
15+
);

benches/benches/bevy_reflect/map.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use core::{fmt::Write, iter, time::Duration};
33
use bevy_reflect::{DynamicMap, Map};
44
use bevy_utils::HashMap;
55
use criterion::{
6-
black_box, criterion_group, criterion_main, measurement::Measurement, BatchSize,
6+
black_box, criterion_group, measurement::Measurement, BatchSize,
77
BenchmarkGroup, BenchmarkId, Criterion, Throughput,
88
};
99

@@ -14,7 +14,6 @@ criterion_group!(
1414
dynamic_map_get,
1515
dynamic_map_insert
1616
);
17-
criterion_main!(benches);
1817

1918
const WARM_UP_TIME: Duration = Duration::from_millis(500);
2019
const MEASUREMENT_TIME: Duration = Duration::from_secs(4);

0 commit comments

Comments
 (0)