Skip to content

Commit 05a26c6

Browse files
committed
Tag Management: UX Improvements #2198
1 parent 865a14c commit 05a26c6

File tree

10 files changed

+25
-20
lines changed

10 files changed

+25
-20
lines changed

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/TagInfoEdit.svelte

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,15 @@
105105
if (responce.status === 200) {
106106
notificationStore.showNotification({
107107
notificationType: notificationType.success,
108-
message: 'Tag is generated.'
108+
message: 'Release Tag is generated.'
109109
});
110110
111111
reload();
112112
dispatch('reload');
113113
} else {
114114
notificationStore.showNotification({
115115
notificationType: notificationType.error,
116-
message: 'Tag is not generated.'
116+
message: 'Release Tag is not generated.'
117117
});
118118
}
119119
}
@@ -179,7 +179,7 @@
179179
disableSorting: true
180180
},
181181
systemDescription: {
182-
header: 'System Description',
182+
header: 'General Type',
183183
disableFiltering: true,
184184
disableSorting: true,
185185
instructions: {
@@ -219,6 +219,10 @@
219219
},
220220
disableFiltering: true,
221221
disableSorting: true
222+
},
223+
link: {
224+
disableFiltering: true,
225+
exclude: true
222226
}
223227
}
224228
}}

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/TagInfoView.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@
3030
<TablePlaceholder cols={2} {rows} />
3131
</div>
3232
{:then model}
33-
<h2 class="h2">Tag Preview</h2>
33+
<h2 class="h2">Preview</h2>
3434
<table class="table table-compact bg-tertiary-200">
3535
<thead>
3636
<tr class="bg-primary-300">
37-
<th class="!p-2 w-16">Tag</th>
38-
<th class="!p-2">Release Note</th>
37+
<th scope="col" class="!p-2 w-16">Release Tag</th>
38+
<th scope="col" class="!p-2">Release Note</th>
3939
</tr>
4040
</thead>
4141
<tbody>

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableOptions.svelte

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
let noTag: boolean = hasNoTag();
1111
// use auto-subscription so changes to the store re-run reactive statements
1212
let withMinor: boolean;
13-
1413
$: withMinor = $withMinorStore;
1514
1615
function hasNoTag() {
@@ -43,12 +42,12 @@
4342
$: hasChanges = (() => {
4443
const originalRows = $originalTagInfoModelStore;
4544
const currentRow = $tagInfoModelStore.find((x) => x.versionId == row.versionId);
46-
console.log('🚀 ~ hasChanges ~ currentRow:', currentRow);
47-
if (!currentRow) return false;
48-
4945
const originalRow = originalRows.find((x) => x.versionId == row.versionId);
46+
47+
if (!currentRow) return false; // No current row
5048
if (!originalRow) return true; // New row
5149
50+
// Return true if there are changes, otherwise false
5251
return (
5352
currentRow.releaseNote !== originalRow.releaseNote ||
5453
currentRow.publish !== originalRow.publish ||
@@ -58,7 +57,8 @@
5857
</script>
5958

6059
<div class="flex gap-2 w-min p-2">
61-
{#if hasChanges}
60+
{row.tagId}
61+
{#if hasChanges && row.tagId > 0}
6262
<button
6363
class="btn btn-sm variant-filled-primary"
6464
title="Save changes"
@@ -72,13 +72,13 @@
7272
{#if withMinor}
7373
<button
7474
class="btn btn-sm variant-filled-primary"
75-
title="Create new minor version"
75+
title="Create new minor version. All untagged versions until this will belong to this minor version."
7676
on:click|preventDefault={() => eventDispatchFn('MINOR')}>minor</button
7777
>
7878
{/if}
7979
<button
8080
class="btn btn-sm variant-filled-primary"
81-
title="Create new major version"
81+
title="Create new major version. All untagged versions until this will belong to this major version."
8282
on:click|preventDefault={() => eventDispatchFn('MAJOR')}>major</button
8383
>
8484
{/if}

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tablePublish.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
1010
$: currentRow = $tagInfoModelStore.find((x) => x.versionId == row.original.versionId);
1111
12+
// Update the store when the toggle is changed
1213
function togglePublish(versionId: number, value: boolean) {
1314
tagInfoModelStore.update((arr) =>
1415
arr.map((x) => (x.versionId === versionId ? { ...x, publish: !!value } : x))
@@ -17,7 +18,7 @@
1718
</script>
1819

1920
<div class="flex h-full items-center justify-center">
20-
<div title="Make this release tag visible; Click save to apply">
21+
<div title="Make this release tag visible; Click save to apply changes.">
2122
{#if currentRow.tagId > 0}
2223
<SlideToggle
2324
name={currentRow.versionId}

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableReleaseNote.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
}
2121
</script>
2222

23-
<span title="Release Note; Click save to apply">
23+
<span title="Release Note; Click save to apply changes.">
2424
<TextArea
2525
bind:value={currentRow.releaseNote}
2626
on:input={() =>

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableShow.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
show: false
1717
} as TagInfoEditModel);
1818
19+
// Update the store when the toggle is changed
1920
function toggleShow(versionId: number, value: boolean) {
2021
tagInfoModelStore.update((arr) =>
2122
arr.map((x) => (x.versionId === versionId ? { ...x, show: !!value } : x))
@@ -24,7 +25,7 @@
2425
</script>
2526

2627
<div class="flex h-full items-center justify-center">
27-
<div title="Show the release note of this version; Click save to apply">
28+
<div title="Show the release note of this version; Click save to apply changes.">
2829
{#if currentRow && currentRow.tagId > 0}
2930
<SlideToggle
3031
name={'' + currentRow.versionId}

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableText.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<script lang="ts">
22
import { TextInput } from '@bexis2/bexis2-core-ui';
3-
import type { TagInfoModel } from '../types';
43
54
export let value: string;
65
export let row: any;

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableTextAuthor.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</script>
44

55
<div>
6-
<span title="Person who made the change">
6+
<span title="Person created this version">
77
{value}
88
</span>
99
</div>

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI.Svelte/src/routes/taginfo/table/tableTextType.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
</script>
44

55
<div>
6-
<span title="Type of change made in this version">
6+
<span title="General type of change of this version (e.g. Metadata, Data, etc.)">
77
{value}
88
</span>
99
</div>

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI/Views/TagInfo/Index.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
@{
3-
ViewBag.Title = "tags";
3+
ViewBag.Title = "Release Tags";
44
Layout = "~/Themes/Default/Layouts/_svelteLayout.cshtml";
55

66
long id = 0;

0 commit comments

Comments
 (0)