Skip to content

Commit 5df9ef5

Browse files
committed
#2245 fixing issues by loading metadata and title
1 parent 9ac9a28 commit 5df9ef5

File tree

4 files changed

+35
-5
lines changed

4 files changed

+35
-5
lines changed

Components/DLM/BExIS.Dlm.Services/Data/DatasetManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,7 @@ public List<DatasetVersion> GetDatasetLatestVersions(List<Int64> datasetIds, boo
15101510
/// </summary>
15111511
/// <param name="datasetId">The identifiers of the dataset whose their latest versions is requested</param>
15121512
/// <returns>The list of the latest versions of the deleted datasets</returns>
1513-
private DatasetVersion getDeletedDatasetLatestVersion(long datasetId)
1513+
public DatasetVersion GetDeletedDatasetLatestVersion(long datasetId)
15141514
{
15151515
using (IUnitOfWork uow = this.GetUnitOfWork())
15161516
{

Console/BExIS.Web.Shell/Areas/DCM/BExIS.Modules.Dcm.UI/Controllers/FormController.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,15 @@ public ActionResult LoadMetadataByVersion(long entityId, int version=-1, bool lo
177177

178178
DatasetVersion dsv = null;
179179

180-
if (version == -1)
180+
if (version == -1) // latest
181181
{
182182
dsv = datasetManager.GetDatasetLatestVersion(entityId);
183183
}
184+
else if (version == 0 || dataset.Status == DatasetStatus.Deleted) // check may deleted
185+
{
186+
if(dataset.Status == DatasetStatus.Deleted)
187+
dsv = datasetManager.GetDeletedDatasetLatestVersion(entityId);
188+
}
184189
else
185190
{
186191
dsv = datasetManager.GetDatasetVersion(entityId, version);

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI/Controllers/DataController.cs

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,22 @@ public ActionResult ShowData(long id, int version = 0, bool asPartial = false, s
347347
ViewData["State"] = "hidden";
348348
ViewData["HasEditRight"] = model.HasEditRight;
349349

350+
var deletedVersion = dm.GetDeletedDatasetLatestVersion(id);
351+
latestVersion = true;
352+
latestVersionId = deletedVersion.Id;
353+
versionId = deletedVersion.Id;
354+
version = dm.GetDatasetVersionNr(versionId);
355+
latestVersionNr = dm.GetDatasetVersionNr(latestVersionId);
356+
357+
if (deletedVersion != null && deletedVersion.StateInfo != null)
358+
{
359+
isValid = DatasetStateInfo.Valid.ToString().Equals(deletedVersion.StateInfo.State) ? "yes" : "no";
360+
ViewData["IsValid"] = isValid;
361+
}
362+
363+
title = deletedVersion != null ? deletedVersion.Title : "n.a.";
364+
labels = getLabels(id, versionId, tag, deletedVersion.Dataset.EntityTemplate.Name);
365+
350366
model.GrantAccess = false;
351367
model.ViewAccess = false;
352368
model.DownloadAccess = false;
@@ -426,14 +442,23 @@ public ActionResult ShowData(long id, int version = 0, bool asPartial = false, s
426442
}
427443

428444
[ChildActionOnly]
429-
public async Task<ActionResult> GetCitationOrTitle(long datasetVersionId)
445+
public async Task<ActionResult> GetCitationOrTitle(long Id, long datasetVersionId)
430446
{
431447
try
432448
{
433449
using (var datasetManager = new DatasetManager())
434450
using (var conceptManager = new ConceptManager())
435451
{
436-
var datasetVersion = datasetManager.GetDatasetVersion(datasetVersionId);
452+
var dataset = datasetManager.GetDataset(Id);
453+
DatasetVersion datasetVersion = null;
454+
if (dataset.Status == DatasetStatus.Deleted)
455+
{
456+
datasetVersion = datasetManager.GetDeletedDatasetLatestVersion(Id);
457+
}
458+
else
459+
{
460+
datasetVersion = datasetManager.GetDatasetVersion(datasetVersionId);
461+
}
437462

438463
if (datasetVersion == null)
439464
{

Console/BExIS.Web.Shell/Areas/DDM/BExIS.Modules.Ddm.UI/Views/Data/ShowData.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@
243243

244244
<div class="datasetview_header">
245245
<div class="datasetview_header-title">
246-
@{Html.RenderAction("GetCitationOrTitle", "Data", new { datasetVersionId = Model.VersionId });}
246+
@{Html.RenderAction("GetCitationOrTitle", "Data", new { Id = Model.Id, datasetVersionId = Model.VersionId });}
247247
</div>
248248

249249
<div class="datasetview_header-toggle flex">

0 commit comments

Comments
 (0)