Merge branch 'table' of https://github.com/BEXIS2/bexis2-core-ui into table

zxyctn · zxyctn · commit e6e6b2b902fb · 2024-12-03T15:56:52.000+01:00
diff --git a/README.md b/README.md
@@ -1,5 +1,23 @@
 # bexis-core-ui
 
+## 0.4.21
+- change footer position in page component
+
+## 0.4.20
+- Add aria-label to Table and other components
+- Facets
+  - Add aria-label to Facets component
+  - sort by count if exists, reorder more view, truncate long names,
+- Search
+  - Add aria-label to Search component
+- Table: add column
+## 0.4.19
+
+## 0.4.18
+- Updates indicator text for current page and possible number of pages in a Table
+- Fixes client-side search on Table
+- Adds "No rows available" text in Table if search or filter returns no rows.
+
 ## 0.4.16
 - Facets
   - Replaces groups array with a writable store to re-render component on data manipulation.
@@ -11,9 +29,9 @@
   - Adds on:change action
 
 ## 0.4.14
-- Table 
+- Table
   - fixes rendering issues with Table filters and different components
-  
+
 - Facets
   - Exports Facets component
 
@@ -37,7 +55,7 @@
   - Updates the structure of server-side configuration for Tables.
   - Adds new page size dropdown in Table for to fix contrast issues in the component.
   - Adds showing/hiding Table columns.
-  
+
 - Facets:
   - Adds Facets component.
 
@@ -65,7 +83,7 @@
 - update libs
   - remove eslint-plugin-svelte3
   - update svelte, sveltekit, typescript, tailwind ...
-  
+
 ## 0.4.3
 - table
   - Enable searching on server-side
@@ -96,7 +114,7 @@
 
 ## 0.3.11
 - add on:change passthrough to TextInput, TextArea, DateInput, NumberInput, CheckBox
-  
+
 ## 0.3.10
 - multi select
   - update svelte-select libary
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bexis2/bexis2-core-ui",
-  "version": "0.4.16",
+  "version": "0.4.21",
   "private": false,
   "scripts": {
     "dev": "vite dev",
diff --git a/src/docs/Navigation.svelte b/src/docs/Navigation.svelte
@@ -60,13 +60,13 @@
 			><div class="flex justify-center py-2">
 				<LightSwitch />
 			</div>
-			<AppRailTile label="General" title="Tile" value={'general'} on:click={onListItemClick}
+			<AppRailTile label="General" title="General" value={'general'} on:click={onListItemClick}
 				><i class="fa-solid fa-screwdriver-wrench text-2xl" /></AppRailTile
 			>
-			<AppRailTile label="Theme" title="Tile" value={'theme'} on:click={onListItemClick}
+			<AppRailTile label="Theme" title="Theme" value={'theme'} on:click={onListItemClick}
 				><i class="fa-solid fa-code-compare text-2xl" /></AppRailTile
 			>
-			<AppRailTile label="Components" title="Tile" value={'components'} on:click={onListItemClick}
+			<AppRailTile label="Components" title="Components" value={'components'} on:click={onListItemClick}
 				><i class="fa-solid fa-list-check text-2xl" /></AppRailTile
 			>
 		</svelte:fragment>
@@ -85,8 +85,8 @@
 				<nav class="list-nav">
 					<ul>
 						{#each list as { href, label, badge }}
-							<li on:click={onListItemClick} on:keypress>
-								<a {href} class={classesActive(href)} data-sveltekit-preload-data="hover">
+							<li>
+								<a {href} class={classesActive(href)} data-sveltekit-preload-data="hover" on:click={onListItemClick} on:keypress>
 									<span class="flex-auto">{@html label}</span>
 									{#if badge}<span class="badge variant-filled-secondary">{badge}</span>{/if}
 								</a>
diff --git a/src/lib/components/CodeEditor/CodeEditor.svelte b/src/lib/components/CodeEditor/CodeEditor.svelte
@@ -100,6 +100,7 @@
 		<div class="flex gap-2">
 			<button
 				class="btn variant-filled-warning"
+				title="Reset"
 				id="{id}-reset"
 				on:click|preventDefault={() => modalStore.trigger(modal)}
 				><Fa icon={faArrowRotateLeft} /></button
@@ -108,6 +109,7 @@
 					class="btn border"
 					class:bg-slate-700={dark}
 					class:bg-white={!dark}
+					title="Toggle dark mode"
 					id="{id}-toggle"
 					on:click|preventDefault={() => (dark = !dark)}
 				>
@@ -124,11 +126,13 @@
 			<div class="flex gap-2">
 				<button
 					class="btn variant-filled-warning"
+					title="Cancel"
 					id="{id}-cancel"
 					on:click|preventDefault={() => dispatch('cancel')}><Fa icon={faXmark} /></button
 				>
 				<button
 					class="btn variant-filled-primary"
+					title="Save"
 					id="{id}-save"
 					disabled={!isValid}
 					on:click|preventDefault={() => dispatch('save')}><Fa icon={faSave} /></button
diff --git a/src/lib/components/File/FileUploader.svelte b/src/lib/components/File/FileUploader.svelte
@@ -193,7 +193,7 @@
 			{/if}
 		</div>
 
-		<button id={submitBt} color="primary" style="display:none"><Fa icon={faSave} /></button>
+		<button title="Submit" id={submitBt} color="primary" style="display:none"><Fa icon={faSave} /></button>
 	{:else}
 		<!-- while data is not loaded show a loading information -->
 
diff --git a/src/lib/components/Table/ColumnsMenu.svelte b/src/lib/components/Table/ColumnsMenu.svelte
@@ -53,6 +53,7 @@
 	</div>
 	{#each columns as column}
 		<div class="flex gap-3 items-center">
+			<label for={column.id} class="cursor-pointer" title={column.label}></label>
 			<input
 				aria-label={`${column.visible ? 'Hide' : 'Show'} ${column.label} column`}
 				type="checkbox"
diff --git a/src/lib/components/Table/TableContent.svelte b/src/lib/components/Table/TableContent.svelte
@@ -524,12 +524,14 @@
 						<input
 							class="input p-2 border border-primary-500"
 							type="text"
+							title="Search within all table rows"
 							bind:value={searchValue}
 							placeholder="Search rows..."
 							aria-label="Searchbox for searching rows"
 							id="{tableId}-search"
 						/><button
 							type="reset"
+							title="Clear search"
 							id="{tableId}-searchReset"
 							class="absolute right-3 items-center"
 							aria-label="Clear search"
@@ -547,6 +549,7 @@
 					</div>
 					<button
 						type="submit"
+						title="Search"
 						id="{tableId}-searchSubmit"
 						class="btn variant-filled-primary"
 						aria-label="Search"
@@ -574,6 +577,7 @@
 					{#if toggle}
 						<SlideToggle
 							name="slider-label"
+							label="Fit to screen"
 							active="bg-primary-500"
 							size="sm"
 							checked={fitToScreen}
@@ -619,6 +623,7 @@
 					{...$tableAttrs}
 					class="table table-auto table-compact bg-tertiary-500/30 dark:bg-tertiary-900/10 overflow-clip"
 					id="{tableId}-table"
+					title="Table"
 				>
 					<!-- If table height is provided, making the top row sticky -->
 					<thead class={height != null && $pageRows.length > 0 ? `sticky top-0` : ''}>
@@ -655,6 +660,8 @@
 														<div class="flex gap-1 whitespace-pre-wrap">
 															<!-- Adding sorting config and styling -->
 															<span
+																role="button"
+																tabindex="0"
 																class:underline={props.sort.order}
 																class:normal-case={cell.id !== cell.label}
 																class:cursor-pointer={!props.sort.disabled}
diff --git a/src/lib/components/Table/TableFilter.svelte b/src/lib/components/Table/TableFilter.svelte
@@ -284,6 +284,8 @@
 							</select>
 							{#if dropdowns.length > 1}
 								<div
+									role="button"
+									tabindex="0"
 									class="btn variant-filled-warning btn-sm h-full"
 									aria-label="Remove filter"
 									on:click|preventDefault={() => removeFilter(dropdown.option)}
@@ -321,6 +323,8 @@
 			{#if remainingFilters.length}
 				<div
 					class="btn variant-filled-secondary btn-sm cursor-pointer"
+					role="button"
+					tabindex="0"
 					on:click|stopPropagation={() => {
 						addFilter(remainingFilters[0].value, undefined);
 					}}
diff --git a/src/lib/components/Table/TableFilterServer.svelte b/src/lib/components/Table/TableFilterServer.svelte
@@ -275,6 +275,8 @@
 							</select>
 							{#if dropdowns.length > 1}
 								<div
+									role="button"
+									tabindex="0"
 									class="btn variant-filled-warning btn-sm h-full"
 									on:click|preventDefault={() => removeFilter(dropdown.option)}
 									on:keydown|preventDefault={() => removeFilter(dropdown.option)}
@@ -320,6 +322,8 @@
 				<div
 					class="btn variant-filled-secondary btn-sm cursor-pointer"
 					aria-label="Add filter"
+					role="button"
+					tabindex="0"
 					on:click|stopPropagation={() => {
 						addFilter(remainingFilters[0].value, undefined);
 					}}
diff --git a/src/lib/components/Table/TablePaginationServer.svelte b/src/lib/components/Table/TablePaginationServer.svelte
@@ -85,6 +85,7 @@
 	<div class="flex justify-center gap-1">
 		<button
 			class="btn btn-sm variant-filled-primary"
+			title="Go to first page"
 			on:click|preventDefault={() => goTo('first')}
 			disabled={goToFirstPageDisabled}
 			aria-label="Go to first page"
@@ -94,6 +95,7 @@
 		>
 		<button
 			class="btn btn-sm variant-filled-primary"
+			title="Go to previous page"
 			id="{id}-previous"
 			aria-label="Go to previous page"
 			on:click|preventDefault={() => goTo('previous')}
diff --git a/src/lib/components/form/CheckboxKvPList.svelte b/src/lib/components/form/CheckboxKvPList.svelte
@@ -15,13 +15,14 @@
 
 <InputContainer {id} label={title} {feedback} {required} {help}>
 	{#each source as item}
-		<label class="flex items-center space-x-2" for={key}>
+		<label class="flex items-center space-x-2" for={item.key}>
 			<input
 				class="checkbox"
 				type="checkbox"
 				bind:group={target}
 				checked={item.key}
 				value={item.key}
+				id={item.key}
 			/>
 			<p>{item.value}</p>
 		</label>
diff --git a/src/lib/components/form/CheckboxList.svelte b/src/lib/components/form/CheckboxList.svelte
@@ -13,8 +13,8 @@
 
 <InputContainer label={title} {feedback} {required}>
 	{#each source as item}
-		<label class="flex items-center space-x-2" for={key}>
-			<input class="checkbox" type="checkbox" bind:group={target} value={item} />
+		<label class="flex items-center space-x-2" for={item}>
+			<input class="checkbox" type="checkbox" bind:group={target} value={item} id={item}/>
 			<p>{item}</p>
 		</label>
 	{/each}
diff --git a/src/lib/components/page/Alert.svelte b/src/lib/components/page/Alert.svelte
@@ -32,7 +32,7 @@
 			<slot name="actions" />
 
 			{#if deleteBtn}
-				<button class="btn hover:text-primary-100" on:click={() => (show = false)}>
+				<button class="btn hover:text-primary-100" title="Close alert" on:click={() => (show = false)}>
 					<Fa icon={faXmark} />
 				</button>
 			{/if}
diff --git a/src/lib/components/page/BackToTop.svelte b/src/lib/components/page/BackToTop.svelte
@@ -26,5 +26,5 @@
 <svelte:window on:scroll={handleOnScroll} />
 
 <div class="w-full items-center">
-	<button class="btn ring back-to-top" on:click={goTop} class:hidden>Back to top</button>
+	<button class="btn ring back-to-top" title="Back to top" on:click={goTop} class:hidden>Back to top</button>
 </div>
diff --git a/src/lib/components/page/GoToTop.svelte b/src/lib/components/page/GoToTop.svelte
@@ -17,6 +17,7 @@
 {#if showGotoTop}
  <button
  id="gotToTop"
+ title="Go to top"
  class="chip variant-filled-warning fixed bottom-5 right-20 shadow-md"
  on:click={gotoTop}
  ><Fa icon={faAngleUp}/></button >
diff --git a/src/lib/components/page/HelpPopUp.svelte b/src/lib/components/page/HelpPopUp.svelte
@@ -45,6 +45,7 @@
 {#if active}
 	<button
 		id="helpButton"
+		title="Open help window"
 		class="chip variant-filled-warning fixed bottom-5 right-10 shadow-md"
 		use:popup={helpClick}><Fa icon={faQuestion} /></button
 	>
diff --git a/src/lib/components/page/Page.svelte b/src/lib/components/page/Page.svelte
@@ -79,10 +79,6 @@ import type { helpItemType, helpStoreType } from '$models/Models';
 		</AppBar>
 	</svelte:fragment>
 
-	<svelte:fragment slot="footer">
-		<Footer />
-	</svelte:fragment>
-
 	<slot name="description" />
 
 	<div class="flex flex-initial space-x-5">
@@ -118,6 +114,11 @@ import type { helpItemType, helpStoreType } from '$models/Models';
 	<GoToTop/>
 	<HelpPopUp active={help} />
 	<Notification />
+	
+	<svelte:fragment slot="footer">
+		<Footer />
+	</svelte:fragment>
+
 </AppShell>
 </div>
 
diff --git a/src/routes/components/form/examples/RadioGroupExample.svelte b/src/routes/components/form/examples/RadioGroupExample.svelte
@@ -7,8 +7,8 @@
 <!-- svelte-ignore a11y-label-has-associated-control -->
 <label class="text-sm">best of</label>
 <RadioGroup>
-	<RadioItem bind:group={value} name="justify" value={0}>(music)</RadioItem>
-	<RadioItem bind:group={value} name="justify" value={1}>(movies)</RadioItem>
-	<RadioItem bind:group={value} name="justify" value={2}>(series)</RadioItem>
+	<RadioItem bind:group={value} name="justify" title="music" label="music" value={0}>(music)</RadioItem>
+	<RadioItem bind:group={value} name="justify" title="movies" label="movies" value={1}>(movies)</RadioItem>
+	<RadioItem bind:group={value} name="justify" title="series" label="series" value={2}>(series)</RadioItem>
 </RadioGroup>
 <div class="pt-3"><b>Value:</b> {value}</div>
diff --git a/src/routes/components/table/components/IsAdmin.svelte b/src/routes/components/table/components/IsAdmin.svelte
@@ -3,4 +3,4 @@
 	export let row;
 </script>
 
-<input type="checkbox" name="isAdmin" id={row.id} checked={value} disabled />
+<input type="checkbox" name="isAdmin" title={value} id={row.id} checked={value} disabled />
diff --git a/src/routes/components/table/components/TableCRUDOptions.svelte b/src/routes/components/table/components/TableCRUDOptions.svelte
@@ -36,6 +36,7 @@
 <div class="flex gap-2 w-min">
 	{#each buttons as button}
 		<button
+			title="{button.type}"
 			class={`btn btn-sm btn-icon rounded-md ${button.color}`}
 			on:click|preventDefault={() => eventDispatchFn(button.type)}
 		>

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@bexis2/bexis2-core-ui",`
`3`		`- "version": "0.4.16",`
	`3`	`+ "version": "0.4.21",`
`4`	`4`	`"private": false,`
`5`	`5`	`"scripts": {`
`6`	`6`	`"dev": "vite dev",`