fix: close ModList.txt file handle before renaming it

Author: paulhobbel

internal/workspace/modlist.go

@@ -102,22 +102,28 @@ func (m *ModList) Save() error {
 	log.WithField("file", "ModList.txt").Debugf("saving ModList.txt")
 
 	tmpFilePath := filepath.Join(m.dir, "ModList.txt.new")
-	file, err := os.Create(tmpFilePath)
-	if err != nil {
-		return err
-	}
-	defer file.Close()
 
-	writer := bufio.NewWriter(file)
+	// anonymous func to make sure file is always closed no matter what before we rename it
+	err := func() error {
+		file, err := os.Create(tmpFilePath)
+		if err != nil {
+			return err
+		}
+		defer file.Close()
+
+		writer := bufio.NewWriter(file)
 
-	for _, line := range m.lines {
-		if _, err = writer.WriteString(fmt.Sprintf("%s\n", line)); err != nil {
+		for _, line := range m.lines {
+			if _, err = writer.WriteString(fmt.Sprintf("%s\n", line)); err != nil {
+				return err
+			}
+		}
+		if err = writer.Flush(); err != nil {
 			return err
 		}
-	}
-	if err = writer.Flush(); err != nil {
-		return err
-	}
+
+		return nil
+	}()
 
 	if err = os.Rename(tmpFilePath, filepath.Join(m.dir, "ModList.txt")); err != nil {
 		return err