Use readline to separate JSON response objects

- JSON responses are newline-delimited by c-lighting and can't contain
  newlines, so this achieves the same in a simpler and more efficient manner.

- The previous method would break with something like { "key": "}" }

- The previous method would break if a single JSON response is split across
  multiple `data` events (possible with large responses).

Author: shesek

index.js

@@ -2,9 +2,9 @@
 
 const path = require('path');
 const net = require('net');
+const readline = require('readline');
+const {EventEmitter} = require('events');
 const _ = require('lodash');
-const { EventEmitter } = require('events');
-
 
 class LightningClient extends EventEmitter {
     constructor(rpcPath) {
@@ -44,48 +44,16 @@ class LightningClient extends EventEmitter {
             });
         });
 
-        this.client.on('data', data => {
-            _.each(LightningClient.splitJSON(data.toString()), str => {
-                let dataObject = {};
-                try {
-                    dataObject = JSON.parse(str);
-                } catch (err) {
-                    return;
-                }
-
-                _self.emit('res:'+dataObject.id, dataObject)
-            });
-        });
-    }
-
-    static splitJSON(str) {
-        const parts = [];
-
-        let openCount = 0;
-        let lastSplit = 0;
-
-        for (let i = 0; i < str.length; i++) {
-            if (i > 0 && str.charCodeAt(i - 1) === 115) { // 115 => backslash, ignore this character
-                continue;
+        readline.createInterface({input: this.client}).on('line', str => {
+            let data;
+            try {
+                data = JSON.parse(str);
+            } catch (err) {
+                return _self.emit('error', 'Invalid JSON: ' + str);
             }
 
-            if (str[i] === '{') {
-                openCount++;
-            } else if (str[i] === '}') {
-                openCount--;
-
-                if (openCount === 0) {
-                    const start = lastSplit;
-                    const end = i + 1 === str.length ? undefined : i + 1;
-
-                    parts.push(str.slice(start, end));
-
-                    lastSplit = end;
-                }
-            }
-        }
-
-        return parts.length === 0 ? [str] : parts;
+            _self.emit('res:' + data.id, data);
+        });
     }
 
     increaseWaitTime() {
@@ -129,7 +97,7 @@ class LightningClient extends EventEmitter {
         return this.clientConnectionPromise
             .then(() => new Promise((resolve, reject) => {
                 // Wait for a response
-                this.once('res:'+callInt, response => {
+                this.once('res:' + callInt, response => {
                     if (_.isNil(response.error)) {
                         resolve(response.result);
                         return;