fix: resolve all remaining linting and build issues

- Fixed deprecated actions/upload-artifact@v3 to v4 in GitHub Actions
- Fixed all remaining errcheck issues in cmd files
- Added proper error handling for flag retrievals
- Fixed regexp.MatchString error handling in config validation
- Fixed config manager Load method error handling
- Fixed variable redeclaration in cmd/init.go
- All tests passing and errcheck clean

Author: apple

.github/workflows/build.yml

@@ -130,7 +130,7 @@ jobs:
         done
     
     - name: Upload build artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: tf-safe-${{ matrix.goos }}-${{ matrix.goarch }}
         path: dist/

cmd/apply.go

@@ -67,7 +67,7 @@ func runApplyCommand(args []string) error {
 	wrapper.AddHook(backupHook)
 
 	// Add logging hook if verbose mode is enabled
-	if verbose, _ := rootCmd.PersistentFlags().GetBool("verbose"); verbose {
+	if verbose, err := rootCmd.PersistentFlags().GetBool("verbose"); err == nil && verbose {
 		loggingHook := terraform.NewLoggingHook(true)
 		wrapper.AddHook(loggingHook)
 	}

cmd/backup.go

@@ -40,10 +40,22 @@ func init() {
 
 func runBackupCommand(cmd *cobra.Command, args []string) error {
 	// Get flags
-	description, _ := cmd.Flags().GetString("description")
-	force, _ := cmd.Flags().GetBool("force")
-	verbose, _ := cmd.Flags().GetBool("verbose")
-	dryRun, _ := cmd.Flags().GetBool("dry-run")
+	description, err := cmd.Flags().GetString("description")
+	if err != nil {
+		return fmt.Errorf("failed to get description flag: %w", err)
+	}
+	force, err := cmd.Flags().GetBool("force")
+	if err != nil {
+		return fmt.Errorf("failed to get force flag: %w", err)
+	}
+	verbose, err := cmd.Flags().GetBool("verbose")
+	if err != nil {
+		return fmt.Errorf("failed to get verbose flag: %w", err)
+	}
+	dryRun, err := cmd.Flags().GetBool("dry-run")
+	if err != nil {
+		return fmt.Errorf("failed to get dry-run flag: %w", err)
+	}
 
 	// Initialize logger
 	logLevel := utils.LogLevelInfo

cmd/destroy.go

@@ -66,7 +66,7 @@ func runDestroyCommand(args []string) error {
 	wrapper.AddHook(backupHook)
 
 	// Add logging hook if verbose mode is enabled
-	if verbose, _ := rootCmd.PersistentFlags().GetBool("verbose"); verbose {
+	if verbose, err := rootCmd.PersistentFlags().GetBool("verbose"); err == nil && verbose {
 		loggingHook := terraform.NewLoggingHook(true)
 		wrapper.AddHook(loggingHook)
 	}

cmd/init.go

@@ -40,18 +40,29 @@ func init() {
 }
 
 func runInit(cmd *cobra.Command, args []string) error {
-	interactive, _ := cmd.Flags().GetBool("interactive")
-	force, _ := cmd.Flags().GetBool("force")
-	template, _ := cmd.Flags().GetString("template")
-	output, _ := cmd.Flags().GetString("output")
+	interactive, err := cmd.Flags().GetBool("interactive")
+	if err != nil {
+		return fmt.Errorf("failed to get interactive flag: %w", err)
+	}
+	force, err := cmd.Flags().GetBool("force")
+	if err != nil {
+		return fmt.Errorf("failed to get force flag: %w", err)
+	}
+	template, err := cmd.Flags().GetString("template")
+	if err != nil {
+		return fmt.Errorf("failed to get template flag: %w", err)
+	}
+	output, err := cmd.Flags().GetString("output")
+	if err != nil {
+		return fmt.Errorf("failed to get output flag: %w", err)
+	}
 
 	// Check if config file already exists
-	if _, err := os.Stat(output); err == nil && !force {
+	if _, statErr := os.Stat(output); statErr == nil && !force {
 		return fmt.Errorf("configuration file %s already exists. Use --force to overwrite", output)
 	}
 
 	var cfg *types.Config
-	var err error
 
 	if interactive {
 		cfg, err = createInteractiveConfig()
@@ -182,7 +193,10 @@ func createInteractiveConfig() (*types.Config, error) {
 
 func promptString(reader *bufio.Reader, prompt, defaultValue string) string {
 	fmt.Printf("%s [%s]: ", prompt, defaultValue)
-	input, _ := reader.ReadString('\n')
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return defaultValue
+	}
 	input = strings.TrimSpace(input)
 	if input == "" {
 		return defaultValue
@@ -197,7 +211,10 @@ func promptBool(reader *bufio.Reader, prompt string, defaultValue bool) bool {
 	}
 
 	fmt.Printf("%s (y/n) [%s]: ", prompt, defaultStr)
-	input, _ := reader.ReadString('\n')
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return defaultValue
+	}
 	input = strings.TrimSpace(strings.ToLower(input))
 
 	if input == "" {
@@ -209,7 +226,10 @@ func promptBool(reader *bufio.Reader, prompt string, defaultValue bool) bool {
 
 func promptInt(reader *bufio.Reader, prompt string, defaultValue int) int {
 	fmt.Printf("%s [%d]: ", prompt, defaultValue)
-	input, _ := reader.ReadString('\n')
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return defaultValue
+	}
 	input = strings.TrimSpace(input)
 
 	if input == "" {
@@ -225,7 +245,10 @@ func promptInt(reader *bufio.Reader, prompt string, defaultValue int) int {
 
 func promptChoice(reader *bufio.Reader, prompt string, choices []string, defaultValue string) string {
 	fmt.Printf("%s (%s) [%s]: ", prompt, strings.Join(choices, "/"), defaultValue)
-	input, _ := reader.ReadString('\n')
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return defaultValue
+	}
 	input = strings.TrimSpace(input)
 
 	if input == "" {
@@ -244,7 +267,10 @@ func promptChoice(reader *bufio.Reader, prompt string, choices []string, default
 
 func promptPassword(reader *bufio.Reader, prompt string) string {
 	fmt.Printf("%s: ", prompt)
-	input, _ := reader.ReadString('\n')
+	input, err := reader.ReadString('\n')
+	if err != nil {
+		return ""
+	}
 	return strings.TrimSpace(input)
 }
 

cmd/list.go

@@ -43,10 +43,22 @@ func init() {
 
 func runListCommand(cmd *cobra.Command, args []string) error {
 	// Get flags
-	format, _ := cmd.Flags().GetString("format")
-	storageFilter, _ := cmd.Flags().GetString("storage")
-	limit, _ := cmd.Flags().GetInt("limit")
-	verbose, _ := cmd.Flags().GetBool("verbose")
+	format, err := cmd.Flags().GetString("format")
+	if err != nil {
+		return fmt.Errorf("failed to get format flag: %w", err)
+	}
+	storageFilter, err := cmd.Flags().GetString("storage")
+	if err != nil {
+		return fmt.Errorf("failed to get storage flag: %w", err)
+	}
+	limit, err := cmd.Flags().GetInt("limit")
+	if err != nil {
+		return fmt.Errorf("failed to get limit flag: %w", err)
+	}
+	verbose, err := cmd.Flags().GetBool("verbose")
+	if err != nil {
+		return fmt.Errorf("failed to get verbose flag: %w", err)
+	}
 
 	// Validate format
 	validFormats := []string{"table", "json", "yaml"}

cmd/plan.go

@@ -66,7 +66,7 @@ func runPlanCommand(args []string) error {
 	wrapper.AddHook(backupHook)
 
 	// Add logging hook if verbose mode is enabled
-	if verbose, _ := rootCmd.PersistentFlags().GetBool("verbose"); verbose {
+	if verbose, err := rootCmd.PersistentFlags().GetBool("verbose"); err == nil && verbose {
 		loggingHook := terraform.NewLoggingHook(true)
 		wrapper.AddHook(loggingHook)
 	}

cmd/restore.go

@@ -48,11 +48,26 @@ func runRestoreCommand(cmd *cobra.Command, args []string) error {
 	backupID := args[0]
 
 	// Get flags
-	targetPath, _ := cmd.Flags().GetString("target")
-	force, _ := cmd.Flags().GetBool("force")
-	noBackup, _ := cmd.Flags().GetBool("no-backup")
-	verbose, _ := cmd.Flags().GetBool("verbose")
-	dryRun, _ := cmd.Flags().GetBool("dry-run")
+	targetPath, err := cmd.Flags().GetString("target")
+	if err != nil {
+		return fmt.Errorf("failed to get target flag: %w", err)
+	}
+	force, err := cmd.Flags().GetBool("force")
+	if err != nil {
+		return fmt.Errorf("failed to get force flag: %w", err)
+	}
+	noBackup, err := cmd.Flags().GetBool("no-backup")
+	if err != nil {
+		return fmt.Errorf("failed to get no-backup flag: %w", err)
+	}
+	verbose, err := cmd.Flags().GetBool("verbose")
+	if err != nil {
+		return fmt.Errorf("failed to get verbose flag: %w", err)
+	}
+	dryRun, err := cmd.Flags().GetBool("dry-run")
+	if err != nil {
+		return fmt.Errorf("failed to get dry-run flag: %w", err)
+	}
 
 	// Initialize logger
 	logLevel := utils.LogLevelInfo

internal/config/manager.go

@@ -63,19 +63,31 @@ func (m *Manager) Validate(config *types.Config) error {
 
 // GetStorageConfig returns the local storage configuration
 func (m *Manager) GetStorageConfig() types.LocalConfig {
-	config, _ := m.Load()
+	config, err := m.Load()
+	if err != nil {
+		// Return default config on error
+		return types.LocalConfig{}
+	}
 	return config.Local
 }
 
 // GetRemoteConfig returns the remote storage configuration
 func (m *Manager) GetRemoteConfig() types.RemoteConfig {
-	config, _ := m.Load()
+	config, err := m.Load()
+	if err != nil {
+		// Return default config on error
+		return types.RemoteConfig{}
+	}
 	return config.Remote
 }
 
 // GetEncryptionConfig returns the encryption configuration
 func (m *Manager) GetEncryptionConfig() types.EncryptionConfig {
-	config, _ := m.Load()
+	config, err := m.Load()
+	if err != nil {
+		// Return default config on error
+		return types.EncryptionConfig{}
+	}
 	return config.Encryption
 }
 

internal/config/validation.go

@@ -261,14 +261,14 @@ func isValidS3BucketName(name string) bool {
 	}
 
 	// Must start and end with lowercase letter or number
-	matched, _ := regexp.MatchString(`^[a-z0-9].*[a-z0-9]$`, name)
-	if !matched {
+	matched, err := regexp.MatchString(`^[a-z0-9].*[a-z0-9]$`, name)
+	if err != nil || !matched {
 		return false
 	}
 
 	// Can contain lowercase letters, numbers, hyphens, and periods
-	matched, _ = regexp.MatchString(`^[a-z0-9.-]+$`, name)
-	if !matched {
+	matched, err = regexp.MatchString(`^[a-z0-9.-]+$`, name)
+	if err != nil || !matched {
 		return false
 	}
 
@@ -285,7 +285,10 @@ func isValidGCSBucketName(name string) bool {
 	if len(name) < 3 || len(name) > 63 {
 		return false
 	}
-	matched, _ := regexp.MatchString(`^[a-z0-9][a-z0-9._-]*[a-z0-9]$`, name)
+	matched, err := regexp.MatchString(`^[a-z0-9][a-z0-9._-]*[a-z0-9]$`, name)
+	if err != nil {
+		return false
+	}
 	return matched
 }