Make a responsive-height-craft-visual component

[weotch]

The point would be for 100vw x 100vh images where srcset alone isn't going to cut it. Take the case of a square viewport and a 16:9 image. It's going to get scaled up to fit the viewport. The solve would be something like this, where we create a bunch of source elements. It would pretty much requires an image CDN to work.

This would probably consume responsive-craft-visual. I don't have a clear line of site on the API for this.

[weotch]

@jonjahr came up with another solution for this kind of issue here: https://bkwld.slack.com/archives/C07D9R4FK/p1641496583019300

Maybe this could be a simple functional component that produces those vmax style sizes rules...

[jonjahr]

Yea, I like this. But why a functional component? Like, why not just a prop we add to contentful-visual/craft-visual... then they use a shared function to compute sizes, then generate their own srcsets.

[weotch]

I'm open to that too. It'd depend on many lines of code were required to implement this. I like the idea of the core visual components only being concerned with rendering a assets and higher order components adding additional features.