Don’t include related images in exported csvs

The length of the eager load query they create creates issues for sql server

Author: weotch

classes/Controllers/Traits/Exportable.php

@@ -21,7 +21,7 @@ trait Exportable
      */
     public function csv()
     {
-        $items = $this->makeIndexQuery()->exporting()->get();
+        $items = $this->makeCsvQuery()->get();
         if ($items->isEmpty()) abort(404);
         $csv = $this->makeCsv($items);
         return response($csv->getContent())->withHeaders([
@@ -33,6 +33,19 @@ public function csv()
         ]);
     }
 
+    /**
+     * Make the CSV query, removing eager loading of images because that can
+     * create a passing query that breaks some databases (like sql server)
+     *
+     * @return \Illuminate\Database\Eloquent\Builder
+     */
+    protected function makeCsvQuery()
+    {
+        return $this->makeIndexQuery()
+            ->withoutGlobalScopes(['decoy.images'])
+            ->exporting();
+    }
+
     /**
      * Build the CSV object from a collection of models
      * https://csv.thephpleague.com/9.0/writer/