Skip to content

Commit a3d3c96

Browse files
committed
fix: remove empty overlay entries in datapack
- fixes a bug that created an empty overlay field in pack.mcmeta even if there were no overlays generated
1 parent 4491156 commit a3d3c96

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

beet_observer/data_pack.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def gen_dp_overlays(ctx: Context, ctx_overlay: Context, overlay_dir: str) -> Non
6565
for overlay in ctx.data.overlays:
6666
# check if it's the top-level overlay
6767
if overlay == ctx.meta["observer"]["default_dir_dp"]:
68-
# delete pack.mcmeta from overlay (requuired for tests)
68+
# delete pack.mcmeta from overlay (required for tests)
6969
default_dir = ctx.meta["observer"]["default_dir_dp"]
7070
if ctx.data.overlays[default_dir].mcmeta:
7171
del ctx.data.overlays[default_dir].mcmeta
@@ -91,7 +91,8 @@ def gen_dp_overlays(ctx: Context, ctx_overlay: Context, overlay_dir: str) -> Non
9191
)
9292

9393
# save overlay entries in pack.mcmeta
94-
ctx.data.mcmeta.data.update({"overlays": {"entries": entries}})
94+
if len(entries) > 0:
95+
ctx.data.mcmeta.data.update({"overlays": {"entries": entries}})
9596

9697

9798
def check_registry(

0 commit comments

Comments
 (0)