Make sure the clone is in the binary directory - if cmake is run from somewhere else and specifying the build directory via options, we need to be explicit about this. Not doing so resulted in a bext configure attempt finding the top level CMakeLists.txt file from brlcad again and re-running that configure. Noticed it in CI testing when we were losing a setting, but consequences were probably wilder than just that...

Author: starseeker

misc/CMake/BRLCAD_EXT_Setup.cmake

@@ -38,12 +38,15 @@ function(brlcad_ext_setup)
   set(BRLCAD_EXT_BUILD_DIR ${CMAKE_CURRENT_BINARY_DIR}/bext_build)
   set(BRLCAD_EXT_INSTALL_DIR ${CMAKE_CURRENT_BINARY_DIR})
 
-  # If we don't have
+  # If we don't have the bext source directory, try to clone it
   if (NOT DEFINED BRLCAD_EXT_SOURCE_DIR)
     set(BRLCAD_EXT_SOURCE_DIR ${CMAKE_CURRENT_BINARY_DIR}/bext)
     if (NOT EXISTS ${BRLCAD_EXT_SOURCE_DIR})
       find_program(GIT_EXEC git REQUIRED)
-      execute_process(COMMAND ${GIT_EXEC} clone https://github.com/BRL-CAD/bext.git)
+      execute_process(
+	COMMAND ${GIT_EXEC} clone https://github.com/BRL-CAD/bext.git
+	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
+      )
     endif (NOT EXISTS ${BRLCAD_EXT_SOURCE_DIR})
   endif (NOT DEFINED BRLCAD_EXT_SOURCE_DIR)
   if (NOT EXISTS ${BRLCAD_EXT_SOURCE_DIR})