Remove build dev from non-tooling UMD packages and copy their minified files into the expected .js or max.js file (#16770)

Following the same rational as [this
PR](#16760), modifying the
remaining packages in UMD directory. Had to change the logic slightly in
the webpack plugin because of how some packages were overriding
filename.

I do still believe we will need further changes to fix memory pressure
as I am still hitting high memory usage when building locally.

---------

Co-authored-by: Georgina <[email protected]>

Author: georginahalpern

packages/dev/buildTools/src/webpackTools.ts

@@ -224,24 +224,27 @@ export const commonDevWebpackConfiguration = (
  * Originally our build commands for our tools were running both dev and prod, outputted an unminified max.js file during CI. This impacted memory usage during
  * build and is not necessary for debugging since we offer source maps. We have since removed the dev step from our builds, but in order to preserve
  * backwards compatibility for users who may have been referencing the .max.js file directly, we now copy the minified file to a .max.js file
- * after the build is complete. This plugin will only run if the `copyMinToMax` option is set to true in the webpack configuration.
+ * after the build is complete. This plugin will only run if the `minToMax` option is set to true in the webpack configuration.
  */
 class CopyMinToMaxWebpackPlugin {
     apply(compiler: Compiler) {
         compiler.hooks.done.tap("CopyToMax", (stats) => {
             const outputPath = stats.compilation.outputOptions.path;
-            const file = stats.compilation.outputOptions.filename?.toString();
-            if (outputPath && file) {
-                const from = path.join(outputPath, file);
-                let to;
-                if (file.includes(".min.js")) {
-                    // if maxMode is false, the minified file will have .min.js suffix and the max file will have no suffix
-                    to = path.join(outputPath, file.replace(/\.min\.js$/, ".js"));
-                } else {
-                    // if maxMode is true, the minified file will have no suffix and the max file will have max.js suffix
-                    to = path.join(outputPath, file.replace(/\.js$/, ".max.js"));
+            if (outputPath) {
+                for (const chunk of stats.compilation.chunks) {
+                    for (const file of chunk.files) {
+                        const from = path.join(outputPath, file);
+                        let to;
+                        if (file.includes(".min.js")) {
+                            // if maxMode is false, the minified file will have .min.js suffix and the max file will have no suffix
+                            to = path.join(outputPath, file.replace(/\.min\.js$/, ".js"));
+                        } else {
+                            // if maxMode is true, the minified file will have no suffix and the max file will have max.js suffix
+                            to = path.join(outputPath, file.replace(/\.js$/, ".max.js"));
+                        }
+                        copyFile(from, to);
+                    }
                 }
-                copyFile(from, to);
             }
         });
     }

packages/public/umd/babylonjs-accessibility/package.json

@@ -1,13 +1,13 @@
 {
     "name": "babylonjs-accessibility",
     "version": "8.13.0",
-    "main": "babylon.accessibility.max.js",
+    "main": "babylon.accessibility.js",
     "types": "babylon.accessibility.module.d.ts",
     "files": [
         "*"
     ],
     "scripts": {
-        "build": "npm run clean && npm run build:dev && npm run build:prod && npm run build:declaration",
+        "build": "npm run clean && npm run build:prod && npm run build:declaration",
         "build:dev": "webpack --env development",
         "build:prod": "webpack --env production",
         "build:declaration": "build-tools -c pud --config ./config.json",

packages/public/umd/babylonjs-accessibility/webpack.config.js

@@ -9,6 +9,7 @@ module.exports = (env) => {
         namespace: "ACCESSIBILITY",
         outputPath: path.resolve(__dirname),
         maxMode: true,
+        minToMax: true,
     });
     return commonConfig;
 };

packages/public/umd/babylonjs-addons/package.json

@@ -1,13 +1,13 @@
 {
     "name": "babylonjs-addons",
     "version": "8.13.0",
-    "main": "babylonjs.addons.js",
+    "main": "babylonjs.addons.min.js",
     "types": "babylonjs.addons.module.d.ts",
     "files": [
         "*"
     ],
     "scripts": {
-        "build": "npm run clean && npm run build:dev && npm run build:prod && npm run build:declaration",
+        "build": "npm run clean && npm run build:prod && npm run build:declaration",
         "build:dev": "webpack --env development",
         "build:prod": "webpack --env production",
         "build:declaration": "build-tools -c pud --config ./config.json",

packages/public/umd/babylonjs-addons/webpack.config.js

@@ -11,9 +11,10 @@ module.exports = (env) => {
         alias: {
             addons: path.resolve(__dirname, "../../../dev/addons/src"),
         },
-        overrideFilename: (pathData) => {
+        overrideFilename: () => {
             return `babylonjs.[name]${env.production ? ".min" : ""}.js`;
         },
+        minToMax: true,
     });
     return commonConfig;
 };

packages/public/umd/babylonjs-gui/package.json

@@ -1,13 +1,13 @@
 {
     "name": "babylonjs-gui",
     "version": "8.13.0",
-    "main": "babylon.gui.js",
+    "main": "babylon.gui.min.js",
     "types": "babylon.gui.module.d.ts",
     "files": [
         "*"
     ],
     "scripts": {
-        "build": "npm run clean && npm run build:dev && npm run build:prod && npm run build:declaration",
+        "build": "npm run clean & npm run build:prod && npm run build:declaration",
         "build:dev": "webpack --env development",
         "build:prod": "webpack --env production",
         "build:declaration": "build-tools -c pud --config ./config.json",

packages/public/umd/babylonjs-gui/webpack.config.js

@@ -11,6 +11,7 @@ module.exports = (env) => {
             gui: path.resolve(__dirname, "../../../dev/gui/src"),
             "@lts/gui": path.resolve(__dirname, "../../../lts/gui/src"),
         },
+        minToMax: true,
     });
     return commonConfig;
 };

packages/public/umd/babylonjs-ktx2decoder/package.json

@@ -7,7 +7,7 @@
         "*"
     ],
     "scripts": {
-        "build": "npm run clean && npm run build:dev && npm run build:prod && npm run build:declaration",
+        "build": "npm run clean && npm run build:prod && npm run build:declaration",
         "build:dev": "webpack --env development",
         "build:prod": "webpack --env production",
         "build:declaration": "build-tools -c pud --config ./config.json",

packages/public/umd/babylonjs-ktx2decoder/webpack.config.js

@@ -6,10 +6,11 @@ module.exports = (env) => {
         devPackageName: "ktx2decoder",
         namespace: "KTX2DECODER",
         maxMode: true,
+        minToMax: true,
         outputPath: path.resolve(__dirname),
         devPackageAliasPath: `../../../tools/ktx2Decoder/dist`,
         alias: {
-            "core": path.resolve(__dirname, "../../../dev/core/dist"),
+            core: path.resolve(__dirname, "../../../dev/core/dist"),
         },
         extendedWebpackConfig: {
             externals: {},
@@ -19,7 +20,7 @@ module.exports = (env) => {
                     includeCSS: true,
                 }),
             },
-        }
+        },
     });
     return commonConfig;
 };

packages/public/umd/babylonjs-loaders/package.json

@@ -1,13 +1,13 @@
 {
     "name": "babylonjs-loaders",
     "version": "8.13.0",
-    "main": "babylonjs.loaders.js",
+    "main": "babylonjs.loaders.min.js",
     "types": "babylonjs.loaders.module.d.ts",
     "files": [
         "*"
     ],
     "scripts": {
-        "build": "npm run clean && npm run build:dev && npm run build:prod && npm run build:declaration",
+        "build": "npm run clean && npm run build:prod && npm run build:declaration",
         "build:dev": "webpack --env development",
         "build:prod": "webpack --env production",
         "build:declaration": "build-tools -c pud --config ./config.json",