Fix specular extension loading

Mike Bond · Mike Bond · commit a21bfe7b86a6 · 2025-08-18T11:30:51.000-07:00
diff --git a/packages/dev/core/src/Shaders/ShadersInclude/openpbrBaseLayerData.fx b/packages/dev/core/src/Shaders/ShadersInclude/openpbrBaseLayerData.fx
@@ -44,7 +44,7 @@ float alpha = 1.0;
 #ifdef SPECULAR_COLOR
     vec4 specularColorFromTexture = texture2D(specularColorSampler, vSpecularColorUV + uvOffset);
     #ifdef SPECULAR_COLOR_GAMMA
-        specularColorFromTexture = toLinearSpace(specularColorFromTexture.rgb);
+        specularColorFromTexture.rgb = toLinearSpace(specularColorFromTexture.rgb);
     #endif
 #endif
 
diff --git a/packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrBaseLayerData.fx b/packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrBaseLayerData.fx
@@ -44,7 +44,7 @@ var alpha: f32 = 1.0;
 #ifdef SPECULAR_COLOR
     var specularColorFromTexture: vec4f = textureSample(specularColorSampler, specularColorSamplerSampler, fragmentInputs.vSpecularColorUV + uvOffset);
     #ifdef SPECULAR_COLOR_GAMMA
-        specularColorFromTexture = toLinearSpace(specularColorFromTexture.rgb);
+        specularColorFromTexture.rgb = toLinearSpace(specularColorFromTexture.rgb);
     #endif
 #endif
 
diff --git a/packages/dev/loaders/src/glTF/2.0/Extensions/KHR_materials_specular.ts b/packages/dev/loaders/src/glTF/2.0/Extensions/KHR_materials_specular.ts
@@ -98,6 +98,7 @@ export class KHR_materials_specular implements IGLTFLoaderExtension {
         }
 
         const promises = new Array<Promise<any>>();
+        promises.push(Promise.resolve());
 
         if (useOpenPBR) {
             if (properties.specularFactor !== undefined) {
@@ -151,7 +152,7 @@ export class KHR_materials_specular implements IGLTFLoaderExtension {
                 promises.push(
                     this._loader.loadTextureInfoAsync(`${context}/specularColorTexture`, properties.specularColorTexture, (texture) => {
                         texture.name = `${babylonMaterial.name} (Specular Color)`;
-                        (babylonMaterial as PBRMaterial).reflectionTexture = texture;
+                        (babylonMaterial as PBRMaterial).reflectanceTexture = texture;
                     })
                 );
             }

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ export class KHR_materials_specular implements IGLTFLoaderExtension {`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`const promises = new Array<Promise<any>>();`
	`101`	`+ promises.push(Promise.resolve());`
`101`	`102`
`102`	`103`	`if (useOpenPBR) {`
`103`	`104`	`if (properties.specularFactor !== undefined) {`
`@@ -151,7 +152,7 @@ export class KHR_materials_specular implements IGLTFLoaderExtension {`
`151`	`152`	`promises.push(`
`152`	`153`	this._loader.loadTextureInfoAsync(`${context}/specularColorTexture`, properties.specularColorTexture, (texture) => {
`153`	`154`	texture.name = `${babylonMaterial.name} (Specular Color)`;
`154`		`- (babylonMaterial as PBRMaterial).reflectionTexture = texture;`
	`155`	`+ (babylonMaterial as PBRMaterial).reflectanceTexture = texture;`
`155`	`156`	`})`
`156`	`157`	`);`
`157`	`158`	`}`