Skip to content

Commit a5896a7

Browse files
authored
Inspector v2: Pass on title case labels for properties (#17001)
This change is just a pass on all the labels of properties in the property pane to make them consistently "Title Case".
1 parent 79d03e2 commit a5896a7

File tree

11 files changed

+43
-43
lines changed

11 files changed

+43
-43
lines changed

packages/dev/inspector-v2/src/components/debug/debugPane.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,14 @@ export const DebugPane: typeof ExtensibleAccordion<Scene> = (props) => {
199199
<BoundProperty component={SwitchPropertyLine} key="Physics" label="Physics" target={scene} propertyKey="physicsEnabled" />
200200
<BoundProperty component={SwitchPropertyLine} key="Collisions" label="Collisions" target={scene} propertyKey="collisionsEnabled" />
201201
<BoundProperty component={SwitchPropertyLine} key="Fog" label="Fog" target={scene} propertyKey="fogEnabled" />
202-
<BoundProperty component={SwitchPropertyLine} key="Lens flares" label="Lens flares" target={scene} propertyKey="lensFlaresEnabled" />
202+
<BoundProperty component={SwitchPropertyLine} key="Lens flares" label="Lens Flares" target={scene} propertyKey="lensFlaresEnabled" />
203203
<BoundProperty component={SwitchPropertyLine} key="Lights" label="Lights" target={scene} propertyKey="lightsEnabled" />
204204
<BoundProperty component={SwitchPropertyLine} key="Particles" label="Particles" target={scene} propertyKey="particlesEnabled" />
205205
<BoundProperty component={SwitchPropertyLine} key="Post-processes" label="Post-processes" target={scene} propertyKey="postProcessesEnabled" />
206206
<BoundProperty component={SwitchPropertyLine} key="Probes" label="Probes" target={scene} propertyKey="probesEnabled" />
207207
<BoundProperty component={SwitchPropertyLine} key="Textures" label="Textures" target={scene} propertyKey="texturesEnabled" />
208-
<BoundProperty component={SwitchPropertyLine} key="Procedural textures" label="Procedural textures" target={scene} propertyKey="proceduralTexturesEnabled" />
209-
<BoundProperty component={SwitchPropertyLine} key="Render targets" label="Render targets" target={scene} propertyKey="renderTargetsEnabled" />
208+
<BoundProperty component={SwitchPropertyLine} key="Procedural textures" label="Procedural Textures" target={scene} propertyKey="proceduralTexturesEnabled" />
209+
<BoundProperty component={SwitchPropertyLine} key="Render targets" label="Render Targets" target={scene} propertyKey="renderTargetsEnabled" />
210210
<BoundProperty component={SwitchPropertyLine} key="Shadows" label="Shadows" target={scene} propertyKey="shadowsEnabled" />
211211
<BoundProperty component={SwitchPropertyLine} key="Skeletons" label="Skeletons" target={scene} propertyKey="skeletonsEnabled" />
212212
<BoundProperty component={SwitchPropertyLine} key="Sprites" label="Sprites" target={scene} propertyKey="spritesEnabled" />

packages/dev/inspector-v2/src/components/properties/animation/animationGroupProperties.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ export const AnimationGroupControlProperties: FunctionComponent<{ animationGroup
4343
<>
4444
<ButtonLine label={isPlaying ? "Pause" : "Play"} onClick={() => (isPlaying ? animationGroup.pause() : animationGroup.play(true))} />
4545
<ButtonLine label="Stop" onClick={() => animationGroup.stop()} />
46-
<BoundProperty component={SyncedSliderPropertyLine} label="Speed ratio" min={0} max={10} step={0.1} target={animationGroup} propertyKey="speedRatio" />
46+
<BoundProperty component={SyncedSliderPropertyLine} label="Speed Ratio" min={0} max={10} step={0.1} target={animationGroup} propertyKey="speedRatio" />
4747
{currentFrameHolder ? (
4848
<SyncedSliderPropertyLine
49-
label="Current frame"
49+
label="Current Frame"
5050
min={animationGroup.from}
5151
max={animationGroup.to}
5252
step={(animationGroup.to - animationGroup.from) / 1000.0}
@@ -67,7 +67,7 @@ export const AnimationGroupControlProperties: FunctionComponent<{ animationGroup
6767
<>
6868
<BoundProperty
6969
component={SyncedSliderPropertyLine}
70-
label="Blending speed"
70+
label="Blending Speed"
7171
min={0}
7272
max={1}
7373
step={0.01}
@@ -76,9 +76,9 @@ export const AnimationGroupControlProperties: FunctionComponent<{ animationGroup
7676
ignoreNullable
7777
defaultValue={0}
7878
/>
79-
<BoundProperty component={SwitchPropertyLine} label="Is additive" target={animationGroup} propertyKey="isAdditive" />
79+
<BoundProperty component={SwitchPropertyLine} label="Is Additive" target={animationGroup} propertyKey="isAdditive" />
8080
<BoundProperty component={NumberInputPropertyLine} label="Weight" target={animationGroup} propertyKey="weight" step={0.1} />
81-
<BoundProperty component={NumberInputPropertyLine} label="Play order" target={animationGroup} propertyKey="playOrder" step={0} />
81+
<BoundProperty component={NumberInputPropertyLine} label="Play Order" target={animationGroup} propertyKey="playOrder" step={0} />
8282
{/* TODO: Hey georgie :<Play order> should be integer (even when typing)*/}
8383
</>
8484
</Collapse>

packages/dev/inspector-v2/src/components/properties/animation/animationsProperties.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ export const AnimationsProperties: FunctionComponent<{ scene: Scene; entity: Par
175175
{mainAnimatable && (ranges.length > 0 || animations.length > 0) ? (
176176
<>
177177
<SwitchPropertyLine
178-
label="Enable override"
178+
label="Enable Override"
179179
value={animationPropertiesOverride != null}
180180
onChange={(value) => {
181181
if (value) {
@@ -196,7 +196,7 @@ export const AnimationsProperties: FunctionComponent<{ scene: Scene; entity: Par
196196
/>
197197
<BoundProperty
198198
component={SyncedSliderPropertyLine}
199-
label="Blending speed"
199+
label="Blending Speed"
200200
target={animationPropertiesOverride!}
201201
propertyKey="blendingSpeed"
202202
min={0}

packages/dev/inspector-v2/src/components/properties/frameGraph/frameGraphProperties.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ export const FrameGraphGeneralProperties: FunctionComponent<{ frameGraph: FrameG
3030
<>
3131
<BoundProperty
3232
component={CheckboxPropertyLine}
33-
label="Optimize texture allocation"
33+
label="Optimize Texture Allocation"
3434
description="Whether to optimize texture allocation."
3535
target={frameGraph}
3636
propertyKey="optimizeTextureAllocation"
3737
></BoundProperty>
3838
{isSceneFrameGraph !== frameGraph && <ButtonLine onClick={() => (frameGraph.scene.frameGraph = frameGraph)} label="Set as scene's frame graph" />}
3939
<ButtonLine
40-
label="Edit graph"
40+
label="Edit Graph"
4141
onClick={() => {
4242
void frameGraph.getLinkedNodeRenderGraph()!.edit({ nodeRenderGraphEditorConfig: { hostScene: frameGraph.scene } });
4343
}}

packages/dev/inspector-v2/src/components/properties/materials/materialProperties.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export const MaterialGeneralProperties: FunctionComponent<{ material: Material }
8585
defaultValue={material.getScene().useRightHandedSystem ? Material.CounterClockWiseSideOrientation : Material.ClockWiseSideOrientation}
8686
/>
8787
{/* TODO: Property name is different per material type
88-
<BoundProperty component={SwitchPropertyLine} label="Disable lighting" target={material} propertyKey="disableLighting" /> */}
88+
<BoundProperty component={SwitchPropertyLine} label="Disable Lighting" target={material} propertyKey="disableLighting" /> */}
8989
<BoundProperty component={SwitchPropertyLine} label="Disable Color Write" target={material} propertyKey="disableColorWrite" />
9090
<BoundProperty component={SwitchPropertyLine} label="Disable Depth Write" target={material} propertyKey="disableDepthWrite" />
9191
<BoundProperty component={NumberDropdownPropertyLine} label="Depth Function" options={DepthFunctionOptions} target={material} propertyKey="depthFunction" />
@@ -147,8 +147,8 @@ export const MaterialStencilProperties: FunctionComponent<{ material: Material }
147147
<Collapse visible={stencilEnabled}>
148148
<>
149149
{/* TODO: Make HexPropertyLine work in the case of simply editing a hex value */}
150-
{/* <BoundProperty component={HexPropertyLine} label="Write mask" target={material.stencil} propertyKey="mask" /> */}
151-
{/* <BoundProperty component={HexPropertyLine} label="Read mask" target={material.stencil} propertyKey="funcMask" /> */}
150+
{/* <BoundProperty component={HexPropertyLine} label="Write Mask" target={material.stencil} propertyKey="mask" /> */}
151+
{/* <BoundProperty component={HexPropertyLine} label="Read Mask" target={material.stencil} propertyKey="funcMask" /> */}
152152
{/** TODO: Force int integer-only for NumberInputPropertyLine */}
153153
<BoundProperty component={NumberInputPropertyLine} label="Reference Value" target={material.stencil} propertyKey="funcRef" step={0} />
154154
<PropertyLine

packages/dev/inspector-v2/src/components/properties/particles/particleSystemProperties.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const ParticleSystemEmissionProperties: FunctionComponent<{ particleSyste
2727
{!system.isNodeGenerated && (
2828
<FactorGradientList
2929
gradients={emitRateGradients}
30-
label="Emit rate gradient"
30+
label="Emit Rate Gradient"
3131
removeGradient={(gradient: IValueGradient) => {
3232
system.removeEmitRateGradient(gradient.gradient);
3333
system.forceRefreshGradients();
@@ -63,7 +63,7 @@ export const ParticleSystemColorProperties: FunctionComponent<{ particleSystem:
6363
{!system.isNodeGenerated && (
6464
<Color4GradientList
6565
gradients={colorGradients}
66-
label="Color gradient"
66+
label="Color Gradient"
6767
removeGradient={(gradient: IValueGradient) => {
6868
system.removeEmitRateGradient(gradient.gradient);
6969
system.forceRefreshGradients();

packages/dev/inspector-v2/src/components/properties/skeleton/boneProperties.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const BoneGeneralProperties: FunctionComponent<{ bone: Bone; selectionSer
1111
<>
1212
<LinkToEntityPropertyLine
1313
key="Linked Transform Node"
14-
label="Linked node"
14+
label="Linked Node"
1515
description="The transform node linked to this bone."
1616
entity={bone.getTransformNode()}
1717
selectionService={props.selectionService}

packages/dev/inspector-v2/src/components/properties/skeleton/skeletonProperties.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ export const SkeletonGeneralProperties: FunctionComponent<{ skeleton: Skeleton }
1919

2020
return (
2121
<>
22-
<StringifiedPropertyLine key="SkeletonBoneCount" label="Bone count" description="The number of bones of the skeleton." value={skeleton.bones.length} />
22+
<StringifiedPropertyLine key="SkeletonBoneCount" label="Bone Count" description="The number of bones of the skeleton." value={skeleton.bones.length} />
2323
<BoundProperty
2424
key="SkeletonUseTextureToStoreBoneMatrices2"
2525
component={SwitchPropertyLine}
26-
label="Use texture to store bone matrices"
26+
label="Use Texture to Store Bone Matrices"
2727
target={skeleton}
2828
propertyKey="useTextureToStoreBoneMatrices"
2929
/>
30-
<ButtonLine key="SkeletonReturnToRest" label="Return to rest" onClick={() => skeleton.returnToRest()} />
30+
<ButtonLine key="SkeletonReturnToRest" label="Return to Rest" onClick={() => skeleton.returnToRest()} />
3131
</>
3232
);
3333
};

packages/dev/inspector-v2/src/components/properties/textures/baseTextureProperties.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,15 +177,15 @@ export const BaseTextureTransformProperties: FunctionComponent<{ texture: BaseTe
177177
<>
178178
{texture.canRescale && (
179179
<ButtonLine
180-
label="Scale up"
180+
label="Scale Up"
181181
onClick={() => {
182182
texture.scale(2);
183183
}}
184184
/>
185185
)}
186186
{texture.canRescale && (
187187
<ButtonLine
188-
label="Scale down"
188+
label="Scale Down"
189189
onClick={() => {
190190
texture.scale(0.5);
191191
}}

0 commit comments

Comments
 (0)