Skip to content

Commit caa1d12

Browse files
georginahalpernGeorgina
andauthored
Reduce build parallelization; update inspector and gui editor package.json to point to minified bundle (#16759)
When introducing fluent dependency in [this PR](#16709) we saw our build agents running out of memory when running es6/UMD build steps, and we also saw the importing of public inspector package causing heap allocation error in the test app sceneWithInspector test. After many attempts to solve (branching off onto another [smaller PR](#16747) to isolate the causes) the solution we are landing on is to reduce parallelization of build steps (solving OOM during es6/UMD build, and confirmed that it wont slow down our build) and to update the inspector and gui editor package.json to point to the minified bundle (solving heap allocation error, and confirmed via npm link + babylonjs-webpack-es6 test app that inspector loads properly) Co-authored-by: Georgina <[email protected]>
1 parent 9f9e0b7 commit caa1d12

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,12 @@
6464
"build:lts": "npm run build:assets && npm run build:source:lts",
6565
"build:source": "tsc -b ./tsconfig.devpackages.json",
6666
"build:source:lts": "npx nx run-many --target=compile --projects=@lts/core,@lts/gui,@lts/loaders,@lts/materials,@lts/post-processes,@lts/procedural-textures,@lts/serializers --parallel=1",
67-
"build:umd": "nx run-many --target=build --parallel --maxParallel=6 --projects=babylonjs,babylonjs-gui,babylonjs-inspector,babylonjs-loaders,babylonjs-materials,babylonjs-serializers,babylonjs-post-process,babylonjs-procedural-textures,babylonjs-node-editor,babylonjs-node-geometry-editor,babylonjs-node-render-graph-editor,babylonjs-node-particle-editor,babylonjs-gui-editor,babylonjs-ktx2decoder,babylonjs-accessibility,babylonjs-addons",
68-
"build:es6": "nx run-many --target=build --parallel --maxParallel=6 --projects=@babylonjs/core,@babylonjs/gui,@babylonjs/loaders,@babylonjs/materials,@babylonjs/serializers,@babylonjs/post-processes,@babylonjs/procedural-textures,@babylonjs/node-editor,@babylonjs/node-geometry-editor,@babylonjs/node-render-graph-editor,@babylonjs/node-particle-editor,@babylonjs/inspector,@babylonjs/gui-editor,@babylonjs/viewer,@babylonjs/shared-ui-components,@babylonjs/addons,@babylonjs/accessibility,@babylonjs/ktx2decoder",
67+
"build:umd": "npm run build:umd:libs && npm run build:umd:tools",
68+
"build:umd:libs": "nx run-many --target=build --parallel --maxParallel=6 --projects=babylonjs,babylonjs-gui,babylonjs-loaders,babylonjs-materials,babylonjs-serializers,babylonjs-post-process,babylonjs-procedural-textures,babylonjs-ktx2decoder,babylonjs-accessibility,babylonjs-addons",
69+
"build:umd:tools": "nx run-many --target=build --parallel --maxParallel=2 --projects=babylonjs-inspector,babylonjs-node-editor,babylonjs-node-geometry-editor,babylonjs-node-render-graph-editor,babylonjs-node-particle-editor,babylonjs-gui-editor",
70+
"build:es6": "npm run build:es6:libs && npm run build:es6:tools",
71+
"build:es6:libs": "nx run-many --target=build --parallel --maxParallel=6 --projects=@babylonjs/core,@babylonjs/gui,@babylonjs/loaders,@babylonjs/materials,@babylonjs/serializers,@babylonjs/post-processes,@babylonjs/procedural-textures,@babylonjs/viewer,@babylonjs/shared-ui-components,@babylonjs/addons,@babylonjs/accessibility,@babylonjs/ktx2decoder",
72+
"build:es6:tools": "nx run-many --target=build --parallel --maxParallel=2 --projects=@babylonjs/node-editor,@babylonjs/node-geometry-editor,@babylonjs/node-render-graph-editor,@babylonjs/node-particle-editor,@babylonjs/inspector,@babylonjs/gui-editor",
6973
"watch:shaders": "build-tools -c build-shaders --global --watch",
7074
"watch:assets": "build-tools -c pa --global --watch",
7175
"watch:source:dev": "tsc -b ./tsconfig.devpackages.json -w",

packages/dev/addons/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
"build": "npm run clean && npm run compile",
1414
"test": "jest -c ../../../jest.config.ts",
1515
"clean": "rimraf dist && rimraf *.tsbuildinfo -g",
16+
"precompile": "npm run compile:assets",
1617
"compile": "tsc -b tsconfig.build.json",
18+
"compile:assets": "build-tools -c process-assets",
1719
"watch": "tsc -b tsconfig.build.json -w",
1820
"watch:dev": "npm run watch"
1921
},

packages/public/@babylonjs/gui-editor/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"name": "@babylonjs/gui-editor",
33
"version": "8.12.1",
4-
"main": "dist/babylon.guiEditor.max.js",
5-
"module": "dist/babylon.guiEditor.max.js",
6-
"esnext": "dist/babylon.guiEditor.max.js",
4+
"main": "dist/babylon.guiEditor.js",
5+
"module": "dist/babylon.guiEditor.js",
6+
"esnext": "dist/babylon.guiEditor.js",
77
"typings": "dist/babylon.guiEditor.module.d.ts",
88
"files": [
99
"dist/**/*.*",

packages/public/@babylonjs/inspector/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
{
22
"name": "@babylonjs/inspector",
33
"version": "8.12.1",
4-
"module": "dist/babylon.inspector.bundle.max.js",
5-
"main": "dist/babylon.inspector.bundle.max.js",
4+
"module": "dist/babylon.inspector.bundle.js",
5+
"main": "dist/babylon.inspector.bundle.js",
6+
"esnext": "dist/babylon.inspector.bundle.js",
67
"typings": "dist/babylon.inspector.module.d.ts",
78
"files": [
89
"dist/**/*.*",
@@ -52,7 +53,6 @@
5253
"babylon.js"
5354
],
5455
"license": "Apache-2.0",
55-
"esnext": "dist/babylon.inspector.bundle.max.js",
5656
"sideEffects": true,
5757
"homepage": "https://www.babylonjs.com",
5858
"repository": {

packages/public/umd/babylonjs-gui-editor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "babylonjs-gui-editor",
33
"version": "8.12.1",
4-
"main": "babylon.guiEditor.max.js",
4+
"main": "babylon.guiEditor.js",
55
"types": "babylon.guiEditor.module.d.ts",
66
"files": [
77
"*"

packages/public/umd/babylonjs-inspector/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "babylonjs-inspector",
33
"version": "8.12.1",
4-
"main": "babylon.inspector.bundle.max.js",
4+
"main": "babylon.inspector.bundle.js",
55
"types": "babylon.inspector.module.d.ts",
66
"files": [
77
"*"

0 commit comments

Comments
 (0)