Update playground's monaco-editor package to fix sourcemap errors #17493
Conversation
With the new playground the monaco-editor package has errors due to missing sourcemaps. This change takes the upstream fix for this and updates our code to fix the deprecation issues introduced by the update. Note that the webpack `monacoEditorPath` option has to be set now to avoid new webpack errors occurring when building/running the playground.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17493/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17493/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17493/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17493/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17493/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Moving to draft to prevent over excitement merge before the weekend :-) |
4 participants
With the new playground the monaco-editor package has errors due to missing sourcemaps. This change takes the upstream fix for this and updates our code to fix the deprecation issues introduced by the update.
Note that the webpack
monacoEditorPathoption has to be set now to avoid new webpack errors occurring when building/running the playground.