Skip to content

Conversation

@VicenteCartas
Copy link
Contributor

  • Adds a new UpdateNoiseBlock to support migrating noise from old system to NPE.
  • Minor changes required to handle a ProceduralTexture.
  • Resets particle randomNoiseCoordinates1 and 2.

PG to test: #R1JWLA#150
image

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 22, 2025

let noiseData: INodeParticleTextureData;

// eslint-disable-next-line github/no-then
void noiseTexture.extractTextureContentAsync().then((textureContent: Nullable<INodeParticleTextureData>) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be call on every frame right? Unless I'm wrong (which is totally possible). This will be called just once and never change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this needs to go inside the process noise function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants