Updated clang format (#1201)

- Updated clang-format to standardize  code across the repo. 

- Applied clang-format to the entire current code base.

Author: SergioRZMasson

.clang-format

@@ -1,21 +1,29 @@
-# https://releases.llvm.org/8.0.0/tools/clang/docs/ClangFormatStyleOptions.html
----
 BasedOnStyle: LLVM
----
+
 Language: Cpp
 
-AccessModifierOffset: -4
-AlignAfterOpenBracket: DontAlign
-AlignOperands: false
-AlwaysBreakTemplateDeclarations: true
+AlignOperands: true
 BreakBeforeBraces: Allman
+BreakConstructorInitializersBeforeComma: true
 BreakConstructorInitializers: BeforeComma
 ColumnLimit: 0
 FixNamespaceComments: false
 IndentCaseLabels: true
 IndentWidth: 4
-NamespaceIndentation: All
-PointerAlignment: Left
 SortIncludes: false
 SpaceAfterTemplateKeyword: false
----
+SpaceBeforeParens: ControlStatements
+SpaceBeforeRangeBasedForLoopColon: true
+SpacesBeforeTrailingComments: 1
+NamespaceIndentation: All
+AccessModifierOffset: -4
+PointerAlignment: Left
+AlwaysBreakTemplateDeclarations: true
+AlignAfterOpenBracket: DontAlign
+ConstructorInitializerIndentWidth: 4
+ContinuationIndentWidth: 4
+ConstructorInitializerAllOnOneLineOrOnePerLine: false
+AllowShortLambdasOnASingleLine: All
+AllowShortCaseLabelsOnASingleLine: true
+AllowShortIfStatementsOnASingleLine: WithoutElse
+BreakBeforeTernaryOperators: true

Core/AppRuntime/Include/Babylon/Dispatchable.h

@@ -29,7 +29,7 @@ namespace Babylon
         {
         public:
             DispatchableImpl(DispatchableImpl<CallableT, ReturnT(ArgsT...)>&& other) = default;
-        
+
             DispatchableImpl(CallableT&& callable)
                 : m_callable{std::forward<CallableT>(callable)}
             {

Core/AppRuntime/Source/AppRuntime_JSI.cpp

@@ -38,7 +38,7 @@ namespace Babylon
         v8runtime::V8RuntimeArgs args{};
         args.inspectorPort = 5643;
         args.foreground_task_runner = std::make_shared<TaskRunnerAdapter>(*m_workQueue);
-        
+
         const auto runtime{v8runtime::makeV8Runtime(std::move(args))};
         const auto env{Napi::Attach<facebook::jsi::Runtime&>(*runtime)};
         Dispatch([&runtime](Napi::Env env) {

Core/AppRuntime/Source/WorkQueue.h

@@ -23,13 +23,11 @@ namespace Babylon
             // copyable callable if necessary.
             if constexpr (std::is_copy_constructible<CallableT>::value)
             {
-                m_dispatcher.queue([this, callable = std::move(callable)]()
-                    { Invoke(callable); });
+                m_dispatcher.queue([this, callable = std::move(callable)]() { Invoke(callable); });
             }
             else
             {
-                m_dispatcher.queue([this, callablePtr = std::make_shared<CallableT>(std::move(callable))]()
-                    { Invoke(*callablePtr); });
+                m_dispatcher.queue([this, callablePtr = std::make_shared<CallableT>(std::move(callable))]() { Invoke(*callablePtr); });
             }
         }
 

Core/Graphics/InternalInclude/Babylon/Graphics/FrameBuffer.h

@@ -46,7 +46,6 @@ namespace Babylon::Graphics
         void Dispose();
 
     private:
-
         DeviceContext& m_context;
         bgfx::FrameBufferHandle m_handle;
         const uint16_t m_width;

Core/Graphics/InternalInclude/Babylon/Graphics/SafeTimespanGuarantor.h

@@ -30,7 +30,7 @@ namespace Babylon::Graphics
 
         using SafetyGuarantee = gsl::final_action<std::function<void()>>;
         SafetyGuarantee GetSafetyGuarantee();
-        
+
         void Open();
         void RequestClose();
         void Lock();

Core/Graphics/InternalInclude/Babylon/Graphics/continuation_scheduler.h

@@ -45,7 +45,7 @@ namespace Babylon
         {
             m_dispatcher.tick(cancellation);
         }
-    
+
     private:
         arcana::manual_dispatcher<WorkSize> m_dispatcher{};
         continuation_scheduler<WorkSize> m_scheduler{};

Core/Graphics/Source/Device.cpp

@@ -3,7 +3,9 @@
 
 namespace Babylon::Graphics
 {
-    class Device::Impl : public DeviceImpl { };
+    class Device::Impl : public DeviceImpl
+    {
+    };
 
     Device::Device()
         : m_impl{std::make_unique<Impl>()}
@@ -82,16 +84,13 @@ namespace Babylon::Graphics
     {
         auto& guarantor = m_impl->GetSafeTimespanGuarantor(updateName);
         return {
-            [&guarantor]
-            { 
+            [&guarantor] {
                 guarantor.Open();
             },
-            [&guarantor](std::function<void()> callback)
-            {
+            [&guarantor](std::function<void()> callback) {
                 guarantor.CloseScheduler()(std::move(callback));
                 guarantor.RequestClose();
-            }
-        };
+            }};
     }
 
     void Device::StartRenderingCurrentFrame()

Core/Graphics/Source/DeviceImpl.cpp

@@ -88,7 +88,7 @@ namespace Babylon::Graphics
                 init.resolution.reset |= BGFX_RESET_MSAA_X16;
                 break;
             default:
-                m_bgfxCallback.trace(__FILE__, __LINE__,  "WARNING: Setting an incorrect value for SetMSAA (%d). Correct values are 0, 1 (disable MSAA) or 2, 4, 8, 16.", int(value));
+                m_bgfxCallback.trace(__FILE__, __LINE__, "WARNING: Setting an incorrect value for SetMSAA (%d). Correct values are 0, 1 (disable MSAA) or 2, 4, 8, 16.", int(value));
                 break;
         }
     }
@@ -233,7 +233,7 @@ namespace Babylon::Graphics
                 value.Lock();
             }
         }
-        
+
         arcana::trace_region finishRenderingRegion{"DeviceImpl::FinishRenderingCurrentFrame"};
 
         assert(m_renderThreadAffinity.check());

Core/Graphics/Source/FrameBuffer.cpp

@@ -63,14 +63,14 @@ namespace Babylon::Graphics
     void FrameBuffer::Bind(bgfx::Encoder& encoder)
     {
         m_viewId = m_context.AcquireNewViewId(encoder);
-        
+
         //Reset view state for next frame.
         m_viewPort = {0, 0, 1, 1};
         m_flags = BGFX_CLEAR_NONE;
         m_rgba = 0x000000ff;
         m_depth = 1.0f;
         m_stencil = 0;
-        
+
         SetDefaultClearMode(m_viewId, m_handle, BGFX_CLEAR_NONE, 0x000000ff, 1.0f, 0);
         setViewPort(m_viewId, m_viewPort, Width(), Height());
         m_hasViewIdBeenUsed = false;
@@ -161,10 +161,9 @@ namespace Babylon::Graphics
 
     bool ViewPort::Equals(const ViewPort& other) const
     {
-        return
-            std::abs(X - other.X) < std::numeric_limits<float>::epsilon() &&
-            std::abs(Y - other.Y) < std::numeric_limits<float>::epsilon() &&
-            std::abs(Width - other.Width) < std::numeric_limits<float>::epsilon() &&
-            std::abs(Height - other.Height) < std::numeric_limits<float>::epsilon();
+        return std::abs(X - other.X) < std::numeric_limits<float>::epsilon() &&
+               std::abs(Y - other.Y) < std::numeric_limits<float>::epsilon() &&
+               std::abs(Width - other.Width) < std::numeric_limits<float>::epsilon() &&
+               std::abs(Height - other.Height) < std::numeric_limits<float>::epsilon();
     }
 }