Skip to content

Commit 4c76fc4

Browse files
authored
Clean up tests code (#1571)
1 parent d5cf1ee commit 4c76fc4

24 files changed

+29146
-484
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
/build
22
.DS_Store
33
.vscode
4-
dist/

Apps/Playground/Android/BabylonNative/src/main/cpp/BabylonNativeJNI.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#include <Babylon/Polyfills/Window.h>
2525
#include <Babylon/Polyfills/XMLHttpRequest.h>
2626
#include <Babylon/Polyfills/Canvas.h>
27-
#include "Babylon/DebugTrace.h"
27+
#include <Babylon/DebugTrace.h>
2828

2929
namespace
3030
{

Apps/UnitTests/Android/app/src/main/cpp/JNI.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
#include "gtest/gtest.h"
1+
#include <gtest/gtest.h>
22
#include <jni.h>
33
#include <Android/log.h>
44
#include <AndroidExtensions/Globals.h>
55
#include <AndroidExtensions/JavaWrappers.h>
66
#include <AndroidExtensions/StdoutLogger.h>
77
#include <atomic>
88
#include <Shared/Tests.h>
9-
#include "Babylon/DebugTrace.h"
9+
#include <Babylon/DebugTrace.h>
1010

1111
extern "C" JNIEXPORT jint JNICALL
1212
Java_com_babylonnative_unittests_Native_javaScriptTests(JNIEnv* env, jclass clazz, jobject context) {

Apps/UnitTests/Apple/App.mm

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
#include "../Shared/Shared.h"
2-
#include "Babylon/DebugTrace.h"
1+
#include "../Shared/Tests.h"
2+
#include <Babylon/DebugTrace.h>
33

4-
int main() {
4+
int main()
5+
{
56
Babylon::DebugTrace::EnableDebugTrace(true);
67
Babylon::DebugTrace::SetTraceOutput([](const char* trace) { NSLog(@"%s", trace); });
78

Apps/UnitTests/CMakeLists.txt

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,21 @@ if(NOT((WIN32 AND NOT WINDOWS_STORE) OR (APPLE AND NOT IOS) OR (UNIX AND NOT AND
33
message(FATAL_ERROR "Unsupported platform: ${CMAKE_SYSTEM_NAME}")
44
endif()
55

6-
set(SCRIPTS
7-
"Scripts/tests.ts"
8-
"Scripts/unittests_performance_shadercache.ts")
6+
set(BABYLONJS_ASSETS
7+
"../node_modules/babylonjs/babylon.max.js")
98

10-
set(BUILD_SCRIPTS
11-
"dist/tests.js"
12-
"dist/unittests_performance_shadercache.js")
9+
set(BABYLONJS_MATERIALS_ASSETS
10+
"../node_modules/babylonjs-materials/babylonjs.materials.js")
11+
12+
set(TEST_ASSETS
13+
"JavaScript/dist/tests.javaScript.all.js"
14+
"JavaScript/dist/tests.nativeEngine.shaderCache.js")
1315

1416
set(SOURCES
15-
"Shared/Shared.h"
16-
"Shared/Shared.cpp")
17+
"Shared/Tests.h"
18+
"Shared/Tests.cpp"
19+
"Shared/Tests.JavaScript.cpp"
20+
"Shared/Tests.NativeEngine.cpp")
1721

1822
if(APPLE)
1923
find_library(JAVASCRIPTCORE_LIBRARY JavaScriptCore)
@@ -25,7 +29,7 @@ elseif(WIN32)
2529
set(SOURCES ${SOURCES} "Win32/App.cpp")
2630
endif()
2731

28-
add_executable(UnitTests ${SCRIPTS} ${BUILD_SCRIPTS} ${SOURCES})
32+
add_executable(UnitTests ${BABYLONJS_ASSETS} ${BABYLONJS_MATERIALS_ASSETS} ${TEST_ASSETS} ${SOURCES})
2933
set_property(TARGET UnitTests PROPERTY UNITY_BUILD false)
3034

3135
target_link_libraries(UnitTests
@@ -50,16 +54,17 @@ add_test(NAME UnitTests COMMAND UnitTests)
5054
add_custom_command(TARGET UnitTests POST_BUILD
5155
COMMAND ${CMAKE_COMMAND} -E $<IF:$<BOOL:$<TARGET_RUNTIME_DLLS:UnitTests>>,copy,true> $<TARGET_RUNTIME_DLLS:UnitTests> $<TARGET_FILE_DIR:UnitTests> COMMAND_EXPAND_LISTS)
5256

53-
foreach(SCRIPT ${BUILD_SCRIPTS})
54-
get_filename_component(SCRIPT_NAME "${SCRIPT}" NAME)
57+
foreach(ASSET ${BABYLONJS_ASSETS} ${BABYLONJS_MATERIALS_ASSETS} ${TEST_ASSETS})
58+
get_filename_component(ASSET_NAME "${ASSET}" NAME)
5559
add_custom_command(
56-
OUTPUT "${CMAKE_CFG_INTDIR}/Scripts/${SCRIPT_NAME}"
57-
COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/${SCRIPT}" "${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/Scripts/${SCRIPT_NAME}"
58-
COMMENT "Copying ${SCRIPT_NAME}"
59-
MAIN_DEPENDENCY "${CMAKE_CURRENT_SOURCE_DIR}/${SCRIPT}")
60+
OUTPUT "${CMAKE_CFG_INTDIR}/Assets/${ASSET_NAME}"
61+
COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/${ASSET}" "${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/Assets/${ASSET_NAME}"
62+
COMMENT "Copying ${ASSET_NAME}"
63+
MAIN_DEPENDENCY "${CMAKE_CURRENT_SOURCE_DIR}/${ASSET}")
6064
endforeach()
6165

6266
set_property(TARGET UnitTests PROPERTY FOLDER Apps)
6367
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${SOURCES})
64-
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/dist PREFIX dist FILES ${BUILD_SCRIPTS})
65-
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/Scripts PREFIX Scripts FILES ${SCRIPTS})
68+
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/../node_modules/babylonjs PREFIX Assets FILES ${BABYLONJS_ASSETS})
69+
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/../node_modules/babylonjs-materials PREFIX Assets FILES ${BABYLONJS_MATERIALS_ASSETS})
70+
source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR}/JavaScript/dist PREFIX Assets FILES ${TEST_ASSETS})
File renamed without changes.

Apps/UnitTests/babel-plugin-replace-bigint.js renamed to Apps/UnitTests/JavaScript/babel-plugin-replace-bigint.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Replace literal BigInt with Number as it's not supported woth Chakra
1+
// Replace literal BigInt with Number as it's not supported with Chakra
22
// Literals (like 123n) are represented as BigIntLiteral nodes are transformed to NumericLiteral (123)
33
module.exports = function() {
44
return {

0 commit comments

Comments
 (0)