Add missing std::forward calls for perfect forwarding

If the shared_ptr is copied, the final release may end up on a different thread. Adding std::forward will ensure that the lambda is moved and not copied which will prevent multiple threads from owning the shared_ptr. The shared_ptr is being used as a hack anyways. The correct fix is to not use shared_ptr and make Dispatch use the Dispatchable class from AppRuntime or if we can use C++23 someday, use std::move_only_function.

Author: bghgary

Core/JsRuntime/Include/Babylon/JsRuntimeScheduler.h

@@ -108,7 +108,7 @@ namespace Babylon
             template<typename CallableT>
             void operator()(CallableT&& callable) const
             {
-                m_parent.Dispatch(callable);
+                m_parent.Dispatch(std::forward<CallableT>(callable));
             }
 
         private:
@@ -129,7 +129,7 @@ namespace Babylon
             }
             else
             {
-                m_disposingDispatcher(callable);
+                m_disposingDispatcher(std::forward<CallableT>(callable));
             }
 
             --m_count;

Polyfills/Window/Source/TimeoutDispatcher.cpp

@@ -53,8 +53,7 @@ namespace Babylon::Polyfills::Internal
 
         if (time <= earliestTime)
         {
-            m_runtimeScheduler.Get()([this]()
-            {
+            m_runtimeScheduler.Get()([this]() {
                 m_condVariable.notify_one();
             });
         }
@@ -142,8 +141,7 @@ namespace Babylon::Polyfills::Internal
     {
         if (function)
         {
-            m_runtimeScheduler.Get()([function = std::move(function)]()
-            {
+            m_runtimeScheduler.Get()([function = std::move(function)]() {
                 function->Call({});
             });
         }