File tree Expand file tree Collapse file tree 2 files changed +7
-5
lines changed
Dependencies/napi/napi-jsi/include/napi Expand file tree Collapse file tree 2 files changed +7
-5
lines changed Original file line number Diff line number Diff line change @@ -242,13 +242,11 @@ inline T Value::As() const {
242242}
243243
244244inline Boolean Value::ToBoolean () const {
245- // TODO: need to coerce if not the right type
246- return Boolean::New (_env, _value.getBool ());
245+ return {_env, _env->boolean_func .call (_env->rt , _value)};
247246}
248247
249248inline Number Value::ToNumber () const {
250- // TODO: need to coerce if not the right type
251- return Number::New (_env, _value.getNumber ());
249+ return {_env, _env->number_func .call (_env->rt , _value)};
252250}
253251
254252inline String Value::ToString () const {
Original file line number Diff line number Diff line change @@ -59,7 +59,9 @@ struct napi_env__ {
5959 rt.global ().getPropertyAsFunction (rt, " Int32Array" ),
6060 rt.global ().getPropertyAsFunction (rt, " Uint32Array" ),
6161 rt.global ().getPropertyAsFunction (rt, " Float32Array" ),
62- rt.global ().getPropertyAsFunction (rt, " Float64Array" )} {
62+ rt.global ().getPropertyAsFunction (rt, " Float64Array" )}
63+ , boolean_func{rt.global ().getPropertyAsFunction (rt, " Boolean" )}
64+ , number_func{rt.global ().getPropertyAsFunction (rt, " Number" )} {
6365 }
6466
6567 facebook::jsi::Runtime& rt;
@@ -68,6 +70,8 @@ struct napi_env__ {
6870 facebook::jsi::Function array_buffer_ctor;
6971 facebook::jsi::Function promise_ctor;
7072 facebook::jsi::Function typed_array_ctor[9 ];
73+ facebook::jsi::Function boolean_func;
74+ facebook::jsi::Function number_func;
7175
7276 facebook::jsi::Value last_exception;
7377};
You can’t perform that action at this time.
0 commit comments