Native GS #1576
Merged
Native GS #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto NativeGS # Conflicts: # Apps/package-lock.json # Apps/package.json
…nto NativeGS # Conflicts: # Apps/package-lock.json
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds native support for Gaussian Splatting (GS) rendering by introducing a sorting function for splats, shader attribute mappings for splat data, and texture format support for RG16F.
Changes:
- Added
_SortGSfunction to sort Gaussian splats by depth for proper rendering order - Added shader attribute mappings for
splatIndex0-3vertex attributes - Added RG16F texture format support for splat data textures
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| Plugins/NativeOptimizations/Source/NativeOptimizations.cpp | Adds _SortGS function and sortSplatQSort comparator to sort splats by depth based on view matrix |
| Plugins/NativeEngine/Source/ShaderCompilerTraversers.cpp | Adds attribute mappings for splatIndex0-3 to support splat vertex data |
| Plugins/NativeEngine/Source/NativeEngine.cpp | Adds RG16F texture format support and applies sampler flip processing to vertex shader coordinates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.