PR feedback and use latest BN

Author: CedricGuillemet

.github/workflows/android.yml

@@ -11,9 +11,7 @@ jobs:
       - name: Setting up developer environment
         run: node setup_dev.js
         working-directory: ./
-#      - name: Build Android Bundle
-#        run: npm run build:android
-#        working-directory: ./Apps/Playground
+
       - name: Gulp (Android)
         run: npx gulp buildAndroid
         working-directory: ./Package

.github/workflows/ios.yml

@@ -21,10 +21,6 @@ jobs:
           pod install
         working-directory: ./Apps/Playground
 
-#      - name: Build iOS Bundle
-#        run: npm run build:ios
-#        working-directory: ./Apps/Playground
-
       - name: Gulp (iOS)
         run: npx gulp buildIOS
         working-directory: ./Package

.github/workflows/package.yml

@@ -8,7 +8,7 @@ jobs:
     steps:
       - name: Checkout Repo
         uses: actions/[email protected]
-      - name: NPM Install (Binary Package)
+      - name: NPM Install
         run: npm install
         working-directory: ./Package
       - name: Download Assembled Folder

.github/workflows/typescript.yml

@@ -9,7 +9,7 @@ jobs:
       - name: Checkout Repo
         uses: actions/[email protected]
 
-      - name: NPM Install (Binary Package)
+      - name: NPM Install
         run: npm install
         working-directory: ./Package
       - name: NPM Install (Modules)

.github/workflows/windows.yml

@@ -26,14 +26,6 @@ jobs:
           node setup_dev.js
         working-directory: ./
 
-        # Windows development version need a bundle to be built
-        # building bundle consists in running tsc in package, copy needed files in modules and running bundling command
-        
-#      - name: Build Windows Bundle
-#        run: npm run build:windows
-#        working-directory: ./Apps/Playground
-      # Bundle ready, now we can build the project
-
       - name: NPM Generate Windows Project
         run: npx install-windows-test-app
         working-directory: ./Apps/Playground

Apps/Playground/package-windows.json

@@ -3,14 +3,8 @@
   "version": "0.0.1",
   "private": true,
   "scripts": {
-    "android": "react-native run-android",
-    "build:android": "mkdirp dist/res && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res",
-    "build:ios": "mkdirp dist && react-native bundle --entry-file index.js --platform ios --dev true --bundle-output dist/main.ios.jsbundle --assets-dest dist",
-    "build:macos": "mkdirp dist && react-native bundle --entry-file index.js --platform macos --dev true --bundle-output dist/main.macos.jsbundle --assets-dest dist",
     "build:windows": "mkdirp dist && react-native bundle --entry-file index.js --platform windows --dev true --bundle-output dist/main.windows.bundle --assets-dest dist",
-    "ios": "react-native run-ios",
     "lint": "eslint .",
-    "macos": "react-native run-macos --scheme Playground",
     "start": "react-native start",
     "test": "jest",
     "windows": "react-native run-windows --sln windows/Playground.sln"
@@ -33,8 +27,6 @@
     "@babel/preset-env": "^7.25.3",
     "@babel/runtime": "^7.25.0",
     "@react-native-community/cli": "19.0.0",
-    "@react-native-community/cli-platform-android": "19.0.0",
-    "@react-native-community/cli-platform-ios": "19.0.0",
     "@react-native/babel-preset": "0.80.0",
     "@react-native/eslint-config": "0.80.0",
     "@react-native/metro-config": "0.80.0",

Modules/@babylonjs/react-native/README.md

@@ -12,7 +12,7 @@ The `react-native-permissions` dependency is required for XR capabilities of Bab
 
 ### Android Configuration
 
-The minimum Android SDK version is 18. This must be set as `minSdkVersion` in the consuming project's `build.gradle` file.
+The minimum Android SDK version is 21. This must be set as `minSdkVersion` in the consuming project's `build.gradle` file.
 
 ### iOS Configuration
 

Package/gulpfile.js

@@ -224,8 +224,8 @@ const createPackage = async () => {
   exec('npm pack', 'Assembled');
 };
 
-const COMMIT_ID = '6c25966e8f8c0f3a0c13fdf77064f1bde790391f';
-const ZIP_URL = `https://github.com/CedricGuillemet/BabylonNative/archive/${COMMIT_ID}.zip`;
+const COMMIT_ID = 'c27ac0485ceeb4e69d00778f6da130ef074b3ba2';
+const ZIP_URL = `https://github.com/BabylonJS/BabylonNative/archive/${COMMIT_ID}.zip`;
 const TARGET_DIR = path.resolve(__dirname, '../Modules/@babylonjs/react-native/shared/BabylonNative');
 const ZIP_PATH = path.join(TARGET_DIR, `${COMMIT_ID}.zip`);
 const UNZIP_FOLDER = path.join(TARGET_DIR, `Repo`);

setup_dev.js

@@ -69,9 +69,9 @@ async function main() {
 
   const rootDir = process.cwd();
 
-  // Step 1: NPM Install (Binary Package)
+  // Step 1: NPM Install 
   const packageDir = path.join(rootDir, 'Package');
-  executeStep('npm install', packageDir, 'NPM Install (Binary Package)');
+  executeStep('npm install', packageDir, 'NPM Install');
 
   // Step 2: Build BabylonNative source tree
   executeStep('npx gulp buildBabylonNativeSourceTree', packageDir, 'Build BabylonNative source tree');