Skip to content

Commit 729e207

Browse files
getting a bit further with Android
1 parent 973b80c commit 729e207

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

Modules/@babylonjs/react-native/android/CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ set(BABYLON_NATIVE_PLUGIN_NATIVEENGINE_WEBP OFF CACHE BOOL "Disable Babylon Nati
2525

2626
set(THIS_LIBRARY BabylonNative)
2727

28-
include(${CMAKE_CURRENT_LIST_DIR}/../../react-native/shared/CMakeLists.txt)
28+
#include(${CMAKE_CURRENT_LIST_DIR}/../../react-native/shared/CMakeLists.txt)
2929

3030
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
3131
set(CMAKE_CXX_STANDARD 17)
@@ -39,7 +39,10 @@ target_include_directories(jsi INTERFACE ${REACTNATIVE_DIR_CMAKE}/ReactCommon/js
3939
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/src/")
4040

4141
set(BABYLON_NATIVE_BUILD_APPS OFF CACHE BOOL "")
42-
add_subdirectory(${babylonnative_SOURCE_DIR} ${babylonnative_SOURCE_DIR}/build/Android_${CMAKE_ANDROID_ARCH_ABI}/)
42+
#add_subdirectory(${babylonnative_SOURCE_DIR} ${babylonnative_SOURCE_DIR}/build/Android_${CMAKE_ANDROID_ARCH_ABI}/)
43+
44+
set(BABYLON_REACT_NATIVE_SHARED_DIR "${CMAKE_CURRENT_LIST_DIR}/../../react-native/shared")
45+
add_subdirectory(${BABYLON_REACT_NATIVE_SHARED_DIR} ${CMAKE_CURRENT_BINARY_DIR}/shared)
4346

4447
if (NOT ${BASEKIT_BUILD})
4548
disable_warnings(NativeXr)
@@ -53,8 +56,6 @@ disable_warnings(NativeCapture)
5356
disable_warnings(Canvas)
5457
disable_warnings(Window)
5558

56-
set(BABYLON_REACT_NATIVE_SHARED_DIR "${CMAKE_CURRENT_LIST_DIR}/../../react-native/shared")
57-
add_subdirectory(${BABYLON_REACT_NATIVE_SHARED_DIR} ${CMAKE_CURRENT_BINARY_DIR}/shared)
5859

5960
add_library(fbjni SHARED IMPORTED)
6061
set_target_properties(fbjni PROPERTIES

Modules/@babylonjs/react-native/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ android {
9696
"-DFETCHCONTENT_SOURCE_DIR_URLLIB=../shared/BabylonNative/deps/urllib-src",
9797
"-DFETCHCONTENT_SOURCE_DIR_SPIRV-CROSS=../shared/BabylonNative/deps/spirv-cross-src",
9898
"-DFETCHCONTENT_SOURCE_DIR_LIBWEBP=../shared/BabylonNative/deps/libwebp-src",
99-
"-DFETCHCONTENT_SOURCE_DIR_GLSLANG=../shared/BabylonNative/deps/glslang-src",
99+
"-DFETCHCONTENT_SOURCE_DIR_GLSLANG=../shared/BabylonNative/deps/glslang-src"
100100
}
101101
}
102102
ndk {

Modules/@babylonjs/react-native/shared/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
include(FetchContent)
22

3-
add_subdirectory(BabylonNative)
3+
add_subdirectory(${CMAKE_CURRENT_LIST_DIR}/BabylonNative)
44

55
set(SHARED_INCLUDES
66
"${CMAKE_CURRENT_LIST_DIR}")

Package/gulpfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,7 +732,7 @@ function runCMake(buildDir) {
732732
}
733733

734734
function writeCMakeListsFile(commitId, cmakePath) {
735-
const content = `add_subdirectory(BabylonNative-${commitId})\n`;
735+
const content = `add_subdirectory(\${CMAKE_CURRENT_LIST_DIR}/BabylonNative-${commitId})\n`;
736736
fs.writeFileSync(cmakePath, content, 'utf8');
737737
}
738738

@@ -810,7 +810,7 @@ const buildBabylonNativeSourceTree = async () => {
810810
deleteFolderRecursive(`${UNZIP_FOLDER}/Apps`);
811811
deleteFolderRecursive(`${UNZIP_FOLDER}/Documentation`);
812812
deleteFolderRecursive(`${UNZIP_FOLDER}/Install`);
813-
deleteFolderRecursive(`${DEPS_OUTPUT_DIR}/bgfx.cmake-src/bgfx`);
813+
//deleteFolderRecursive(`${DEPS_OUTPUT_DIR}/bgfx.cmake-src/bgfx`);
814814

815815
}
816816

0 commit comments

Comments
 (0)