Skip to content

Commit 77dd8b8

Browse files
cleanup
1 parent 130a5fb commit 77dd8b8

File tree

6 files changed

+7
-13
lines changed

6 files changed

+7
-13
lines changed

.github/workflows/pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: NPM Install (Playground)
3535
run: npm install
3636
working-directory: ./Apps/Playground
37-
- name: Build Windows Bundle
37+
- name: Build Android Bundle
3838
run: npm run build:android
3939
working-directory: ./Apps/Playground
4040

@@ -83,7 +83,7 @@ jobs:
8383
- name: Cache XCFrameworks
8484
uses: actions/cache@v4
8585
with:
86-
path: Modules/@babylonjs/react-native-iosandroid/ios/libs
86+
path: Modules/@babylonjs/react-native/ios/libs
8787
key: ${{ runner.os }}-xcframeworks-${{ github.sha }}
8888
restore-keys: |
8989
${{ runner.os }}-xcframeworks

Apps/Playground/metro.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,5 @@ module.exports = makeMetroConfig({
1212
},
1313
watchFolders: [
1414
path.dirname(require.resolve("@babylonjs/react-native/package.json")),
15-
path.dirname(require.resolve("@babylonjs/react-native-iosandroid/package.json")),
16-
path.dirname(require.resolve("@babylonjs/react-native-windows/package.json")),
1715
],
1816
});

Apps/Playground/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Apps/Playground/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "BRNPlayground",
2+
"name": "Playground",
33
"version": "0.0.1",
44
"private": true,
55
"scripts": {
@@ -10,10 +10,10 @@
1010
"build:windows": "mkdirp dist && react-native bundle --entry-file index.js --platform windows --dev true --bundle-output dist/main.windows.bundle --assets-dest dist",
1111
"ios": "react-native run-ios",
1212
"lint": "eslint .",
13-
"macos": "react-native run-macos --scheme BRNPlayground",
13+
"macos": "react-native run-macos --scheme Playground",
1414
"start": "react-native start",
1515
"test": "jest",
16-
"windows": "react-native run-windows --sln windows/BRNPlayground.sln",
16+
"windows": "react-native run-windows --sln windows/Playground.sln",
1717
"postinstall": "node ./postinstall.js"
1818
},
1919
"dependencies": {

Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonReactNative.vcxproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<ReactNativeWindowsDir Condition="'$(ReactNativeWindowsDir)' == '' And Exists('$(ProjectDir)..\..\..\..\..\Apps\Playground\node_modules\react-native-windows\package.json')">$(ProjectDir)\..\..\..\..\..\Apps\Playground\node_modules\react-native-windows\</ReactNativeWindowsDir>
2929
</PropertyGroup>
3030
<PropertyGroup Label="BabylonReactNativeProps">
31-
<BabylonNativeIOSAndroidProjDir Condition="'$(BabylonReactNativeDir)' == '' And Exists('$(ProjectDir)\..\..\..\react-native-iosandroid')">$(ProjectDir)..\..\..\react-native-iosandroid\</BabylonNativeIOSAndroidProjDir>
3231
<BabylonReactNativeDir Condition="'$(BabylonReactNativeDir)' == '' And Exists('$(ProjectDir)\..\..\..\react-native')">$(ProjectDir)..\..\..\react-native\</BabylonReactNativeDir>
3332
<BabylonNativeDir Condition="Exists('$(BabylonReactNativeDir)Build')">$(BabylonReactNativeDir)Build\</BabylonNativeDir>
3433
<BabylonNativeBuildDir Condition="'$(Platform)'=='x64' And '$(BabylonNativeDir)' != ''">$(BabylonNativeDir)uwp_x64\</BabylonNativeBuildDir>
@@ -168,7 +167,6 @@
168167
<PreprocessorDefinitions>_DEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
169168
<!-- Include project headers when building in the repo -->
170169
<AdditionalIncludeDirectories Condition="Exists('$(BabylonReactNativeDir)shared')">$(BabylonReactNativeDir)shared;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
171-
<AdditionalIncludeDirectories Condition="Exists('$(BabylonNativeIOSAndroidProjDir)shared')">$(BabylonNativeIOSAndroidProjDir)shared;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
172170
</ClCompile>
173171
<Link>
174172
<IgnoreSpecificDefaultLibraries>%(IgnoreSpecificDefaultLibraries)</IgnoreSpecificDefaultLibraries>
@@ -218,7 +216,6 @@
218216
<ClCompile>
219217
<PreprocessorDefinitions>NDEBUG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
220218
<AdditionalIncludeDirectories Condition="Exists('$(BabylonReactNativeDir)shared')">$(BabylonReactNativeDir)shared;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
221-
<AdditionalIncludeDirectories Condition="Exists('$(BabylonNativeIOSAndroidProjDir)shared')">$(BabylonNativeIOSAndroidProjDir)shared;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
222219
</ClCompile>
223220
<Link>
224221
<EnableCOMDATFolding>true</EnableCOMDATFolding>

Modules/@babylonjs/react-native/windows/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ set(BABYLON_NATIVE_PLUGIN_NATIVEENGINE_WEBP OFF CACHE BOOL "Disable Babylon Nati
99
set(CMAKE_CXX_STANDARD 17)
1010

1111
set(BABYLON_REACT_NATIVE_DIR "${CMAKE_CURRENT_LIST_DIR}/../../react-native")
12-
set(BABYLON_REACT_NATIVE_IOSANDROID "${CMAKE_CURRENT_LIST_DIR}/../../react-native-iosandroid")
1312

1413
include(${BABYLON_REACT_NATIVE_DIR}/shared/CMakeLists.txt)
1514

0 commit comments

Comments
 (0)