feat: add support of quality for textures and shadows in scene loader in babylonjs-editor-tools

Author: julien-moreau

tools/src/loading/loader.ts

@@ -41,17 +41,27 @@ export type ScriptMap = Record<
  * Using "medium" or "low" quality levels will reduce the memory usage and improve the performance of the scene
  * especially on mobiles where memory is limited.
  */
-export type SceneLoaderQualitySelector = "low" | "medium" | "high";
+export type SceneLoaderQualitySelector = "very-low" | "low" | "medium" | "high";
 
 export type SceneLoaderOptions = {
 	/**
 	 * Defines the quality of the scene.
 	 * This will affect the quality of textures that will be loaded in terms of dimensions.
 	 * The editor computes automatic "high (untouched)", "medium (half)", and "low (quarter)" quality levels for textures.
 	 * Using "medium" or "low" quality levels will reduce the memory usage and improve the performance of the scene
-	 * especially on mobiles where memory is limited.
+	 * especially on mobiles where memory is limited. The "very-low" quality level is even more aggressive with shadows quality.
 	 */
 	quality?: SceneLoaderQualitySelector;
+
+	/**
+	 * Same as "quality" but only applied to textures. If set, this has priority over "quality".
+	 */
+	texturesQuality?: SceneLoaderQualitySelector;
+	/**
+	 * Same as "quality" but only applied to shadows. If set, this has priority over "quality".
+	 */
+	shadowsQuality?: SceneLoaderQualitySelector;
+
 	/**
 	 * Defines the function called to notify the loading progress in interval [0, 1]
 	 */
@@ -62,12 +72,17 @@ declare module "@babylonjs/core/scene" {
 	// eslint-disable-next-line @typescript-eslint/naming-convention
 	interface Scene {
 		loadingQuality: SceneLoaderQualitySelector;
+		loadingTexturesQuality: SceneLoaderQualitySelector;
+		loadingShadowsQuality: SceneLoaderQualitySelector;
 	}
 }
 
 export async function loadScene(rootUrl: any, sceneFilename: string, scene: Scene, scriptsMap: ScriptMap, options?: SceneLoaderOptions) {
 	scene.loadingQuality = options?.quality ?? "high";
 
+	scene.loadingTexturesQuality = options?.texturesQuality ?? scene.loadingQuality;
+	scene.loadingShadowsQuality = options?.shadowsQuality ?? scene.loadingQuality;
+
 	await AppendSceneAsync(`${rootUrl}${sceneFilename}`, scene, {
 		pluginExtension: ".babylon",
 		onProgress: (event) => {

tools/src/loading/shadows.ts

@@ -8,16 +8,20 @@ import { getPowerOfTwoUntil } from "../tools/scalar";
 const shadowsGeneratorParser = GetParser(SceneComponentConstants.NAME_SHADOWGENERATOR);
 
 AddParser(SceneComponentConstants.NAME_SHADOWGENERATOR, (parsedData: any, scene: Scene, container: AssetContainer, rootUrl: string) => {
-	if (scene.loadingQuality !== "high") {
+	if (scene.loadingShadowsQuality !== "high") {
 		parsedData.shadowGenerators?.forEach((shadowGenerator: any) => {
-			switch (scene.loadingQuality) {
+			switch (scene.loadingShadowsQuality) {
 				case "medium":
 					shadowGenerator.mapSize = shadowGenerator.mapSize * 0.5;
 					break;
 
 				case "low":
 					shadowGenerator.mapSize = shadowGenerator.mapSize * 0.25;
 					break;
+
+				case "very-low":
+					shadowGenerator.mapSize = shadowGenerator.mapSize * 0.125;
+					break;
 			}
 
 			shadowGenerator.mapSize = Math.max(128, getPowerOfTwoUntil(shadowGenerator.mapSize));

tools/src/loading/texture.ts

@@ -11,7 +11,7 @@ import { getPowerOfTwoUntil } from "../tools/scalar";
 const textureParser = SerializationHelper._TextureParser;
 
 SerializationHelper._TextureParser = (sourceProperty: any, scene: Scene, rootUrl: string): Nullable<BaseTexture> => {
-	if (scene.loadingQuality === "high" || !sourceProperty.metadata?.baseSize) {
+	if (scene.loadingTexturesQuality === "high" || !sourceProperty.metadata?.baseSize) {
 		return textureParser(sourceProperty, scene, rootUrl);
 	}
 
@@ -22,7 +22,7 @@ SerializationHelper._TextureParser = (sourceProperty: any, scene: Scene, rootUrl
 
 	let suffix = "";
 
-	switch (scene.loadingQuality) {
+	switch (scene.loadingTexturesQuality) {
 		case "medium":
 			let midWidth = (width * 0.66) >> 0;
 			let midHeight = (height * 0.66) >> 0;
@@ -36,6 +36,7 @@ SerializationHelper._TextureParser = (sourceProperty: any, scene: Scene, rootUrl
 			break;
 
 		case "low":
+		case "very-low":
 			let lowWidth = (width * 0.33) >> 0;
 			let lowHeight = (height * 0.33) >> 0;