Skip to content

Commit 7c38107

Browse files
authored
Disable flaky httpbin tests (#121)
There seems to be some hiccups with httpbin right now, which is causing these tests to be flaky (responding with 503 statuses). This PR is to temporarily disable them.
1 parent 8b9f88b commit 7c38107

File tree

1 file changed

+29
-28
lines changed

1 file changed

+29
-28
lines changed

Tests/UnitTests/Scripts/tests.ts

Lines changed: 29 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -147,35 +147,36 @@ describe("XMLHTTPRequest", function () {
147147
expect(sendWithoutOpening).to.throw();
148148
});
149149

150-
if (hostPlatform !== "Unix") {
151-
it("should make a POST request with no body successfully", async function () {
152-
const xhr = await createRequest("POST", "https://httpbin.org/post");
153-
expect(xhr).to.have.property("readyState", 4);
154-
expect(xhr).to.have.property("status", 200);
155-
});
156-
157-
it("should make a POST request with body successfully", async function () {
158-
const xhr = await createRequest("POST", "https://httpbin.org/post", "sampleBody");
159-
expect(xhr).to.have.property("readyState", 4);
160-
expect(xhr).to.have.property("status", 200);
161-
});
162-
}
163-
164-
it("should make a GET request with headers successfully", async function () {
165-
const headersMap = new Map([["foo", "3"], ["bar", "3"]]);
166-
const xhr = await createRequestWithHeaders("GET", "https://httpbin.org/get", headersMap);
167-
expect(xhr).to.have.property("readyState", 4);
168-
expect(xhr).to.have.property("status", 200);
169-
});
150+
// TODO: httpbin server seems to be flaky right now. Re-enable these tests later.
151+
// if (hostPlatform !== "Unix") {
152+
// it("should make a POST request with no body successfully", async function () {
153+
// const xhr = await createRequest("POST", "https://httpbin.org/post");
154+
// expect(xhr).to.have.property("readyState", 4);
155+
// expect(xhr).to.have.property("status", 200);
156+
// });
157+
158+
// it("should make a POST request with body successfully", async function () {
159+
// const xhr = await createRequest("POST", "https://httpbin.org/post", "sampleBody");
160+
// expect(xhr).to.have.property("readyState", 4);
161+
// expect(xhr).to.have.property("status", 200);
162+
// });
163+
// }
164+
165+
// it("should make a GET request with headers successfully", async function () {
166+
// const headersMap = new Map([["foo", "3"], ["bar", "3"]]);
167+
// const xhr = await createRequestWithHeaders("GET", "https://httpbin.org/get", headersMap);
168+
// expect(xhr).to.have.property("readyState", 4);
169+
// expect(xhr).to.have.property("status", 200);
170+
// });
170171

171-
if (hostPlatform !== "Unix") {
172-
it("should make a POST request with body and headers successfully", async function () {
173-
const headersMap = new Map([["foo", "3"], ["bar", "3"]]);
174-
const xhr = await createRequestWithHeaders("POST", "https://httpbin.org/post", headersMap, "testBody");
175-
expect(xhr).to.have.property("readyState", 4);
176-
expect(xhr).to.have.property("status", 200);
177-
});
178-
}
172+
// if (hostPlatform !== "Unix") {
173+
// it("should make a POST request with body and headers successfully", async function () {
174+
// const headersMap = new Map([["foo", "3"], ["bar", "3"]]);
175+
// const xhr = await createRequestWithHeaders("POST", "https://httpbin.org/post", headersMap, "testBody");
176+
// expect(xhr).to.have.property("readyState", 4);
177+
// expect(xhr).to.have.property("status", 200);
178+
// });
179+
// }
179180

180181
if (hostPlatform === "macOS" || hostPlatform === "Unix" || hostPlatform === "Win32") {
181182
it("should load URL pointing to symlink", async function () {

0 commit comments

Comments
 (0)