Up JSC Linux (#107)

Author: CedricGuillemet

.github/jobs/linux.yml

@@ -8,7 +8,7 @@ jobs:
   steps:
   - script: |
       sudo apt-get update
-      sudo apt-get install libjavascriptcoregtk-4.0-dev libcurl4-openssl-dev ninja-build
+      sudo apt-get install libjavascriptcoregtk-4.1-dev libcurl4-openssl-dev ninja-build
     displayName: 'Install packages'
 
   - script: cmake -B Build/ubuntu -GNinja -D CMAKE_BUILD_TYPE=RelWithDebInfo

CMakeLists.txt

@@ -30,7 +30,7 @@ FetchContent_Declare(llhttp
     URL "https://github.com/nodejs/llhttp/archive/refs/tags/release/v8.1.0.tar.gz")
 FetchContent_Declare(UrlLib
     GIT_REPOSITORY https://github.com/BabylonJS/UrlLib.git
-    GIT_TAG 2f12534f242ab15aa761c3b273538f44787cf5e3)
+    GIT_TAG e0eb7d4c36c2cca5bbe82b94fd141734420ba84e)
 # --------------------------------------------------
 
 FetchContent_MakeAvailable(CMakeExtensions)

Core/Node-API/CMakeLists.txt

@@ -7,7 +7,7 @@ elseif(ANDROID)
     set(NAPI_JAVASCRIPT_ENGINE "V8" CACHE STRING "JavaScript engine for Node-API")
 elseif(UNIX)
     set(NAPI_JAVASCRIPT_ENGINE "JavaScriptCore" CACHE STRING "JavaScript engine for Node-API")
-    set(JAVASCRIPTCORE_LIBRARY "/usr/lib/x86_64-linux-gnu/libjavascriptcoregtk-4.0.so" CACHE STRING "Path to the JavaScriptCore shared library")
+    set(JAVASCRIPTCORE_LIBRARY "/usr/lib/x86_64-linux-gnu/libjavascriptcoregtk-4.1.so" CACHE STRING "Path to the JavaScriptCore shared library")
 else()
     message(FATAL_ERROR "Unable to select Node-API JavaScript engine for platform")
 endif()
@@ -76,7 +76,7 @@ if(NAPI_BUILD_ABI)
             set(LINK_LIBRARIES ${LINK_LIBRARIES}
                 PUBLIC ${JAVASCRIPTCORE_LIBRARY})
             set(INCLUDE_DIRECTORIES ${INCLUDE_DIRECTORIES}
-                PUBLIC "/usr/include/webkitgtk-4.0/")
+                PUBLIC "/usr/include/webkitgtk-4.1/")
         else()
             message(FATAL_ERROR "Unsupported JavaScript engine: ${NAPI_JAVASCRIPT_ENGINE}")
         endif()

Polyfills/XMLHttpRequest/Source/XMLHttpRequest.cpp

@@ -117,7 +117,7 @@ namespace Babylon::Polyfills::Internal
             gsl::span<const std::byte> responseBuffer{m_request.ResponseBuffer()};
             auto arrayBuffer{Napi::ArrayBuffer::New(Env(), responseBuffer.size())};
             std::memcpy(arrayBuffer.Data(), responseBuffer.data(), arrayBuffer.ByteLength());
-            return std::move(arrayBuffer);
+            return arrayBuffer;
         }
     }
 
@@ -165,7 +165,7 @@ namespace Babylon::Polyfills::Internal
             responseHeadersObject.Set(key, value);
         }
 
-        return std::move(responseHeadersObject);
+        return responseHeadersObject;
     }
 
     void XMLHttpRequest::SetRequestHeader(const Napi::CallbackInfo& info)