chore(api): rector to php82

Disable ClassPropertyAssignToConstructorPromotionRector
It only added string casts to lambda arguments.

Author: BacLuc

api/rector.php

@@ -15,6 +15,7 @@
 use Rector\Doctrine\Bundle230\Rector\Class_\AddAnnotationToRepositoryRector;
 use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
+use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
 use Rector\PHPUnit\CodeQuality\Rector\ClassMethod\AddInstanceofAssertForNullableInstanceRector;
 use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector;
@@ -36,7 +37,7 @@
     ->withComposerBased(doctrine: true, phpunit: true, symfony: true)
     ->withPreparedSets(deadCode: true, codeQuality: true, privatization: true, rectorPreset: true, phpunitCodeQuality: true, symfonyCodeQuality: true)
     ->withAttributesSets(all: true)
-    ->withPhpSets(php80: true)
+    ->withPhpSets(php82: true)
     ->withConfiguredRule(RenameFunctionRector::class, [
         'implode' => 'join',
         'join' => 'join',
@@ -54,6 +55,7 @@
         FinalizeTestCaseClassRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,
         LocallyCalledStaticMethodToNonStaticRector::class,
+        NullToStrictStringFuncCallArgRector::class,
         PreferPHPUnitThisCallRector::class,
         RemoveDeadInstanceOfRector::class,
         SimplifyIfElseToTernaryRector::class,

api/src/Doctrine/Filter/CampCollaboratorFilter.php

@@ -20,7 +20,7 @@ final class CampCollaboratorFilter extends AbstractFilter {
     public const QUERY_PARAM_NAME = 'campCollaborator';
 
     public function __construct(
-        private IriConverterInterface $iriConverter,
+        private readonly IriConverterInterface $iriConverter,
         ManagerRegistry $managerRegistry,
         ?LoggerInterface $logger = null,
         ?array $properties = null,

api/src/Doctrine/Filter/ContentNodeCampFilter.php

@@ -18,7 +18,7 @@ final class ContentNodeCampFilter extends AbstractFilter {
     public const CAMP_QUERY_NAME = 'camp';
 
     public function __construct(
-        private IriConverterInterface $iriConverter,
+        private readonly IriConverterInterface $iriConverter,
         ManagerRegistry $managerRegistry,
         ?LoggerInterface $logger = null,
         ?array $properties = null,

api/src/Doctrine/Filter/ContentNodePeriodFilter.php

@@ -19,7 +19,7 @@ final class ContentNodePeriodFilter extends AbstractFilter {
     public const PERIOD_QUERY_NAME = 'period';
 
     public function __construct(
-        private IriConverterInterface $iriConverter,
+        private readonly IriConverterInterface $iriConverter,
         ManagerRegistry $managerRegistry,
         ?LoggerInterface $logger = null,
         ?array $properties = null,

api/src/Doctrine/Filter/MaterialItemPeriodFilter.php

@@ -18,7 +18,7 @@ final class MaterialItemPeriodFilter extends AbstractFilter {
     public const PERIOD_QUERY_NAME = 'period';
 
     public function __construct(
-        private IriConverterInterface $iriConverter,
+        private readonly IriConverterInterface $iriConverter,
         ManagerRegistry $managerRegistry,
         ?LoggerInterface $logger = null,
         ?array $properties = null,

api/src/Doctrine/FilterByCurrentUserExtension.php

@@ -12,7 +12,7 @@
 use Doctrine\ORM\QueryBuilder;
 use Symfony\Bundle\SecurityBundle\Security;
 
-final class FilterByCurrentUserExtension implements QueryCollectionExtensionInterface, QueryItemExtensionInterface {
+final readonly class FilterByCurrentUserExtension implements QueryCollectionExtensionInterface, QueryItemExtensionInterface {
     public function __construct(private Security $security, private EntityManagerInterface $entityManager) {}
 
     public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, ?string $resourceClass = null, ?Operation $operation = null, array $context = []): void {

api/src/Doctrine/Orm/Extension/FilterEagerLoadingsExtension.php

@@ -16,7 +16,7 @@
 use Doctrine\ORM\Query\Expr\Orx;
 use Doctrine\ORM\QueryBuilder;
 
-final class FilterEagerLoadingsExtension implements QueryCollectionExtensionInterface {
+final readonly class FilterEagerLoadingsExtension implements QueryCollectionExtensionInterface {
     public function __construct(private QueryCollectionExtensionInterface $decorated) {}
 
     public function applyToCollection(

api/src/EventListener/JWTCreatedListener.php

@@ -11,7 +11,7 @@
  * to know where to fetch personal profile information.
  */
 class JWTCreatedListener {
-    public function __construct(private Security $security, private IriConverterInterface $iriConverter) {}
+    public function __construct(private readonly Security $security, private readonly IriConverterInterface $iriConverter) {}
 
     public function onJWTCreated(JWTCreatedEvent $event) {
         $payload = $event->getData();

api/src/EventListener/RequestTransactionListener.php

@@ -14,12 +14,12 @@
 /**
  * Wraps a database transaction around all SQL statements in the whole request.
  */
-final class RequestTransactionListener implements EventSubscriberInterface {
+final readonly class RequestTransactionListener implements EventSubscriberInterface {
     private \SplStack $transactionLevelStack;
 
     public function __construct(
-        private readonly EntityManagerInterface $entityManager,
-        private readonly LoggerInterface $logger
+        private EntityManagerInterface $entityManager,
+        private LoggerInterface $logger
     ) {
         $this->transactionLevelStack = new \SplStack();
     }

api/src/HttpCache/CacheControlListener.php

@@ -11,7 +11,7 @@
  * - caching is disabled (configurable via environment variable API_CACHE_ENABLED)
  * - total header size is too large to be handled by Varnish (configurable via parameter app.httpCache.maxHeaderSize).
  */
-final class CacheControlListener {
+final readonly class CacheControlListener {
     private bool $apiCacheEnabled;
 
     private int $maxHeaderSize;