Skip to content

Commit 67ed9b2

Browse files
tcorraltomas_backbase
tcorral
and
tomas_backbase
authored
feat: upgrade to angular 20 and migrate to standalone architecture (#596)
* feat: upgrade to angular 20 and migrate to standalone architecture * fix: fix issues in ci/cd * feat(app-component): add styles to do not overflow * fix: fix browswer issues * feat: fix tsc issues * chore: update visual transaction snapshots for Chrome on Linux * fix: update test setup and component spec for improved testing environment * fix: unit tests failing * fix: unit test issues * fix: enhance test setup by adding router provider for user context and user accounts components * fix: refactor user context component tests to utilize injected router for navigation assertions * fix: unit test issues * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: applying code review suggestions * chore: apply code review suggestions * chore: apply code review suggestions * chore: apply code review suggestions * chore: apply code review suggestions * chore: apply code review suggestions * chore: apply code review suggestions * chore: apply suggested changes in code review * chore: apply suggested changes in code review * chore: apply suggested changes in code review * chore: apply suggested changes in code review * chore: apply suggested changes in code review * debug: remove * chore: fix build after refactoring to remove NgModules * chore: fix build after refactoring to remove NgModules * chore: fix build after refactoring to remove NgModules * chore: fix build after refactoring to remove NgModules * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: apply suggested changes in pull request * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: adjust documentation to be checked against implementation code * chore: apply suggested changes in pull request * fix:build step failing * fix:build step failing * fix: format --------- Co-authored-by: tomas_backbase <tomas@backbase.com>
1 parent d5cf6ec commit 67ed9b2

File tree

119 files changed

+22577
-13394
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+22577
-13394
lines changed

‎.github/actions/node-step/action.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ runs:
4040
env:
4141
NODE_AUTH_TOKEN: ${{ inputs.npm-auth-token }}
4242
NODE_EMAIL: ${{ inputs.npm-email }}
43-
continue-on-error: true
4443

4544

4645
- name: Upload NPM Log

‎.github/workflows/pull-request.yml‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ jobs:
4747
env:
4848
NPM_BB_TOKEN: ${{ secrets.NPM_BB_TOKEN }}
4949
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
50-
NPM_EMAIL: ${{ secrets.NPM_EMAIL }}
50+
NPM_EMAIL: ${{ secrets.NODE_EMAIL }}
5151
with:
5252
npm-auth-token: ${{ secrets.NPM_BB_TOKEN }}
53-
npm-email: ${{ secrets.NPM_EMAIL }}
53+
npm-email: ${{ secrets.NODE_EMAIL }}
5454

5555
- name: Cache npm dependencies
5656
uses: actions/cache@v4
@@ -75,7 +75,6 @@ jobs:
7575
playwright:
7676
name: "Playwright Tests"
7777
runs-on: ubuntu-latest
78-
continue-on-error: true
7978
needs: get-playwright-version
8079
container:
8180
image: mcr.microsoft.com/playwright:v${{ needs.get-playwright-version.outputs.version }}
@@ -114,11 +113,9 @@ jobs:
114113
run: |
115114
apt-get update
116115
apt-get install -y default-jre
117-
continue-on-error: true
118116
119117
- name: Generate Allure Report
120118
run: npm run report-generate
121-
continue-on-error: true
122119

123120
- name: Upload Playwright Report
124121
if: ${{ !cancelled() }}

‎apps/golden-sample-app-e2e/src/specs/custom-tests/visual-transactions.spec.ts-snapshots/transactions-page-full-localhost-mocks-visual-chrome-linux.png‎

4.42 KB
Loading

‎apps/golden-sample-app-e2e/src/specs/custom-tests/visual-transactions.spec.ts-snapshots/transactions-page-with-masked-data-localhost-mocks-visual-chrome-linux.png‎

20 Bytes
Loading

‎apps/golden-sample-app/jest.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable */
21
export default {
32
displayName: 'golden-sample-app',
43
preset: '../../jest.preset.js',

‎apps/golden-sample-app/src/app/app-routes.ts‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,12 @@ export const APP_ROUTES: Routes = [
1414
},
1515
{
1616
path: 'select-context',
17-
loadChildren: () =>
18-
import('./user-context/user-context.module').then(
19-
(m) => m.UserContextModule
20-
),
17+
loadComponent: () => import('./user-context/user-context.component'),
2118
canActivate: [AuthGuard],
2219
},
2320
{
2421
path: 'error',
25-
loadChildren: () =>
26-
import('./error-page/error-page.module').then((m) => m.ErrorPageModule),
22+
loadComponent: () => import('./error-page/error-page.component'),
2723
},
2824
TRANSFER_ROUTE,
2925
ACH_POSITIVE_PAY_ROUTE,
@@ -33,7 +29,6 @@ export const APP_ROUTES: Routes = [
3329
{
3430
path: '**',
3531
pathMatch: 'full',
36-
loadChildren: () =>
37-
import('./error-page/error-page.module').then((m) => m.ErrorPageModule),
32+
loadComponent: () => import('./error-page/error-page.component'),
3833
},
3934
];

‎apps/golden-sample-app/src/app/app.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
</div>
5656

5757
<!-- Navigation Items-->
58-
<app-navigation-menu />
58+
<bb-dynamic-navigation-menu />
5959

6060
<!-- Topbar Content Area (a.k.a. Right Topbar Area) -->
6161
<div class="bb-layout__topbar-content-area">

‎apps/golden-sample-app/src/app/app.component.scss‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
.main-content {
22
padding: 20px;
3-
}
3+
}
4+
app-navigation-menu {
5+
max-width: 70%;
6+
overflow: auto;
7+
}

‎apps/golden-sample-app/src/app/app.component.spec.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
33
import { HttpClientTestingModule } from '@angular/common/http/testing';
44
import { RouterTestingModule } from '@angular/router/testing';
55
import { ActivityMonitorService, AuthService } from '@backbase/identity-auth';
6-
import { LOCALES_LIST, LocalesService } from '@backbase/shared/util/app-core';
6+
import {
7+
LOCALES_LIST,
8+
LocalesService,
9+
NAVIGATION_MENU_CONFIG,
10+
} from '@backbase/shared/util/app-core';
711
import { LayoutService } from '@backbase/ui-ang/layout';
812
import { OAuthService } from 'angular-oauth2-oidc';
913
import { of } from 'rxjs';
@@ -49,6 +53,7 @@ describe('AppComponent', () => {
4953
{ provide: AuthService, useValue: mockAuthService },
5054
{ provide: LocalesService, useValue: mockLocalesService },
5155
{ provide: LOCALES_LIST, useValue: mockLocalesList },
56+
{ provide: NAVIGATION_MENU_CONFIG, useValue: [] },
5257
],
5358
schemas: [NO_ERRORS_SCHEMA],
5459
}).compileComponents();

‎apps/golden-sample-app/src/app/app.component.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,25 @@ import {
55
LogoutTrackerEvent,
66
Tracker,
77
} from '@backbase/foundation-ang/observability';
8-
import { ActivityMonitorModule } from '@backbase/shared/feature/auth';
8+
import { ActivityMonitorComponent } from '@backbase/shared/feature/auth';
9+
import { DynamicNavigationMenuComponent } from '@backbase/shared/feature/navigation-menu';
910
import { IconModule } from '@backbase/ui-ang/icon';
1011
import { LayoutService } from '@backbase/ui-ang/layout';
1112
import { LogoModule } from '@backbase/ui-ang/logo';
1213
import { OAuthService } from 'angular-oauth2-oidc';
1314
import { LocaleSelectorComponent } from './locale-selector/locale-selector.component';
14-
import { NavigationMenuModule } from './navigation-menu/navigation-menu.module';
15-
import { ThemeSwitcherModule } from './theme-switcher/theme-switcher.component.module';
15+
import { ThemeSwitcherComponent } from './theme-switcher/theme-switcher.component';
1616

1717
@Component({
1818
selector: 'app-root',
1919
templateUrl: './app.component.html',
2020
styleUrls: ['./app.component.scss'],
2121
imports: [
22-
ActivityMonitorModule,
22+
ActivityMonitorComponent,
2323
CommonModule,
2424
LogoModule,
25-
NavigationMenuModule,
26-
ThemeSwitcherModule,
25+
DynamicNavigationMenuComponent,
26+
ThemeSwitcherComponent,
2727
LocaleSelectorComponent,
2828
IconModule,
2929
RouterOutlet,

0 commit comments

Comments
 (0)