Do not setup mocks when useMocks option is false

Author: daiscog

eslint.config.mjs

@@ -13,7 +13,7 @@ export default [
       '@nx/enforce-module-boundaries': [
         'error',
         {
-          enforceBuildableLibDependency: true,
+          enforceBuildableLibDependency: false,
           allow: ['^.*/eslint(\\.base)?\\.config\\.[cm]?js$'],
           depConstraints: [
             {

libs/transactions-journey/e2e-tests/fixture/transaction.ts

@@ -14,14 +14,18 @@ import { MakeTransferPage } from '../page-objects/pages/make-transfer';
 
 export const test = baseTest.extend<TransactionFixture>({
   // mocks data setup, can be overridden or bypassed via "useMocks"
-  transactionMockSetup: async ({ page }, use) =>
-    await use((transactions: Partial<TransactionDetailsDataType>[]) =>
-      setupPageMocks(page, addTransactionsToMock(transactions))
-    ),
-  transactionsMockSetup: async ({ page }, use) =>
-    use((transactions: TransactionsListDataType) =>
-      setupPageMocks(page, defaultTransactionsMock)
-    ),
+  transactionMockSetup: async ({ page, useMocks }, use) =>
+    await use((transactions: Partial<TransactionDetailsDataType>[]) => {
+      if (useMocks) {
+        setupPageMocks(page, addTransactionsToMock(transactions));
+      }
+    }),
+  transactionsMockSetup: async ({ page, useMocks }, use) =>
+    await use(() => {
+      if (useMocks) {
+        setupPageMocks(page, defaultTransactionsMock);
+      }
+    }),
   makeTransferPage: async ({ page, baseURL }, use) => {
     await use(new MakeTransferPage(page, { baseURL, url: '/make-transfer' }));
   },

libs/transactions-journey/e2e-tests/model/transaction.ts

@@ -44,6 +44,7 @@ export interface TransactionFixture {
   makeTransferPage: MakeTransferPage;
   transactionDetailsPage: TransactionDetailsPage;
   transactionsPage: TransactionsPage;
+  useMocks: boolean;
 }
 
 export const getAmountValue = (

libs/transactions-journey/e2e-tests/specs/transaction-details.spec.ts

@@ -12,15 +12,7 @@ export function testTransactionDetails(
 ) {
   test.describe(
     'Transactions details',
-    {
-      tag: [
-        '@e2e',
-        '@transactions',
-        '@transactions-details',
-        '@mocks',
-        '@ephemeral',
-      ],
-    },
+    { tag: ['@e2e', '@transactions', '@transactions-details', '@mocks'] },
     () => {
       test.beforeEach(async ({ transactionMockSetup }) => {
         await transactionMockSetup(testData.transactions);