Refactor default replication rule priority

Author: ppolewicz

b2sdk/replication/setting.py

@@ -22,11 +22,13 @@ class ReplicationRule:
     prefix and rule name.
     """
 
+    DEFAULT_PRIORITY: ClassVar[int] = 128
+
     destination_bucket_id: str
     name: str
     file_name_prefix: str = ''
     is_enabled: bool = True
-    priority: int = 128
+    priority: int = DEFAULT_PRIORITY
     include_existing_files: bool = False
 
     REPLICATION_RULE_REGEX: ClassVar = re.compile(r'^[a-zA-Z0-9_\-]{1,64}$')
@@ -41,10 +43,12 @@ def __post_init__(self):
             raise ValueError('replication rule name is invalid')
 
         if not (self.MIN_PRIORITY <= self.priority <= self.MAX_PRIORITY):
-            raise ValueError('priority should be within [%d, %d] interval' % (
-                self.MIN_PRIORITY,
-                self.MAX_PRIORITY,
-            ))
+            raise ValueError(
+                'priority should be within [%d, %d] interval' % (
+                    self.MIN_PRIORITY,
+                    self.MAX_PRIORITY,
+                )
+            )
 
     def as_dict(self) -> dict:
         return {

b2sdk/replication/setup.py

@@ -33,8 +33,11 @@
 class ReplicationSetupHelper(metaclass=B2TraceMeta):
     """ class with various methods that help with repliction management """
     PRIORITY_OFFSET: ClassVar[int] = 5  #: how far to to put the new rule from the existing rules
-    DEFAULT_PRIORITY: ClassVar[int] = ReplicationRule.priority  #: what priority to set if there are no preexisting rules
-    MAX_PRIORITY: ClassVar[int] = ReplicationRule.MAX_PRIORITY  #: maximum allowed priority of a replication rule
+    DEFAULT_PRIORITY: ClassVar[
+        int
+    ] = ReplicationRule.DEFAULT_PRIORITY  #: what priority to set if there are no preexisting rules
+    MAX_PRIORITY: ClassVar[
+        int] = ReplicationRule.MAX_PRIORITY  #: maximum allowed priority of a replication rule
     DEFAULT_SOURCE_CAPABILITIES: ClassVar[Tuple[str, ...]] = (
         'readFiles',
         'readFileLegalHolds',

test/integration/test_raw_api.py

@@ -201,7 +201,7 @@ def raw_api_test_helper(raw_api, should_cleanup_old_buckets):
                                         "fileNamePrefix": "",
                                         "includeExistingFiles": True,
                                         "isEnabled": True,
-                                        "priority": 1,
+                                        "priority": 128,
                                         "replicationRuleName": "test-rule"
                                     },
                                 ],